[GitHub] sijie closed pull request #1486: [table service] dlog configuration settings are not propagated

[GitBox <gi...@apache.org>]

sijie closed pull request #1486: [table service] dlog configuration settings are not propagated
URL: https://github.com/apache/bookkeeper/pull/1486
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/stream/server/src/main/java/org/apache/bookkeeper/stream/server/StorageServer.java b/stream/server/src/main/java/org/apache/bookkeeper/stream/server/StorageServer.java
index e0774dee1..ad8491e6b 100644
--- a/stream/server/src/main/java/org/apache/bookkeeper/stream/server/StorageServer.java
+++ b/stream/server/src/main/java/org/apache/bookkeeper/stream/server/StorageServer.java
@@ -226,6 +226,7 @@ public static LifecycleComponent buildStorageServer(CompositeConfiguration conf,
         BookieWatchService bkWatchService;
         {
             DistributedLogConfiguration dlogConf = new DistributedLogConfiguration();
+            dlogConf.loadConf(dlConf);
             bkWatchService = new BookieWatchService(
                 dlogConf.getEnsembleSize(),
                 bkConf,
diff --git a/stream/server/src/main/java/org/apache/bookkeeper/stream/server/service/BookieWatchService.java b/stream/server/src/main/java/org/apache/bookkeeper/stream/server/service/BookieWatchService.java
index cfac0dab2..5a645d389 100644
--- a/stream/server/src/main/java/org/apache/bookkeeper/stream/server/service/BookieWatchService.java
+++ b/stream/server/src/main/java/org/apache/bookkeeper/stream/server/service/BookieWatchService.java
@@ -81,8 +81,9 @@ private static void waitingForNumBookies(RegistrationClient client, int minNumBo
         while (bookies.size() < minNumBookies) {
             TimeUnit.SECONDS.sleep(1);
             bookies = FutureUtils.result(client.getWritableBookies()).getValue();
-            log.info("Only {} bookies are live since {} seconds elapsed, wait for another 1 second",
-                bookies.size(), stopwatch.elapsed(TimeUnit.SECONDS));
+            log.info("Only {} bookies are live since {} seconds elapsed, "
+                + "wait for another {} bookies for another 1 second",
+                bookies.size(), minNumBookies - bookies.size(), stopwatch.elapsed(TimeUnit.SECONDS));
         }
     }
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services