You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Zoltan Haindrich <ki...@rxd.hu> on 2016/12/09 13:24:44 UTC

Review Request 54584: HIVE-14998 Fix and update test: TestPluggableHiveSessionImpl

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54584/
-----------------------------------------------------------

Review request for hive.


Bugs: HIVE-14998
    https://issues.apache.org/jira/browse/HIVE-14998


Repository: hive-git


Description
-------

* this test was not working
* removed unneeded constructors - as they are misleading, because these classes are only constructed via reflection
* test now also covers UGI


Diffs
-----

  itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestHiveSessionImpl.java c7fa5da8eadbaad71e68f04f201bf254b3b01c9b 
  service/src/java/org/apache/hive/service/AbstractService.java a58330540c51c29b6deece68fffe98602e08f0a6 
  service/src/java/org/apache/hive/service/cli/CLIService.java 6d07d0cd0c25d7bf1f544554cc114461056cc3fe 
  service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 8f5e92e6ba669bc341d86b27d0167fb5fb303bb8 
  service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java afed9e2e99da40c1199ad44436c38b74263625ff 
  service/src/test/org/apache/hive/service/cli/session/TestPluggableHiveSessionImpl.java b1f3917ee219e2c5cb8d71fb8b9602cb23b21cd6 

Diff: https://reviews.apache.org/r/54584/diff/


Testing
-------


Thanks,

Zoltan Haindrich