You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/04/17 07:31:37 UTC
[GitHub] [hadoop] nandakumar131 commented on a change in pull request #711:
HDDS-1368. Cleanup old ReplicationManager code from SCM.
nandakumar131 commented on a change in pull request #711: HDDS-1368. Cleanup old ReplicationManager code from SCM.
URL: https://github.com/apache/hadoop/pull/711#discussion_r276112100
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/command/CommandStatusReportHandler.java
##########
@@ -54,32 +55,14 @@ public void onMessage(CommandStatusReportFromDatanode report,
cmdStatusList.forEach(cmdStatus -> {
LOGGER.trace("Emitting command status for id:{} type: {}", cmdStatus
.getCmdId(), cmdStatus.getType());
- switch (cmdStatus.getType()) {
- case replicateContainerCommand:
- publisher.fireEvent(SCMEvents.REPLICATION_STATUS, new
- ReplicationStatus(cmdStatus));
- if (cmdStatus.getStatus() == CommandStatus.Status.EXECUTED) {
- publisher.fireEvent(SCMEvents.REPLICATION_COMPLETE,
- new ReplicationManager.ReplicationCompleted(
- cmdStatus.getCmdId()));
- }
- break;
- case deleteBlocksCommand:
+ if (cmdStatus.getType() == SCMCommandProto.Type.deleteBlocksCommand) {
Review comment:
Yes, no other command uses CommandWatcher anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org