You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/03/19 19:43:25 UTC
[GitHub] codecov-io commented on issue #4630: [Bug fix] Fixed/Refactored annotation layer code so that non-timeseries annotations are applied based on the updated chart object after adding all data
codecov-io commented on issue #4630: [Bug fix] Fixed/Refactored annotation layer code so that non-timeseries annotations are applied based on the updated chart object after adding all data
URL: https://github.com/apache/incubator-superset/pull/4630#issuecomment-374344593
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4630?src=pr&el=h1) Report
> Merging [#4630](https://codecov.io/gh/apache/incubator-superset/pull/4630?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/97afcd5809269e885a0dde349081802a427c5674?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/4630?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4630 +/- ##
==========================================
+ Coverage 71.22% 71.23% +<.01%
==========================================
Files 190 190
Lines 14880 14884 +4
Branches 1098 1099 +1
==========================================
+ Hits 10598 10602 +4
Misses 4279 4279
Partials 3 3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4630?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/javascripts/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4630/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NoYXJ0L0NoYXJ0LmpzeA==) | `64.95% <0%> (-0.56%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/4630/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `58.25% <0%> (+0.58%)` | :arrow_up: |
| [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/4630/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `98.75% <0%> (+1.25%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4630?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4630?src=pr&el=footer). Last update [97afcd5...f9134ec](https://codecov.io/gh/apache/incubator-superset/pull/4630?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services