You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/26 15:46:23 UTC

[GitHub] [flink] walterddr commented on a change in pull request #9227: [FLINK-13347] [table-planner] should handle SEMI/ANTI JoinRelType in switch case

walterddr commented on a change in pull request #9227: [FLINK-13347] [table-planner] should handle SEMI/ANTI JoinRelType in switch case
URL: https://github.com/apache/flink/pull/9227#discussion_r307800633
 
 

 ##########
 File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamJoinToCoProcessTranslator.scala
 ##########
 @@ -145,6 +145,7 @@ class DataStreamJoinToCoProcessTranslator(
           genFunction.name,
           genFunction.code,
           queryConfig)
+      case _ => throw new TableException(s"$joinType is not supported.")
 
 Review comment:
   I think this one should throw `ValidationException` similar to other Translator classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services