You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/23 03:54:28 UTC
[GitHub] [spark] LuciferYang commented on a change in pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
LuciferYang commented on a change in pull request #34676:
URL: https://github.com/apache/spark/pull/34676#discussion_r754788216
##########
File path: pom.xml
##########
@@ -3580,6 +3580,18 @@
</os>
</activation>
</profile>
+ <profile>
+ <id>mac-on-apple-silicon</id>
+ <properties>
+ <test.exclude.tags>org.apache.spark.tags.ExtendedLevelDBTest,org.apache.spark.tags.ExtendedRocksDBTest</test.exclude.tags>
Review comment:
If the user really needs to customize `-Dtest.default.exclude.tags` instead of `-Dtest.exclude.tags`, it is better to modify the developer's doc
##########
File path: pom.xml
##########
@@ -3580,6 +3580,18 @@
</os>
</activation>
</profile>
+ <profile>
+ <id>mac-on-apple-silicon</id>
+ <properties>
+ <test.exclude.tags>org.apache.spark.tags.ExtendedLevelDBTest,org.apache.spark.tags.ExtendedRocksDBTest</test.exclude.tags>
Review comment:
If user really needs to customize `-Dtest.default.exclude.tags` instead of `-Dtest.exclude.tags`, it is better to modify the developer's doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org