You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/10/18 02:52:26 UTC
[PR] [MINOR][INFRA] Skip if JIRA ID is an empty string [spark]
HyukjinKwon opened a new pull request, #43417:
URL: https://github.com/apache/spark/pull/43417
### What changes were proposed in this pull request?
This PR skips when an empty string is provided as a JIRA ID.
### Why are the changes needed?
When you merge a minor PR that does not have a JIRA ID, and you say `y` to update associated JIRA, you face an error as below:
```
...
Would you like to update an associated JIRA? (y/n): y
Enter a JIRA id []:
ASF JIRA could not find
JiraError HTTP 405 url: https://issues.apache.org/jira/rest/api/2/issue/
response headers = {'Date': 'Wed, 18 Oct 2023 02:44:24 GMT', 'Server': 'Apache', 'X-AREQUESTID': '164x103019855x17', 'X-ASESSIONID': '1bxvboa', 'Referrer-Policy': 'strict-origin-when-cross-origin', 'X-XSS-Protection': '1; mode=block', 'X-Content-Type-Options': 'nosniff', 'X-Frame-Options': 'SAMEORIGIN', 'Content-Security-Policy': "frame-ancestors 'self'", 'Strict-Transport-Security': 'max-age=31536000', 'X-Seraph-LoginReason': 'OK', 'X-AUSERNAME': 'gurwls223', 'Allow': 'POST,OPTIONS', 'Content-Type': 'text/html;charset=UTF-8', 'Content-Length': '0', 'Via': '1.1 jira2-he-de.apache.org', 'Keep-Alive': 'timeout=15, max=100', 'Connection': 'Keep-Alive'}
response text =
...
```
After this PR, it doesn't fail but shows a warning `JIRA ID not found, skipping`.
### Does this PR introduce _any_ user-facing change?
No, dev-only.
### How was this patch tested?
I am going to test this change against this PR.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][INFRA] Skip if JIRA ID is an empty string [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #43417: [MINOR][INFRA] Skip if JIRA ID is an empty string
URL: https://github.com/apache/spark/pull/43417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][INFRA] Skip if JIRA ID is an empty string [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #43417:
URL: https://github.com/apache/spark/pull/43417#discussion_r1363075044
##########
dev/merge_spark_pr.py:
##########
@@ -246,6 +246,9 @@ def resolve_jira_issue(merge_branches, comment, default_jira_id=""):
jira_id = input("Enter a JIRA id [%s]: " % default_jira_id)
if jira_id == "":
jira_id = default_jira_id
+ if jira_id == "":
Review Comment:
We already have the same condition in line 247. Do we need this `if` statement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][INFRA] Skip if JIRA ID is an empty string [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #43417:
URL: https://github.com/apache/spark/pull/43417#discussion_r1363075044
##########
dev/merge_spark_pr.py:
##########
@@ -246,6 +246,9 @@ def resolve_jira_issue(merge_branches, comment, default_jira_id=""):
jira_id = input("Enter a JIRA id [%s]: " % default_jira_id)
if jira_id == "":
jira_id = default_jira_id
+ if jira_id == "":
Review Comment:
We already have the same condition in line 247. Do we need this `if` statement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][INFRA] Skip if JIRA ID is an empty string [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43417:
URL: https://github.com/apache/spark/pull/43417#issuecomment-1767552585
I used this script to merge this PR. Thank you, @HyukjinKwon ! This has been really annoying to me too. 😄
```
...
Would you like to update an associated JIRA? (y/n): y
Enter a JIRA id []:
JIRA ID not found, skipping.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org