You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/12/08 08:34:34 UTC

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1406: [CALCITE-3243] Incomplete validation of operands in JSON functions

zhztheplayer commented on a change in pull request #1406: [CALCITE-3243] Incomplete validation of operands in JSON functions
URL: https://github.com/apache/calcite/pull/1406#discussion_r355168982
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/sql/fun/SqlJsonExistsFunction.java
 ##########
 @@ -34,14 +34,15 @@ public SqlJsonExistsFunction() {
     super("JSON_EXISTS", SqlKind.OTHER_FUNCTION,
         ReturnTypes.cascade(ReturnTypes.BOOLEAN, SqlTypeTransforms.FORCE_NULLABLE), null,
         OperandTypes.or(
-            OperandTypes.family(SqlTypeFamily.ANY, SqlTypeFamily.CHARACTER),
 
 Review comment:
   Right. In our code base JSON functions usually accepts both character string and JSON inputs. We don't have a individual data type for JSON so we use `ANY` instead. See a ticket of JSON data type support:
   
   https://issues.apache.org/jira/browse/CALCITE-2869

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services