You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Mark Struberg <st...@yahoo.de> on 2011/10/26 14:18:59 UTC
[VOTE] extend maximum allowed line length from 120 to 160
Hi!
Currently we have really long and very descriptive variable names in MyFaces.
I personally like that, but due to that we are really often exceeding the 120 character per line.
Thus my question: should we extend this from 120 to 160 characters being allowed per line?
[+1] yup make 160 the max default
[0] don't care
[-1] nope, let's stick with 120
open for 72h ...
Please make use of your vote, because I will activate the checkstyle checks soon ;)
here is my +1.
LieGrue,
strub
Re: [VOTE] extend maximum allowed line length from 120 to 160
Posted by Rudy De Busscher <rd...@gmail.com>.
+0
I'll find 160 much, even with a wide screen.
On 26 October 2011 21:39, Leonardo Uribe <lu...@gmail.com> wrote:
> +0
>
> 2011/10/26 Grant Smith <wo...@gmail.com>:
> > +1
> >
> > On Wed, Oct 26, 2011 at 7:23 AM, Michael Kurz <mi...@gmx.at> wrote:
> >>
> >> -1
> >>
> >> Am 26.10.2011 14:18, schrieb Mark Struberg:
> >>>
> >>> Hi!
> >>>
> >>> Currently we have really long and very descriptive variable names in
> >>> MyFaces.
> >>>
> >>> I personally like that, but due to that we are really often exceeding
> the
> >>> 120 character per line.
> >>>
> >>> Thus my question: should we extend this from 120 to 160 characters
> being
> >>> allowed per line?
> >>>
> >>> [+1] yup make 160 the max default
> >>> [0] don't care
> >>> [-1] nope, let's stick with 120
> >>>
> >>> open for 72h ...
> >>>
> >>>
> >>> Please make use of your vote, because I will activate the checkstyle
> >>> checks soon ;)
> >>>
> >>> here is my +1.
> >>>
> >>> LieGrue,
> >>> strub
> >>>
> >
> >
> >
> > --
> > Grant Smith - V.P. Information Technology
> > Marathon Computer Systems, LLC.
> >
> >
>
--
Rudy De Busscher
http://www.c4j.be
Re: [VOTE] extend maximum allowed line length from 120 to 160
Posted by Leonardo Uribe <lu...@gmail.com>.
+0
2011/10/26 Grant Smith <wo...@gmail.com>:
> +1
>
> On Wed, Oct 26, 2011 at 7:23 AM, Michael Kurz <mi...@gmx.at> wrote:
>>
>> -1
>>
>> Am 26.10.2011 14:18, schrieb Mark Struberg:
>>>
>>> Hi!
>>>
>>> Currently we have really long and very descriptive variable names in
>>> MyFaces.
>>>
>>> I personally like that, but due to that we are really often exceeding the
>>> 120 character per line.
>>>
>>> Thus my question: should we extend this from 120 to 160 characters being
>>> allowed per line?
>>>
>>> [+1] yup make 160 the max default
>>> [0] don't care
>>> [-1] nope, let's stick with 120
>>>
>>> open for 72h ...
>>>
>>>
>>> Please make use of your vote, because I will activate the checkstyle
>>> checks soon ;)
>>>
>>> here is my +1.
>>>
>>> LieGrue,
>>> strub
>>>
>
>
>
> --
> Grant Smith - V.P. Information Technology
> Marathon Computer Systems, LLC.
>
>
Re: [VOTE] extend maximum allowed line length from 120 to 160
Posted by Grant Smith <wo...@gmail.com>.
+1
On Wed, Oct 26, 2011 at 7:23 AM, Michael Kurz <mi...@gmx.at> wrote:
> -1
>
> Am 26.10.2011 14:18, schrieb Mark Struberg:
>
> Hi!
>>
>> Currently we have really long and very descriptive variable names in
>> MyFaces.
>>
>> I personally like that, but due to that we are really often exceeding the
>> 120 character per line.
>>
>> Thus my question: should we extend this from 120 to 160 characters being
>> allowed per line?
>>
>> [+1] yup make 160 the max default
>> [0] don't care
>> [-1] nope, let's stick with 120
>>
>> open for 72h ...
>>
>>
>> Please make use of your vote, because I will activate the checkstyle
>> checks soon ;)
>>
>> here is my +1.
>>
>> LieGrue,
>> strub
>>
>>
--
Grant Smith - V.P. Information Technology
Marathon Computer Systems, LLC.
Re: [VOTE] extend maximum allowed line length from 120 to 160
Posted by Michael Kurz <mi...@gmx.at>.
-1
Am 26.10.2011 14:18, schrieb Mark Struberg:
> Hi!
>
> Currently we have really long and very descriptive variable names in MyFaces.
>
> I personally like that, but due to that we are really often exceeding the 120 character per line.
>
> Thus my question: should we extend this from 120 to 160 characters being allowed per line?
>
> [+1] yup make 160 the max default
> [0] don't care
> [-1] nope, let's stick with 120
>
> open for 72h ...
>
>
> Please make use of your vote, because I will activate the checkstyle checks soon ;)
>
> here is my +1.
>
> LieGrue,
> strub
>
Re: [VOTE] [RESULT] (or so) extend maximum allowed line length from 120 to 160
Posted by Mark Struberg <st...@yahoo.de>.
Hi folks!
I actually didn't really count the vote, but as there were a few -1 and a few +0 I'd like to revoke the vote and would say we stick with 120 chars/line.
Which means I'll go on and fix the linebreaks in myfaces-core (*sigh*)
LieGrue,
strub
----- Original Message -----
> From: Mark Struberg <st...@yahoo.de>
> To: MyFaces Development <de...@myfaces.apache.org>
> Cc:
> Sent: Friday, October 28, 2011 10:59 AM
> Subject: Re: [VOTE] extend maximum allowed line length from 120 to 160
>
> Hi Volker,
>
> I already fixed 1111 issues in myfaces-core-api and about another 1000 in
> myfaces-core-impl (not only line-length).
> We had a lot lines which even exceeded the 160 chars, but I was really tired
> already and relaxed my own local checkstyle rules to 160 chars now.
>
> But since you are a MyFaces Committer (even PMC) too, I'm perfectly
> fine with 120 if you could volunteer and fix another 600 checkstyle issues
> because of that - thanks a lot in advance!
>
> It's pretty easy. Just go to myfaces/core/impl and run
>
> $:> mvn checkstyle:check -Pcheckstyle
>
> you then get all the checkstyle errors in a file
>
> $:> less target/checkstyle-results.xml
>
> just search for 'error'.
>
> txs again and LieGrue,
> strub
>
>
>
> ----- Original Message -----
>> From: Mark Struberg <st...@yahoo.de>
>> To: myfaces-dev <de...@myfaces.apache.org>
>> Cc:
>> Sent: Friday, October 28, 2011 10:27 AM
>> Subject: Re: [VOTE] extend maximum allowed line length from 120 to 160
>>
>> Volker, source code is no newspaper.
>>
>> Imo 80 chars is definitely fine for C or perl with cryptic syntax
> (programmed
>> that myself for 20 years) but it's not nice for languages where
> descriptive
>> variable and method names are 'socially accepted' ;)
>>
>>
>> LieGrue,
>> strub
>>
>>
>>
>> ----- Original Message -----
>>> From: Volker Weber <v....@inexso.de>
>>> To: MyFaces Development <de...@myfaces.apache.org>; Mark Struberg
>> <st...@yahoo.de>
>>> Cc:
>>> Sent: Friday, October 28, 2011 9:22 AM
>>> Subject: Re: [VOTE] extend maximum allowed line length from 120 to 160
>>>
>>> Hi,
>>>
>>> -1.
>>>
>>> In my opinion 160 characters is much to wide, the current 120 is not
>>> the preferred, but the allowed max width.
>>> I vote for 80 characters as preferred max width.
>>>
>>> In general reading is easier if the text is not too wide, thats why
>>> newspaper articles are layouted in columns.
>>>
>>>
>>> Regards,
>>> Volker
>>>
>>> 2011/10/26 Mark Struberg <st...@yahoo.de>:
>>>> Hi!
>>>>
>>>> Currently we have really long and very descriptive variable names
> in
>>> MyFaces.
>>>>
>>>> I personally like that, but due to that we are really often
> exceeding
>> the
>>> 120 character per line.
>>>>
>>>> Thus my question: should we extend this from 120 to 160
> characters
>> being
>>> allowed per line?
>>>>
>>>> [+1] yup make 160 the max default
>>>> [0] don't care
>>>> [-1] nope, let's stick with 120
>>>>
>>>> open for 72h ...
>>>>
>>>>
>>>> Please make use of your vote, because I will activate the
> checkstyle
>> checks
>>> soon ;)
>>>>
>>>> here is my +1.
>>>>
>>>> LieGrue,
>>>> strub
>>>>
>>>>
>>>
>>>
>>>
>>> --
>>> inexso - information exchange solutions GmbH
>>> Ofener Str. 30 | 26121 Oldenburg
>>> Tel.: +49 441 219 730 56 |
>>> FAX: +49 441 219 730 66 | eMail: volker.weber@inexso.de
>>>
>>> Firmensitz: Oldenburg | Amtsgericht Oldenburg HRB 205251
>>> Geschäftsführer: Stefan Schulte, Michael Terschüren
>>>
>>
>
Re: [VOTE] extend maximum allowed line length from 120 to 160
Posted by Mark Struberg <st...@yahoo.de>.
Hi Volker,
I already fixed 1111 issues in myfaces-core-api and about another 1000 in myfaces-core-impl (not only line-length).
We had a lot lines which even exceeded the 160 chars, but I was really tired already and relaxed my own local checkstyle rules to 160 chars now.
But since you are a MyFaces Committer (even PMC) too, I'm perfectly
fine with 120 if you could volunteer and fix another 600 checkstyle issues
because of that - thanks a lot in advance!
It's pretty easy. Just go to myfaces/core/impl and run
$:> mvn checkstyle:check -Pcheckstyle
you then get all the checkstyle errors in a file
$:> less target/checkstyle-results.xml
just search for 'error'.
txs again and LieGrue,
strub
----- Original Message -----
> From: Mark Struberg <st...@yahoo.de>
> To: myfaces-dev <de...@myfaces.apache.org>
> Cc:
> Sent: Friday, October 28, 2011 10:27 AM
> Subject: Re: [VOTE] extend maximum allowed line length from 120 to 160
>
> Volker, source code is no newspaper.
>
> Imo 80 chars is definitely fine for C or perl with cryptic syntax (programmed
> that myself for 20 years) but it's not nice for languages where descriptive
> variable and method names are 'socially accepted' ;)
>
>
> LieGrue,
> strub
>
>
>
> ----- Original Message -----
>> From: Volker Weber <v....@inexso.de>
>> To: MyFaces Development <de...@myfaces.apache.org>; Mark Struberg
> <st...@yahoo.de>
>> Cc:
>> Sent: Friday, October 28, 2011 9:22 AM
>> Subject: Re: [VOTE] extend maximum allowed line length from 120 to 160
>>
>> Hi,
>>
>> -1.
>>
>> In my opinion 160 characters is much to wide, the current 120 is not
>> the preferred, but the allowed max width.
>> I vote for 80 characters as preferred max width.
>>
>> In general reading is easier if the text is not too wide, thats why
>> newspaper articles are layouted in columns.
>>
>>
>> Regards,
>> Volker
>>
>> 2011/10/26 Mark Struberg <st...@yahoo.de>:
>>> Hi!
>>>
>>> Currently we have really long and very descriptive variable names in
>> MyFaces.
>>>
>>> I personally like that, but due to that we are really often exceeding
> the
>> 120 character per line.
>>>
>>> Thus my question: should we extend this from 120 to 160 characters
> being
>> allowed per line?
>>>
>>> [+1] yup make 160 the max default
>>> [0] don't care
>>> [-1] nope, let's stick with 120
>>>
>>> open for 72h ...
>>>
>>>
>>> Please make use of your vote, because I will activate the checkstyle
> checks
>> soon ;)
>>>
>>> here is my +1.
>>>
>>> LieGrue,
>>> strub
>>>
>>>
>>
>>
>>
>> --
>> inexso - information exchange solutions GmbH
>> Ofener Str. 30 | 26121 Oldenburg
>> Tel.: +49 441 219 730 56 |
>> FAX: +49 441 219 730 66 | eMail: volker.weber@inexso.de
>>
>> Firmensitz: Oldenburg | Amtsgericht Oldenburg HRB 205251
>> Geschäftsführer: Stefan Schulte, Michael Terschüren
>>
>
Re: [VOTE] extend maximum allowed line length from 120 to 160
Posted by Mark Struberg <st...@yahoo.de>.
Since I'm not getting warm with the MoinMoin, I just copied to my peoples account
http://people.apache.org/~struberg/apache_myfaces_checkstyle.xml
Mac users need to copy it to:
~/Library/Preferences/IntelliJIdea10/codestyles/apache_myfaces_checkstyle.xml
Linux users to:
~/.IntelliJIdea10/config/codestyles/
LieGrue,
strub
----- Original Message -----
> From: Mark Struberg <st...@yahoo.de>
> To: MyFaces Development <de...@myfaces.apache.org>
> Cc:
> Sent: Saturday, October 29, 2011 1:21 PM
> Subject: Re: [VOTE] extend maximum allowed line length from 120 to 160
>
> yes, I can share my current setting.
>
> I now fixed most occurrences, but there are a few classes which have 400++ LOC
> in one method, and I think this should get handled by someone which is more into
> myfaces-core than I am.
>
> I will attach my current config to the wiki.
>
> LieGrue,
> strub
>
>
>
> ----- Original Message -----
>> From: Michael Kurz <mi...@gmx.at>
>> To: dev@myfaces.apache.org
>> Cc:
>> Sent: Saturday, October 29, 2011 1:16 PM
>> Subject: Re: [VOTE] extend maximum allowed line length from 120 to 160
>>
>> Hi Mark,
>>
>> I can help you on this one - but probably not before Monday or Tuesday.
>>
>> Btw.: Do you already have a settings file for IntelliJ 10.5?
>>
>> regards
>> Michael
>>
>>
>> Am 28.10.2011 20:49, schrieb Mark Struberg:
>>> As I said earlier, the 160 char/line proposal was just made because
> I'm
>> pretty tired of fixing the checkstyle issues in myfaces-core already.
>>>
>>>
>>> If anyone is up for taking that piece of cake, then I'd be happy.
>> Otherwise I will do it over the weekend.
>>>
>>> LieGrue,
>>> strub
>>>
>>>> ________________________________
>>>> From: Blake Sullivan<bl...@oracle.com>
>>>> To: MyFaces Development<de...@myfaces.apache.org>
>>>> Cc: Gerhard Petracek<ge...@gmail.com>
>>>> Sent: Friday, October 28, 2011 8:13 PM
>>>> Subject: Re: [VOTE] extend maximum allowed line length from 120 to
> 160
>>>>
>>>>
>>>> I personally find 120 characters to be the best balance. On the
> bright
>> side, I expect that once we can use the diamond operator in JDK 7, the
> pressure
>> for longer lines will decrease.
>>>>
>>>> -- Blake Sullivan
>>>>
>>>> On 10/28/11 10:33 AM, Gerhard Petracek wrote:
>>>> @80: -1!
>>>>> @rest: +0
>>>>>
>>>>> regards,
>>>>> gerhard
>>>>>
>>>>> http://www.irian.at
>>>>>
>>>>> Your JSF powerhouse -
>>>>> JSF Consulting, Development and
>>>>> Courses in English and German
>>>>>
>>>>> Professional Support for Apache MyFaces
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> 2011/10/28 Volker Weber<v....@inexso.de>
>>>>>
>>>>> Hi Mark,
>>>>>>
>>>>>> 2011/10/28 Mark Struberg<st...@yahoo.de>:
>>>>>>
>>>>>>> Volker, source code is no newspaper.
>>>>>>
>>>>>>
>>> just wanted to support the statement of easier reading in smaller
>>>>>> columns, of cause code is no newspaper, but it still need
>>> easy
>>>>>> reading.
>>>>>>
>>>>>> I don't like to scroll left and right to read the
> code, and
>>> even at
>>>>>> work were i got the widest screen the 1920px did not
> suffice
>>> to see
>>>>>> more than 120 characters with the project and structure
>>> sidebars left
>>>>>> and right, which i would not like to miss.
>>>>>>
>>>>>>
>>>>>> Regards,
>>>>>> Volker
>>>>>>
>>>>>>
>>>>>>
>>>>>>>
>>>>>>> Imo 80 chars is definitely fine for C or perl with
>>> cryptic syntax (programmed that myself for 20 years)
> but
>>> it's not nice for languages where descriptive
> variable
>>> and method names are 'socially accepted' ;)
>>>>>>>
>>>>>>>
>>>>>>> LieGrue,
>>>>>>> strub
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> ----- Original Message -----
>>>>>>>> From: Volker Weber<v....@inexso.de>
>>>>>>>> To: MyFaces
> Development<de...@myfaces.apache.org>;
>> Mark Struberg<st...@yahoo.de>
>>>>>>>> Cc:
>>>>>>>> Sent: Friday, October 28, 2011 9:22 AM
>>>>>>>> Subject: Re: [VOTE] extend maximum allowed line
>>> length from 120 to 160
>>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> -1.
>>>>>>>>
>>>>>>>> In my opinion 160 characters is much to wide,
>>> the current 120 is not
>>>>>>>> the preferred, but the allowed max width.
>>>>>>>> I vote for 80 characters as preferred max
>>> width.
>>>>>>>>
>>>>>>>> In general reading is easier if the text is not
>>> too wide, thats why
>>>>>>>> newspaper articles are layouted in columns.
>>>>>>>>
>>>>>>>>
>>>>>>>> Regards,
>>>>>>>> Volker
>>>>>>>>
>>>>>>>> 2011/10/26 Mark Struberg<st...@yahoo.de>:
>>>>>>>>> Hi!
>>>>>>>>>
>>>>>>>>> Currently we have really long and very
>>> descriptive variable names in
>>>>>>>> MyFaces.
>>>>>>>>>
>>>>>>>>> I personally like that, but due to that we
>>> are really often exceeding the
>>>>>>>> 120 character per line.
>>>>>>>>>
>>>>>>>>> Thus my question: should we extend this
>>> from 120 to 160 characters being
>>>>>>>> allowed per line?
>>>>>>>>>
>>>>>>>>> [+1] yup make 160 the max default
>>>>>>>>> [0] don't care
>>>>>>>>> [-1] nope, let's stick with 120
>>>>>>>>>
>>>>>>>>> open for 72h ...
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Please make use of your vote, because I
>>> will activate the checkstyle checks
>>>>>>>> soon ;)
>>>>>>>>>
>>>>>>>>> here is my +1.
>>>>>>>>>
>>>>>>>>> LieGrue,
>>>>>>>>> strub
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> inexso - information exchange solutions GmbH
>>>>>>>> Ofener Str. 30 | 26121 Oldenburg
>>>>>>>> Tel.: +49 441 219 730 56 |
>>>>>>>> FAX: +49 441 219 730 66 | eMail:
>> volker.weber@inexso.de
>>>>>>>>
>>>>>>>> Firmensitz: Oldenburg | Amtsgericht Oldenburg
>>> HRB 205251
>>>>>>>> Geschäftsführer: Stefan Schulte, Michael
>>> Terschüren
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> inexso - information exchange solutions GmbH
>>>>>> Ofener Str. 30 | 26121 Oldenburg
>>>>>> Tel.: +49 441 219 730 56 |
>>>>>> FAX: +49 441 219 730 66 | eMail: volker.weber@inexso.de
>>>>>>
>>>>>> Firmensitz: Oldenburg | Amtsgericht Oldenburg HRB 205251
>>>>>> Geschäftsführer: Stefan Schulte, Michael Terschüren
>>>>>>
>>>>>
>>>>
>>>>
>>>>
>>
>
Re: [VOTE] extend maximum allowed line length from 120 to 160
Posted by Mark Struberg <st...@yahoo.de>.
yes, I can share my current setting.
I now fixed most occurrences, but there are a few classes which have 400++ LOC in one method, and I think this should get handled by someone which is more into myfaces-core than I am.
I will attach my current config to the wiki.
LieGrue,
strub
----- Original Message -----
> From: Michael Kurz <mi...@gmx.at>
> To: dev@myfaces.apache.org
> Cc:
> Sent: Saturday, October 29, 2011 1:16 PM
> Subject: Re: [VOTE] extend maximum allowed line length from 120 to 160
>
> Hi Mark,
>
> I can help you on this one - but probably not before Monday or Tuesday.
>
> Btw.: Do you already have a settings file for IntelliJ 10.5?
>
> regards
> Michael
>
>
> Am 28.10.2011 20:49, schrieb Mark Struberg:
>> As I said earlier, the 160 char/line proposal was just made because I'm
> pretty tired of fixing the checkstyle issues in myfaces-core already.
>>
>>
>> If anyone is up for taking that piece of cake, then I'd be happy.
> Otherwise I will do it over the weekend.
>>
>> LieGrue,
>> strub
>>
>>> ________________________________
>>> From: Blake Sullivan<bl...@oracle.com>
>>> To: MyFaces Development<de...@myfaces.apache.org>
>>> Cc: Gerhard Petracek<ge...@gmail.com>
>>> Sent: Friday, October 28, 2011 8:13 PM
>>> Subject: Re: [VOTE] extend maximum allowed line length from 120 to 160
>>>
>>>
>>> I personally find 120 characters to be the best balance. On the bright
> side, I expect that once we can use the diamond operator in JDK 7, the pressure
> for longer lines will decrease.
>>>
>>> -- Blake Sullivan
>>>
>>> On 10/28/11 10:33 AM, Gerhard Petracek wrote:
>>> @80: -1!
>>>> @rest: +0
>>>>
>>>> regards,
>>>> gerhard
>>>>
>>>> http://www.irian.at
>>>>
>>>> Your JSF powerhouse -
>>>> JSF Consulting, Development and
>>>> Courses in English and German
>>>>
>>>> Professional Support for Apache MyFaces
>>>>
>>>>
>>>>
>>>>
>>>> 2011/10/28 Volker Weber<v....@inexso.de>
>>>>
>>>> Hi Mark,
>>>>>
>>>>> 2011/10/28 Mark Struberg<st...@yahoo.de>:
>>>>>
>>>>>> Volker, source code is no newspaper.
>>>>>
>>>>>
>> just wanted to support the statement of easier reading in smaller
>>>>> columns, of cause code is no newspaper, but it still need
>> easy
>>>>> reading.
>>>>>
>>>>> I don't like to scroll left and right to read the code, and
>> even at
>>>>> work were i got the widest screen the 1920px did not suffice
>> to see
>>>>> more than 120 characters with the project and structure
>> sidebars left
>>>>> and right, which i would not like to miss.
>>>>>
>>>>>
>>>>> Regards,
>>>>> Volker
>>>>>
>>>>>
>>>>>
>>>>>>
>>>>>> Imo 80 chars is definitely fine for C or perl with
>> cryptic syntax (programmed that myself for 20 years) but
>> it's not nice for languages where descriptive variable
>> and method names are 'socially accepted' ;)
>>>>>>
>>>>>>
>>>>>> LieGrue,
>>>>>> strub
>>>>>>
>>>>>>
>>>>>>
>>>>>> ----- Original Message -----
>>>>>>> From: Volker Weber<v....@inexso.de>
>>>>>>> To: MyFaces Development<de...@myfaces.apache.org>;
> Mark Struberg<st...@yahoo.de>
>>>>>>> Cc:
>>>>>>> Sent: Friday, October 28, 2011 9:22 AM
>>>>>>> Subject: Re: [VOTE] extend maximum allowed line
>> length from 120 to 160
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> -1.
>>>>>>>
>>>>>>> In my opinion 160 characters is much to wide,
>> the current 120 is not
>>>>>>> the preferred, but the allowed max width.
>>>>>>> I vote for 80 characters as preferred max
>> width.
>>>>>>>
>>>>>>> In general reading is easier if the text is not
>> too wide, thats why
>>>>>>> newspaper articles are layouted in columns.
>>>>>>>
>>>>>>>
>>>>>>> Regards,
>>>>>>> Volker
>>>>>>>
>>>>>>> 2011/10/26 Mark Struberg<st...@yahoo.de>:
>>>>>>>> Hi!
>>>>>>>>
>>>>>>>> Currently we have really long and very
>> descriptive variable names in
>>>>>>> MyFaces.
>>>>>>>>
>>>>>>>> I personally like that, but due to that we
>> are really often exceeding the
>>>>>>> 120 character per line.
>>>>>>>>
>>>>>>>> Thus my question: should we extend this
>> from 120 to 160 characters being
>>>>>>> allowed per line?
>>>>>>>>
>>>>>>>> [+1] yup make 160 the max default
>>>>>>>> [0] don't care
>>>>>>>> [-1] nope, let's stick with 120
>>>>>>>>
>>>>>>>> open for 72h ...
>>>>>>>>
>>>>>>>>
>>>>>>>> Please make use of your vote, because I
>> will activate the checkstyle checks
>>>>>>> soon ;)
>>>>>>>>
>>>>>>>> here is my +1.
>>>>>>>>
>>>>>>>> LieGrue,
>>>>>>>> strub
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> inexso - information exchange solutions GmbH
>>>>>>> Ofener Str. 30 | 26121 Oldenburg
>>>>>>> Tel.: +49 441 219 730 56 |
>>>>>>> FAX: +49 441 219 730 66 | eMail:
> volker.weber@inexso.de
>>>>>>>
>>>>>>> Firmensitz: Oldenburg | Amtsgericht Oldenburg
>> HRB 205251
>>>>>>> Geschäftsführer: Stefan Schulte, Michael
>> Terschüren
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> inexso - information exchange solutions GmbH
>>>>> Ofener Str. 30 | 26121 Oldenburg
>>>>> Tel.: +49 441 219 730 56 |
>>>>> FAX: +49 441 219 730 66 | eMail: volker.weber@inexso.de
>>>>>
>>>>> Firmensitz: Oldenburg | Amtsgericht Oldenburg HRB 205251
>>>>> Geschäftsführer: Stefan Schulte, Michael Terschüren
>>>>>
>>>>
>>>
>>>
>>>
>
Re: [VOTE] extend maximum allowed line length from 120 to 160
Posted by Michael Kurz <mi...@gmx.at>.
Hi Mark,
I can help you on this one - but probably not before Monday or Tuesday.
Btw.: Do you already have a settings file for IntelliJ 10.5?
regards
Michael
Am 28.10.2011 20:49, schrieb Mark Struberg:
> As I said earlier, the 160 char/line proposal was just made because I'm pretty tired of fixing the checkstyle issues in myfaces-core already.
>
>
> If anyone is up for taking that piece of cake, then I'd be happy. Otherwise I will do it over the weekend.
>
> LieGrue,
> strub
>
>> ________________________________
>> From: Blake Sullivan<bl...@oracle.com>
>> To: MyFaces Development<de...@myfaces.apache.org>
>> Cc: Gerhard Petracek<ge...@gmail.com>
>> Sent: Friday, October 28, 2011 8:13 PM
>> Subject: Re: [VOTE] extend maximum allowed line length from 120 to 160
>>
>>
>> I personally find 120 characters to be the best balance. On the bright side, I expect that once we can use the diamond operator in JDK 7, the pressure for longer lines will decrease.
>>
>> -- Blake Sullivan
>>
>> On 10/28/11 10:33 AM, Gerhard Petracek wrote:
>> @80: -1!
>>> @rest: +0
>>>
>>> regards,
>>> gerhard
>>>
>>> http://www.irian.at
>>>
>>> Your JSF powerhouse -
>>> JSF Consulting, Development and
>>> Courses in English and German
>>>
>>> Professional Support for Apache MyFaces
>>>
>>>
>>>
>>>
>>> 2011/10/28 Volker Weber<v....@inexso.de>
>>>
>>> Hi Mark,
>>>>
>>>> 2011/10/28 Mark Struberg<st...@yahoo.de>:
>>>>
>>>>> Volker, source code is no newspaper.
>>>>
>>>>
> just wanted to support the statement of easier reading in smaller
>>>> columns, of cause code is no newspaper, but it still need
> easy
>>>> reading.
>>>>
>>>> I don't like to scroll left and right to read the code, and
> even at
>>>> work were i got the widest screen the 1920px did not suffice
> to see
>>>> more than 120 characters with the project and structure
> sidebars left
>>>> and right, which i would not like to miss.
>>>>
>>>>
>>>> Regards,
>>>> Volker
>>>>
>>>>
>>>>
>>>>>
>>>>> Imo 80 chars is definitely fine for C or perl with
> cryptic syntax (programmed that myself for 20 years) but
> it's not nice for languages where descriptive variable
> and method names are 'socially accepted' ;)
>>>>>
>>>>>
>>>>> LieGrue,
>>>>> strub
>>>>>
>>>>>
>>>>>
>>>>> ----- Original Message -----
>>>>>> From: Volker Weber<v....@inexso.de>
>>>>>> To: MyFaces Development<de...@myfaces.apache.org>; Mark Struberg<st...@yahoo.de>
>>>>>> Cc:
>>>>>> Sent: Friday, October 28, 2011 9:22 AM
>>>>>> Subject: Re: [VOTE] extend maximum allowed line
> length from 120 to 160
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> -1.
>>>>>>
>>>>>> In my opinion 160 characters is much to wide,
> the current 120 is not
>>>>>> the preferred, but the allowed max width.
>>>>>> I vote for 80 characters as preferred max
> width.
>>>>>>
>>>>>> In general reading is easier if the text is not
> too wide, thats why
>>>>>> newspaper articles are layouted in columns.
>>>>>>
>>>>>>
>>>>>> Regards,
>>>>>> Volker
>>>>>>
>>>>>> 2011/10/26 Mark Struberg<st...@yahoo.de>:
>>>>>>> Hi!
>>>>>>>
>>>>>>> Currently we have really long and very
> descriptive variable names in
>>>>>> MyFaces.
>>>>>>>
>>>>>>> I personally like that, but due to that we
> are really often exceeding the
>>>>>> 120 character per line.
>>>>>>>
>>>>>>> Thus my question: should we extend this
> from 120 to 160 characters being
>>>>>> allowed per line?
>>>>>>>
>>>>>>> [+1] yup make 160 the max default
>>>>>>> [0] don't care
>>>>>>> [-1] nope, let's stick with 120
>>>>>>>
>>>>>>> open for 72h ...
>>>>>>>
>>>>>>>
>>>>>>> Please make use of your vote, because I
> will activate the checkstyle checks
>>>>>> soon ;)
>>>>>>>
>>>>>>> here is my +1.
>>>>>>>
>>>>>>> LieGrue,
>>>>>>> strub
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> inexso - information exchange solutions GmbH
>>>>>> Ofener Str. 30 | 26121 Oldenburg
>>>>>> Tel.: +49 441 219 730 56 |
>>>>>> FAX: +49 441 219 730 66 | eMail: volker.weber@inexso.de
>>>>>>
>>>>>> Firmensitz: Oldenburg | Amtsgericht Oldenburg
> HRB 205251
>>>>>> Geschäftsführer: Stefan Schulte, Michael
> Terschüren
>>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> inexso - information exchange solutions GmbH
>>>> Ofener Str. 30 | 26121 Oldenburg
>>>> Tel.: +49 441 219 730 56 |
>>>> FAX: +49 441 219 730 66 | eMail: volker.weber@inexso.de
>>>>
>>>> Firmensitz: Oldenburg | Amtsgericht Oldenburg HRB 205251
>>>> Geschäftsführer: Stefan Schulte, Michael Terschüren
>>>>
>>>
>>
>>
>>
Re: [VOTE] extend maximum allowed line length from 120 to 160
Posted by Mark Struberg <st...@yahoo.de>.
As I said earlier, the 160 char/line proposal was just made because I'm pretty tired of fixing the checkstyle issues in myfaces-core already.
If anyone is up for taking that piece of cake, then I'd be happy. Otherwise I will do it over the weekend.
LieGrue,
strub
>________________________________
>From: Blake Sullivan <bl...@oracle.com>
>To: MyFaces Development <de...@myfaces.apache.org>
>Cc: Gerhard Petracek <ge...@gmail.com>
>Sent: Friday, October 28, 2011 8:13 PM
>Subject: Re: [VOTE] extend maximum allowed line length from 120 to 160
>
>
>I personally find 120 characters to be the best balance. On the bright side, I expect that once we can use the diamond operator in JDK 7, the pressure for longer lines will decrease.
>
>-- Blake Sullivan
>
>On 10/28/11 10:33 AM, Gerhard Petracek wrote:
>@80: -1!
>>@rest: +0
>>
>>regards,
>>gerhard
>>
>>http://www.irian.at
>>
>>Your JSF powerhouse -
>>JSF Consulting, Development and
>>Courses in English and German
>>
>>Professional Support for Apache MyFaces
>>
>>
>>
>>
>>2011/10/28 Volker Weber <v....@inexso.de>
>>
>>Hi Mark,
>>>
>>>2011/10/28 Mark Struberg <st...@yahoo.de>:
>>>
>>>> Volker, source code is no newspaper.
>>>
>>>
just wanted to support the statement of easier reading in smaller
>>>columns, of cause code is no newspaper, but it still need
easy
>>>reading.
>>>
>>>I don't like to scroll left and right to read the code, and
even at
>>>work were i got the widest screen the 1920px did not suffice
to see
>>>more than 120 characters with the project and structure
sidebars left
>>>and right, which i would not like to miss.
>>>
>>>
>>>Regards,
>>> Volker
>>>
>>>
>>>
>>>>
>>>> Imo 80 chars is definitely fine for C or perl with
cryptic syntax (programmed that myself for 20 years) but
it's not nice for languages where descriptive variable
and method names are 'socially accepted' ;)
>>>>
>>>>
>>>> LieGrue,
>>>> strub
>>>>
>>>>
>>>>
>>>> ----- Original Message -----
>>>>> From: Volker Weber <v....@inexso.de>
>>>>> To: MyFaces Development <de...@myfaces.apache.org>; Mark Struberg <st...@yahoo.de>
>>>>> Cc:
>>>>> Sent: Friday, October 28, 2011 9:22 AM
>>>>> Subject: Re: [VOTE] extend maximum allowed line
length from 120 to 160
>>>>>
>>>>> Hi,
>>>>>
>>>>> -1.
>>>>>
>>>>> In my opinion 160 characters is much to wide,
the current 120 is not
>>>>> the preferred, but the allowed max width.
>>>>> I vote for 80 characters as preferred max
width.
>>>>>
>>>>> In general reading is easier if the text is not
too wide, thats why
>>>>> newspaper articles are layouted in columns.
>>>>>
>>>>>
>>>>> Regards,
>>>>> Volker
>>>>>
>>>>> 2011/10/26 Mark Struberg <st...@yahoo.de>:
>>>>>> Hi!
>>>>>>
>>>>>> Currently we have really long and very
descriptive variable names in
>>>>> MyFaces.
>>>>>>
>>>>>> I personally like that, but due to that we
are really often exceeding the
>>>>> 120 character per line.
>>>>>>
>>>>>> Thus my question: should we extend this
from 120 to 160 characters being
>>>>> allowed per line?
>>>>>>
>>>>>> [+1] yup make 160 the max default
>>>>>> [0] don't care
>>>>>> [-1] nope, let's stick with 120
>>>>>>
>>>>>> open for 72h ...
>>>>>>
>>>>>>
>>>>>> Please make use of your vote, because I
will activate the checkstyle checks
>>>>> soon ;)
>>>>>>
>>>>>> here is my +1.
>>>>>>
>>>>>> LieGrue,
>>>>>> strub
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> inexso - information exchange solutions GmbH
>>>>> Ofener Str. 30 | 26121 Oldenburg
>>>>> Tel.: +49 441 219 730 56 |
>>>>> FAX: +49 441 219 730 66 | eMail: volker.weber@inexso.de
>>>>>
>>>>> Firmensitz: Oldenburg | Amtsgericht Oldenburg
HRB 205251
>>>>> Geschäftsführer: Stefan Schulte, Michael
Terschüren
>>>>>
>>>>
>>>
>>>
>>>
>>>--
>>>inexso - information exchange solutions GmbH
>>>Ofener Str. 30 | 26121 Oldenburg
>>>Tel.: +49 441 219 730 56 |
>>>FAX: +49 441 219 730 66 | eMail: volker.weber@inexso.de
>>>
>>>Firmensitz: Oldenburg | Amtsgericht Oldenburg HRB 205251
>>>Geschäftsführer: Stefan Schulte, Michael Terschüren
>>>
>>
>
>
>
Re: [VOTE] extend maximum allowed line length from 120 to 160
Posted by Blake Sullivan <bl...@oracle.com>.
I personally find 120 characters to be the best balance. On the bright
side, I expect that once we can use the diamond operator in JDK 7, the
pressure for longer lines will decrease.
-- Blake Sullivan
On 10/28/11 10:33 AM, Gerhard Petracek wrote:
> @80: -1!
> @rest: +0
>
> regards,
> gerhard
>
> http://www.irian.at
>
> Your JSF powerhouse -
> JSF Consulting, Development and
> Courses in English and German
>
> Professional Support for Apache MyFaces
>
>
>
> 2011/10/28 Volker Weber <v.weber@inexso.de <ma...@inexso.de>>
>
> Hi Mark,
>
> 2011/10/28 Mark Struberg <struberg@yahoo.de
> <ma...@yahoo.de>>:
> > Volker, source code is no newspaper.
>
> just wanted to support the statement of easier reading in smaller
> columns, of cause code is no newspaper, but it still need easy
> reading.
>
> I don't like to scroll left and right to read the code, and even at
> work were i got the widest screen the 1920px did not suffice to see
> more than 120 characters with the project and structure sidebars left
> and right, which i would not like to miss.
>
>
> Regards,
> Volker
>
>
> >
> > Imo 80 chars is definitely fine for C or perl with cryptic
> syntax (programmed that myself for 20 years) but it's not nice for
> languages where descriptive variable and method names are
> 'socially accepted' ;)
> >
> >
> > LieGrue,
> > strub
> >
> >
> >
> > ----- Original Message -----
> >> From: Volker Weber <v.weber@inexso.de <ma...@inexso.de>>
> >> To: MyFaces Development <dev@myfaces.apache.org
> <ma...@myfaces.apache.org>>; Mark Struberg <struberg@yahoo.de
> <ma...@yahoo.de>>
> >> Cc:
> >> Sent: Friday, October 28, 2011 9:22 AM
> >> Subject: Re: [VOTE] extend maximum allowed line length from 120
> to 160
> >>
> >> Hi,
> >>
> >> -1.
> >>
> >> In my opinion 160 characters is much to wide, the current 120
> is not
> >> the preferred, but the allowed max width.
> >> I vote for 80 characters as preferred max width.
> >>
> >> In general reading is easier if the text is not too wide, thats why
> >> newspaper articles are layouted in columns.
> >>
> >>
> >> Regards,
> >> Volker
> >>
> >> 2011/10/26 Mark Struberg <struberg@yahoo.de
> <ma...@yahoo.de>>:
> >>> Hi!
> >>>
> >>> Currently we have really long and very descriptive variable
> names in
> >> MyFaces.
> >>>
> >>> I personally like that, but due to that we are really often
> exceeding the
> >> 120 character per line.
> >>>
> >>> Thus my question: should we extend this from 120 to 160
> characters being
> >> allowed per line?
> >>>
> >>> [+1] yup make 160 the max default
> >>> [0] don't care
> >>> [-1] nope, let's stick with 120
> >>>
> >>> open for 72h ...
> >>>
> >>>
> >>> Please make use of your vote, because I will activate the
> checkstyle checks
> >> soon ;)
> >>>
> >>> here is my +1.
> >>>
> >>> LieGrue,
> >>> strub
> >>>
> >>>
> >>
> >>
> >>
> >> --
> >> inexso - information exchange solutions GmbH
> >> Ofener Str. 30 | 26121 Oldenburg
> >> Tel.: +49 441 219 730 56 <tel:%2B49%20441%20219%20730%2056> |
> >> FAX: +49 441 219 730 66 <tel:%2B49%20441%20219%20730%2066> |
> eMail: volker.weber@inexso.de <ma...@inexso.de>
> >>
> >> Firmensitz: Oldenburg | Amtsgericht Oldenburg HRB 205251
> >> Geschäftsführer: Stefan Schulte, Michael Terschüren
> >>
> >
>
>
>
> --
> inexso - information exchange solutions GmbH
> Ofener Str. 30 | 26121 Oldenburg
> Tel.: +49 441 219 730 56 <tel:%2B49%20441%20219%20730%2056> |
> FAX: +49 441 219 730 66 <tel:%2B49%20441%20219%20730%2066> |
> eMail: volker.weber@inexso.de <ma...@inexso.de>
>
> Firmensitz: Oldenburg | Amtsgericht Oldenburg HRB 205251
> Geschäftsführer: Stefan Schulte, Michael Terschüren
>
>
Re: [VOTE] extend maximum allowed line length from 120 to 160
Posted by Gerhard Petracek <ge...@gmail.com>.
@80: -1!
@rest: +0
regards,
gerhard
http://www.irian.at
Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German
Professional Support for Apache MyFaces
2011/10/28 Volker Weber <v....@inexso.de>
> Hi Mark,
>
> 2011/10/28 Mark Struberg <st...@yahoo.de>:
> > Volker, source code is no newspaper.
>
> just wanted to support the statement of easier reading in smaller
> columns, of cause code is no newspaper, but it still need easy
> reading.
>
> I don't like to scroll left and right to read the code, and even at
> work were i got the widest screen the 1920px did not suffice to see
> more than 120 characters with the project and structure sidebars left
> and right, which i would not like to miss.
>
>
> Regards,
> Volker
>
>
> >
> > Imo 80 chars is definitely fine for C or perl with cryptic syntax
> (programmed that myself for 20 years) but it's not nice for languages where
> descriptive variable and method names are 'socially accepted' ;)
> >
> >
> > LieGrue,
> > strub
> >
> >
> >
> > ----- Original Message -----
> >> From: Volker Weber <v....@inexso.de>
> >> To: MyFaces Development <de...@myfaces.apache.org>; Mark Struberg <
> struberg@yahoo.de>
> >> Cc:
> >> Sent: Friday, October 28, 2011 9:22 AM
> >> Subject: Re: [VOTE] extend maximum allowed line length from 120 to 160
> >>
> >> Hi,
> >>
> >> -1.
> >>
> >> In my opinion 160 characters is much to wide, the current 120 is not
> >> the preferred, but the allowed max width.
> >> I vote for 80 characters as preferred max width.
> >>
> >> In general reading is easier if the text is not too wide, thats why
> >> newspaper articles are layouted in columns.
> >>
> >>
> >> Regards,
> >> Volker
> >>
> >> 2011/10/26 Mark Struberg <st...@yahoo.de>:
> >>> Hi!
> >>>
> >>> Currently we have really long and very descriptive variable names in
> >> MyFaces.
> >>>
> >>> I personally like that, but due to that we are really often exceeding
> the
> >> 120 character per line.
> >>>
> >>> Thus my question: should we extend this from 120 to 160 characters
> being
> >> allowed per line?
> >>>
> >>> [+1] yup make 160 the max default
> >>> [0] don't care
> >>> [-1] nope, let's stick with 120
> >>>
> >>> open for 72h ...
> >>>
> >>>
> >>> Please make use of your vote, because I will activate the checkstyle
> checks
> >> soon ;)
> >>>
> >>> here is my +1.
> >>>
> >>> LieGrue,
> >>> strub
> >>>
> >>>
> >>
> >>
> >>
> >> --
> >> inexso - information exchange solutions GmbH
> >> Ofener Str. 30 | 26121 Oldenburg
> >> Tel.: +49 441 219 730 56 |
> >> FAX: +49 441 219 730 66 | eMail: volker.weber@inexso.de
> >>
> >> Firmensitz: Oldenburg | Amtsgericht Oldenburg HRB 205251
> >> Geschäftsführer: Stefan Schulte, Michael Terschüren
> >>
> >
>
>
>
> --
> inexso - information exchange solutions GmbH
> Ofener Str. 30 | 26121 Oldenburg
> Tel.: +49 441 219 730 56 |
> FAX: +49 441 219 730 66 | eMail: volker.weber@inexso.de
>
> Firmensitz: Oldenburg | Amtsgericht Oldenburg HRB 205251
> Geschäftsführer: Stefan Schulte, Michael Terschüren
>
Re: [VOTE] extend maximum allowed line length from 120 to 160
Posted by Volker Weber <v....@inexso.de>.
Hi Mark,
2011/10/28 Mark Struberg <st...@yahoo.de>:
> Volker, source code is no newspaper.
just wanted to support the statement of easier reading in smaller
columns, of cause code is no newspaper, but it still need easy
reading.
I don't like to scroll left and right to read the code, and even at
work were i got the widest screen the 1920px did not suffice to see
more than 120 characters with the project and structure sidebars left
and right, which i would not like to miss.
Regards,
Volker
>
> Imo 80 chars is definitely fine for C or perl with cryptic syntax (programmed that myself for 20 years) but it's not nice for languages where descriptive variable and method names are 'socially accepted' ;)
>
>
> LieGrue,
> strub
>
>
>
> ----- Original Message -----
>> From: Volker Weber <v....@inexso.de>
>> To: MyFaces Development <de...@myfaces.apache.org>; Mark Struberg <st...@yahoo.de>
>> Cc:
>> Sent: Friday, October 28, 2011 9:22 AM
>> Subject: Re: [VOTE] extend maximum allowed line length from 120 to 160
>>
>> Hi,
>>
>> -1.
>>
>> In my opinion 160 characters is much to wide, the current 120 is not
>> the preferred, but the allowed max width.
>> I vote for 80 characters as preferred max width.
>>
>> In general reading is easier if the text is not too wide, thats why
>> newspaper articles are layouted in columns.
>>
>>
>> Regards,
>> Volker
>>
>> 2011/10/26 Mark Struberg <st...@yahoo.de>:
>>> Hi!
>>>
>>> Currently we have really long and very descriptive variable names in
>> MyFaces.
>>>
>>> I personally like that, but due to that we are really often exceeding the
>> 120 character per line.
>>>
>>> Thus my question: should we extend this from 120 to 160 characters being
>> allowed per line?
>>>
>>> [+1] yup make 160 the max default
>>> [0] don't care
>>> [-1] nope, let's stick with 120
>>>
>>> open for 72h ...
>>>
>>>
>>> Please make use of your vote, because I will activate the checkstyle checks
>> soon ;)
>>>
>>> here is my +1.
>>>
>>> LieGrue,
>>> strub
>>>
>>>
>>
>>
>>
>> --
>> inexso - information exchange solutions GmbH
>> Ofener Str. 30 | 26121 Oldenburg
>> Tel.: +49 441 219 730 56 |
>> FAX: +49 441 219 730 66 | eMail: volker.weber@inexso.de
>>
>> Firmensitz: Oldenburg | Amtsgericht Oldenburg HRB 205251
>> Geschäftsführer: Stefan Schulte, Michael Terschüren
>>
>
--
inexso - information exchange solutions GmbH
Ofener Str. 30 | 26121 Oldenburg
Tel.: +49 441 219 730 56 |
FAX: +49 441 219 730 66 | eMail: volker.weber@inexso.de
Firmensitz: Oldenburg | Amtsgericht Oldenburg HRB 205251
Geschäftsführer: Stefan Schulte, Michael Terschüren
Re: [VOTE] extend maximum allowed line length from 120 to 160
Posted by Mark Struberg <st...@yahoo.de>.
Volker, source code is no newspaper.
Imo 80 chars is definitely fine for C or perl with cryptic syntax (programmed that myself for 20 years) but it's not nice for languages where descriptive variable and method names are 'socially accepted' ;)
LieGrue,
strub
----- Original Message -----
> From: Volker Weber <v....@inexso.de>
> To: MyFaces Development <de...@myfaces.apache.org>; Mark Struberg <st...@yahoo.de>
> Cc:
> Sent: Friday, October 28, 2011 9:22 AM
> Subject: Re: [VOTE] extend maximum allowed line length from 120 to 160
>
> Hi,
>
> -1.
>
> In my opinion 160 characters is much to wide, the current 120 is not
> the preferred, but the allowed max width.
> I vote for 80 characters as preferred max width.
>
> In general reading is easier if the text is not too wide, thats why
> newspaper articles are layouted in columns.
>
>
> Regards,
> Volker
>
> 2011/10/26 Mark Struberg <st...@yahoo.de>:
>> Hi!
>>
>> Currently we have really long and very descriptive variable names in
> MyFaces.
>>
>> I personally like that, but due to that we are really often exceeding the
> 120 character per line.
>>
>> Thus my question: should we extend this from 120 to 160 characters being
> allowed per line?
>>
>> [+1] yup make 160 the max default
>> [0] don't care
>> [-1] nope, let's stick with 120
>>
>> open for 72h ...
>>
>>
>> Please make use of your vote, because I will activate the checkstyle checks
> soon ;)
>>
>> here is my +1.
>>
>> LieGrue,
>> strub
>>
>>
>
>
>
> --
> inexso - information exchange solutions GmbH
> Ofener Str. 30 | 26121 Oldenburg
> Tel.: +49 441 219 730 56 |
> FAX: +49 441 219 730 66 | eMail: volker.weber@inexso.de
>
> Firmensitz: Oldenburg | Amtsgericht Oldenburg HRB 205251
> Geschäftsführer: Stefan Schulte, Michael Terschüren
>
Re: [VOTE] extend maximum allowed line length from 120 to 160
Posted by Werner Punz <we...@gmail.com>.
+1 for 160
0 for 120
-1 for 80, 80 with modern monitors
is way to few, the problem stems from the 80s
where 80 characters was the terminal norm.
Werner
Am 10/28/11 9:22 AM, schrieb Volker Weber:
> Hi,
>
> -1.
>
> In my opinion 160 characters is much to wide, the current 120 is not
> the preferred, but the allowed max width.
> I vote for 80 characters as preferred max width.
>
> In general reading is easier if the text is not too wide, thats why
> newspaper articles are layouted in columns.
>
>
> Regards,
> Volker
>
> 2011/10/26 Mark Struberg<st...@yahoo.de>:
>> Hi!
>>
>> Currently we have really long and very descriptive variable names in MyFaces.
>>
>> I personally like that, but due to that we are really often exceeding the 120 character per line.
>>
>> Thus my question: should we extend this from 120 to 160 characters being allowed per line?
>>
>> [+1] yup make 160 the max default
>> [0] don't care
>> [-1] nope, let's stick with 120
>>
>> open for 72h ...
>>
>>
>> Please make use of your vote, because I will activate the checkstyle checks soon ;)
>>
>> here is my +1.
>>
>> LieGrue,
>> strub
>>
>>
>
>
>
Re: [VOTE] extend maximum allowed line length from 120 to 160
Posted by Volker Weber <v....@inexso.de>.
Hi,
-1.
In my opinion 160 characters is much to wide, the current 120 is not
the preferred, but the allowed max width.
I vote for 80 characters as preferred max width.
In general reading is easier if the text is not too wide, thats why
newspaper articles are layouted in columns.
Regards,
Volker
2011/10/26 Mark Struberg <st...@yahoo.de>:
> Hi!
>
> Currently we have really long and very descriptive variable names in MyFaces.
>
> I personally like that, but due to that we are really often exceeding the 120 character per line.
>
> Thus my question: should we extend this from 120 to 160 characters being allowed per line?
>
> [+1] yup make 160 the max default
> [0] don't care
> [-1] nope, let's stick with 120
>
> open for 72h ...
>
>
> Please make use of your vote, because I will activate the checkstyle checks soon ;)
>
> here is my +1.
>
> LieGrue,
> strub
>
>
--
inexso - information exchange solutions GmbH
Ofener Str. 30 | 26121 Oldenburg
Tel.: +49 441 219 730 56 |
FAX: +49 441 219 730 66 | eMail: volker.weber@inexso.de
Firmensitz: Oldenburg | Amtsgericht Oldenburg HRB 205251
Geschäftsführer: Stefan Schulte, Michael Terschüren