You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Henry Robinson (Code Review)" <ge...@cloudera.org> on 2016/06/03 20:59:30 UTC

[Toolchain-CR] IMPALA-3655: Add Thrift 0.9.3 to toolchain

Henry Robinson has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3306

Change subject: IMPALA-3655: Add Thrift 0.9.3 to toolchain
......................................................................

IMPALA-3655: Add Thrift 0.9.3 to toolchain

Change-Id: I9a53afa0c16ecee24e142f181ce47702fd9fa9af
---
M buildall.sh
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Toolchain refs/changes/06/3306/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9a53afa0c16ecee24e142f181ce47702fd9fa9af
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>

[Toolchain-CR] IMPALA-3655: Add Thrift 0.9.3 to toolchain

Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.

Change subject: IMPALA-3655: Add Thrift 0.9.3 to toolchain
......................................................................


Patch Set 1:

Mostly bugfixes, but none that are necessarily biting us right now. One interesting improvement is that 0.9.3 has move constructors, which might help a bit in moving bit structs around from RPCs.

-- 
To view, visit http://gerrit.cloudera.org:8080/3306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a53afa0c16ecee24e142f181ce47702fd9fa9af
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No

[Toolchain-CR] IMPALA-3655: Add Thrift 0.9.3 to toolchain

Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3655: Add Thrift 0.9.3 to toolchain
......................................................................


Patch Set 1: Code-Review+2

Just curious, what fixes/improvements in particular are we interested in (beyond those we've already backported)?

-- 
To view, visit http://gerrit.cloudera.org:8080/3306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a53afa0c16ecee24e142f181ce47702fd9fa9af
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No

[Toolchain-CR] IMPALA-3655: Add Thrift 0.9.3 to toolchain

Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.

Change subject: IMPALA-3655: Add Thrift 0.9.3 to toolchain
......................................................................


Patch Set 1:

Toolchain non-publishing build: http://unittest.jenkins.cloudera.com/job/verify-impala-toolchain-package-build/207/

-- 
To view, visit http://gerrit.cloudera.org:8080/3306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a53afa0c16ecee24e142f181ce47702fd9fa9af
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No

[Toolchain-CR] IMPALA-3655: Add Thrift 0.9.3 to toolchain

Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has abandoned this change.

Change subject: IMPALA-3655: Add Thrift 0.9.3 to toolchain
......................................................................


Abandoned

Still waiting on infra changes to make this possible. Will resume in the ASF project.

-- 
To view, visit http://gerrit.cloudera.org:8080/3306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I9a53afa0c16ecee24e142f181ce47702fd9fa9af
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>