You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2020/04/30 09:45:55 UTC
[GitHub] [sling-org-apache-sling-distribution-core] harshchiki opened a new pull request #41: SLING-9389: Distribution Event Packages should contain queue item creation time
harshchiki opened a new pull request #41:
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/41
- Improvement aims at adding the queue item creation time, essentially when the the item was creation for the first time, and enqueue into the queue.
- The purpose to get this detail is to be able to capture metrics at the consumer level. The consumers could have an event handler, which can capture the duration which turns out to be (NOW MINUS queue item creation time thrown in the distribution event package); NOW being the current time in the event handler (consumer).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-core] harshchiki edited a comment on pull request #41: SLING-9389: Distribution Event Packages should contain queue item creation time
Posted by GitBox <gi...@apache.org>.
harshchiki edited a comment on pull request #41:
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/41#issuecomment-634441515
This PR is failing on the missing `DistributionEventProperties.DISTRIBUTION_ENQUEUE_TIMESTAMP`(compilation error), which is proposed in https://github.com/apache/sling-org-apache-sling-distribution-api/pull/7 - IIUC, once that is merged, this should pass fine.
Request the owners of the repo to kindly review.
cc: @tmaret @cschneider
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-core] harshchiki commented on pull request #41: SLING-9389: Distribution Event Packages should contain queue item creation time
Posted by GitBox <gi...@apache.org>.
harshchiki commented on pull request #41:
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/41#issuecomment-621729421
SCD API PR - https://github.com/apache/sling-org-apache-sling-distribution-api/pull/2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-core] harshchiki commented on pull request #41: SLING-9389: Distribution Event Packages should contain queue item creation time
Posted by GitBox <gi...@apache.org>.
harshchiki commented on pull request #41:
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/41#issuecomment-634441515
This PR is failing on the missing `DistributionEventProperties.DISTRIBUTION_ENQUEUE_TIMESTAMP`, which is proposed in https://github.com/apache/sling-org-apache-sling-distribution-api/pull/7
Request the owners of the repo to kindly review.
cc: @tmaret @cschneider
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org