[GitHub] [arrow] indigophox commented on a diff in pull request #34817: GH-34865: [C++][Flight RPC] Add Session management messages, Location URI path accessors

["indigophox (via GitHub)" <gi...@apache.org>]

indigophox commented on code in PR #34817:
URL: https://github.com/apache/arrow/pull/34817#discussion_r1240460451


##########
cpp/src/arrow/flight/types.h:
##########
@@ -409,6 +409,15 @@ struct ARROW_FLIGHT_EXPORT Location {
   /// \brief Get the scheme of this URI.
   std::string scheme() const;
 
+  /// \brief Get the path of this URI.
+  std::string path() const;
+
+  /// \brief Get the query parameters of this URI.
+  arrow::Result<std::vector<std::pair<std::string, std::string>>> QueryItems() const;
+
+  /// \brief Convert URI path and parameters to headers.
+  arrow::Result<std::vector<std::pair<std::string, std::string>>> AsHeaders() const;

Review Comment:
   NB we're probably dropping this due to various ways it ends up being inconsistent across e.g. Flight-based JDBC/ODBC drivers that already expose a catalog selection mechanism (and we don't need more duplicitious ways of doing X), as well as the fact that it doesn't get natively handled by the Flight SQL client but instead would have to percolate back out to the client app to be passed back in via SetSessionOptions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org