[GitHub] [cordova-android] breautek commented on a change in pull request #764: App bundle

[GitBox <gi...@apache.org>]

breautek commented on a change in pull request #764: App bundle
URL: https://github.com/apache/cordova-android/pull/764#discussion_r302574568
 
 

 ##########
 File path: bin/templates/cordova/lib/build.js
 ##########
 @@ -148,10 +150,17 @@ module.exports.run = function (options, optResolvedTarget) {
             return;
         }
         return builder.build(opts).then(function () {
-            var apkPaths = builder.findOutputApks(opts.buildType, opts.arch);
-            events.emit('log', 'Built the following apk(s): \n\t' + apkPaths.join('\n\t'));
+            var paths;
+            if (opts.isBundle) {
+                paths = builder.findOutputBundles(opts.buildType);
+                events.emit('log', 'Built the following bundle(s): \n\t' + paths.join('\n\t'));
+            } else {
+                paths = builder.findOutputApks(opts.buildType, opts.arch);
+                events.emit('log', 'Built the following apk(s): \n\t' + paths.join('\n\t'));
+            }
+
             return {
-                apkPaths: apkPaths,
+                paths: paths,
 
 Review comment:
   I could revert `paths` back to `apkPaths` but the naming will be kind of misleading as it might not have APKs paths, but instead AAB paths now.
   
   But I do agree it is a dangerous change. Perhaps I should just add a comment instead?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org