You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/09 13:59:11 UTC

[GitHub] [beam] Abacn commented on a diff in pull request #22930: GSoC-2022 latest_capability_matrix based on ValidatesRunner tests beam-2888

Abacn commented on code in PR #22930:
URL: https://github.com/apache/beam/pull/22930#discussion_r967096957


##########
.gitignore:
##########
@@ -115,6 +115,7 @@ website/www/yarn-error.log
 
 # Node
 sdks/typescript/node_modules
+node_modules

Review Comment:
   ```suggestion
   node_modules/**
   ```



##########
.gitignore:
##########
@@ -115,6 +115,7 @@ website/www/yarn-error.log
 
 # Node
 sdks/typescript/node_modules
+node_modules

Review Comment:
   Add this then run `git rm --cached -r node_modules` and commit the change. This will remove node_modules files from the branch.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org