[GitHub] [cloudstack] ustcweizhou opened a new pull request #3688: New feature: Add support to destroy/recover volumes

[GitBox <gi...@apache.org>]

ustcweizhou opened a new pull request #3688: New feature: Add support to destroy/recover volumes
URL: https://github.com/apache/cloudstack/pull/3688
 
 
   ## Description
   <!--- Describe your changes in detail -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   cloudstack provides options to destroy and recover a vm. For volumes, we do not have similar operations. When we delete a volume, it will be removed from primary storage permanently.
   
   With this change, 
   (1) we have option to destroy a volume (expunge=false) or delete a volume permanently (expunge=true)
   (2) we are be able to recover a Destroy volume to Ready state.
   (3) Destroy volume will be removed in storage clean up.
   (4) when reinstall a vm, the old root volume will be Destroy state. It can be recovered to Ready state and attached to other vm so we can restore some data.
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [X] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   destroy vm (expunge=false)
   recover a Destroy vm
   delete vm (same as destroy vm with expunge=True)
   
   More test cases can be found in the integration tests.
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services