You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/05/05 20:22:21 UTC

[GitHub] [commons-collections] codecov-commenter commented on pull request #307: When possible use java.lang.Objects#equals; eliminated a couple of nulls

codecov-commenter commented on PR #307:
URL: https://github.com/apache/commons-collections/pull/307#issuecomment-1119011207

   # [Codecov](https://codecov.io/gh/apache/commons-collections/pull/307?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#307](https://codecov.io/gh/apache/commons-collections/pull/307?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (51eb7f7) into [master](https://codecov.io/gh/apache/commons-collections/commit/1677daceab74895fdf5056c9a48aa94f9e709fb9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1677dac) will **increase** coverage by `0.08%`.
   > The diff coverage is `66.66%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #307      +/-   ##
   ============================================
   + Coverage     85.87%   85.95%   +0.08%     
   + Complexity     4676     4670       -6     
   ============================================
     Files           292      292              
     Lines         13469    13467       -2     
     Branches       1955     1954       -1     
   ============================================
   + Hits          11566    11576      +10     
   + Misses         1326     1325       -1     
   + Partials        577      566      -11     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/commons-collections/pull/307?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...mons/collections4/comparators/ComparatorChain.java](https://codecov.io/gh/apache/commons-collections/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L2NvbXBhcmF0b3JzL0NvbXBhcmF0b3JDaGFpbi5qYXZh) | `65.33% <0.00%> (ø)` | |
   | [...ommons/collections4/multiset/AbstractMultiSet.java](https://codecov.io/gh/apache/commons-collections/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L211bHRpc2V0L0Fic3RyYWN0TXVsdGlTZXQuamF2YQ==) | `43.47% <0.00%> (+0.31%)` | :arrow_up: |
   | [.../org/apache/commons/collections4/map/Flat3Map.java](https://codecov.io/gh/apache/commons-collections/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L21hcC9GbGF0M01hcC5qYXZh) | `72.76% <33.33%> (+0.19%)` | :arrow_up: |
   | [...llections4/comparators/TransformingComparator.java](https://codecov.io/gh/apache/commons-collections/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L2NvbXBhcmF0b3JzL1RyYW5zZm9ybWluZ0NvbXBhcmF0b3IuamF2YQ==) | `86.36% <50.00%> (+4.54%)` | :arrow_up: |
   | [...g/apache/commons/collections4/CollectionUtils.java](https://codecov.io/gh/apache/commons-collections/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L0NvbGxlY3Rpb25VdGlscy5qYXZh) | `94.34% <100.00%> (+0.21%)` | :arrow_up: |
   | [...ava/org/apache/commons/collections4/ListUtils.java](https://codecov.io/gh/apache/commons-collections/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L0xpc3RVdGlscy5qYXZh) | `87.30% <100.00%> (+0.68%)` | :arrow_up: |
   | [.../commons/collections4/functors/DefaultEquator.java](https://codecov.io/gh/apache/commons-collections/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L2Z1bmN0b3JzL0RlZmF1bHRFcXVhdG9yLmphdmE=) | `60.00% <100.00%> (+20.00%)` | :arrow_up: |
   | [...ache/commons/collections4/map/StaticBucketMap.java](https://codecov.io/gh/apache/commons-collections/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L21hcC9TdGF0aWNCdWNrZXRNYXAuamF2YQ==) | `93.66% <100.00%> (+2.71%)` | :arrow_up: |
   | [...commons/collections4/trie/AbstractBitwiseTrie.java](https://codecov.io/gh/apache/commons-collections/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L3RyaWUvQWJzdHJhY3RCaXR3aXNlVHJpZS5qYXZh) | `76.92% <100.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/commons-collections/pull/307?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/commons-collections/pull/307?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1677dac...51eb7f7](https://codecov.io/gh/apache/commons-collections/pull/307?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org