[jira] [Commented] (PHOENIX-5804) Implement strong verification with -v ONLY option for old design of secondary indexes

["Hadoop QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117333#comment-17117333 ] 

Hadoop QA commented on PHOENIX-5804:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/13004076/PHOENIX-5804.v1.patch
  against master branch at commit 5a9ec5552fb63fdf640e0c9adbb81eb6eec0ccae.
  ATTACHMENT ID: 13004076

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 9 new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +        serverProps.put(QueryServices.MAX_SERVER_METADATA_CACHE_TIME_TO_LIVE_MS_ATTRIB, Long.toString(5));
+        // This tests the cases where a column having a null value is overwritten with a not null value and vice versa;
+                    "CREATE INDEX %s ON %s (VAL1) INCLUDE (VAL2) ASYNC ", indexTableName, dataTableFullName));
+                    indexTool = IndexToolIT.runIndexTool(directApi, useSnapshot, schemaName, dataTableName, indexTableName, null, 0, new String[0]);
+            assertEquals(NROWS, indexTool.getJob().getCounters().findCounter(INPUT_RECORDS).getValue());
+            actualRowCount = IndexScrutiny.scrutinizeIndex(conn, dataTableFullName, indexTableFullName);
+            actualRowCount = IndexScrutiny.scrutinizeIndex(conn, dataTableFullName, indexTableFullName);
+            actualRowCount = IndexScrutiny.scrutinizeIndex(conn, dataTableFullName, indexTableFullName);
+            actualRowCount = IndexScrutiny.scrutinizeIndex(conn, dataTableFullName, indexTableFullName);
+            indexTool = IndexToolIT.runIndexTool(directApi, useSnapshot, schemaName, dataTableName, indexTableName, null,

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexToolForNonTxGlobalIndexIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3894//testReport/
Code Coverage results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3894//artifact/phoenix-core/target/site/jacoco/index.html
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3894//console

This message is automatically generated.

> Implement strong verification with -v ONLY option for old design of secondary indexes
> -------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-5804
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5804
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Swaroopa Kadam
>            Assignee: Swaroopa Kadam
>            Priority: Major
>         Attachments: PHOENIX-5804.4.x.v1.patch, PHOENIX-5804.4.x.v2.patch, PHOENIX-5804.4.x.v3.patch, PHOENIX-5804.4.x.v4.patch, PHOENIX-5804.4.x.v5.patch, PHOENIX-5804.v1.patch
>
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> Currently, with -v ONLY option we get weak verification i.e. we find out if index row is present or not. It does not provide information on if the values have mismatch when executed with old design.
> We attempt to provide scrutiny like implementation but way faster. The verification will be done only one the latest version of the row.  
> This will help us in quantifying the success of new self-consistent secondary indexes design. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)