You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by sr...@apache.org on 2019/02/19 09:18:07 UTC
[flink] branch master updated: [hotfix] Fix some typos in
documentation and java-doc
This is an automated email from the ASF dual-hosted git repository.
srichter pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
The following commit(s) were added to refs/heads/master by this push:
new c93eff6 [hotfix] Fix some typos in documentation and java-doc
c93eff6 is described below
commit c93eff6de0bee4804f57f2ee4d7431f4ba0a4963
Author: leesf <49...@qq.com>
AuthorDate: Tue Feb 19 17:17:55 2019 +0800
[hotfix] Fix some typos in documentation and java-doc
This closes #7748.
---
docs/dev/connectors/kafka.md | 6 +-
.../connectors/kafka/FlinkKafkaProducer011.java | 2 +-
.../connectors/kafka/FlinkKafkaProducer.java | 2 +-
.../kinesis/model/StreamShardHandle.java | 2 +-
.../testutils/FakeKinesisBehavioursFactory.java | 2 +-
.../apache/flink/core/memory/MemorySegment.java | 76 +++++++++++-----------
.../operators/hash/InPlaceMutableHashTable.java | 2 +-
7 files changed, 46 insertions(+), 46 deletions(-)
diff --git a/docs/dev/connectors/kafka.md b/docs/dev/connectors/kafka.md
index 4be3882..a402915 100644
--- a/docs/dev/connectors/kafka.md
+++ b/docs/dev/connectors/kafka.md
@@ -681,13 +681,13 @@ chosen by passing appropriate `semantic` parameter to the `FlinkKafkaProducer011
`Semantic.EXACTLY_ONCE` mode relies on the ability to commit transactions
that were started before taking a checkpoint, after recovering from the said checkpoint. If the time
-between Flink application crash and completed restart is larger then Kafka's transaction timeout
+between Flink application crash and completed restart is larger than Kafka's transaction timeout
there will be data loss (Kafka will automatically abort transactions that exceeded timeout time).
Having this in mind, please configure your transaction timeout appropriately to your expected down
times.
Kafka brokers by default have `transaction.max.timeout.ms` set to 15 minutes. This property will
-not allow to set transaction timeouts for the producers larger then it's value.
+not allow to set transaction timeouts for the producers larger than it's value.
`FlinkKafkaProducer011` by default sets the `transaction.timeout.ms` property in producer config to
1 hour, thus `transaction.max.timeout.ms` should be increased before using the
`Semantic.EXACTLY_ONCE` mode.
@@ -720,7 +720,7 @@ number of concurrent checkpoints accordingly.
that would block the consumers from reading from Kafka topic more then it is necessary. However in the
event of failure of Flink application before first checkpoint, after restarting such application there
is no information in the system about previous pool sizes. Thus it is unsafe to scale down Flink
-application before first checkpoint completes, by factor larger then `FlinkKafkaProducer011.SAFE_SCALE_DOWN_FACTOR`.
+application before first checkpoint completes, by factor larger than `FlinkKafkaProducer011.SAFE_SCALE_DOWN_FACTOR`.
## Using Kafka timestamps and Flink event time in Kafka 0.10
diff --git a/flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java b/flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java
index 129ed66..de2f01d 100644
--- a/flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java
+++ b/flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java
@@ -152,7 +152,7 @@ public class FlinkKafkaProducer011<IN>
* <p>The range of available to use transactional ids is:
* {@code [0, getNumberOfParallelSubtasks() * kafkaProducersPoolSize) }
*
- * <p>This means that if we decrease {@code getNumberOfParallelSubtasks()} by a factor larger then
+ * <p>This means that if we decrease {@code getNumberOfParallelSubtasks()} by a factor larger than
* {@code SAFE_SCALE_DOWN_FACTOR} we can have a left some lingering transaction.
*/
public static final int SAFE_SCALE_DOWN_FACTOR = 5;
diff --git a/flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer.java b/flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer.java
index 15b5b9f..6a1e1c3 100644
--- a/flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer.java
+++ b/flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer.java
@@ -154,7 +154,7 @@ public class FlinkKafkaProducer<IN>
* <p>The range of available to use transactional ids is:
* {@code [0, getNumberOfParallelSubtasks() * kafkaProducersPoolSize) }
*
- * <p>This means that if we decrease {@code getNumberOfParallelSubtasks()} by a factor larger then
+ * <p>This means that if we decrease {@code getNumberOfParallelSubtasks()} by a factor larger than
* {@code SAFE_SCALE_DOWN_FACTOR} we can have a left some lingering transaction.
*/
public static final int SAFE_SCALE_DOWN_FACTOR = 5;
diff --git a/flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/StreamShardHandle.java b/flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/StreamShardHandle.java
index ca8bc51..9c237b5 100644
--- a/flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/StreamShardHandle.java
+++ b/flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/StreamShardHandle.java
@@ -101,7 +101,7 @@ public class StreamShardHandle {
* @param firstShardId first shard id to compare
* @param secondShardId second shard id to compare
* @return a value less than 0 if the first shard id is smaller than the second shard id,
- * or a value larger than 0 the first shard is larger then the second shard id,
+ * or a value larger than 0 the first shard is larger than the second shard id,
* or 0 if they are equal
*/
public static int compareShardIds(String firstShardId, String secondShardId) {
diff --git a/flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/testutils/FakeKinesisBehavioursFactory.java b/flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/testutils/FakeKinesisBehavioursFactory.java
index 15a9243..20373ff 100644
--- a/flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/testutils/FakeKinesisBehavioursFactory.java
+++ b/flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/testutils/FakeKinesisBehavioursFactory.java
@@ -402,7 +402,7 @@ public class FakeKinesisBehavioursFactory {
* @param firstShardId first shard id to compare
* @param secondShardId second shard id to compare
* @return a value less than 0 if the first shard id is smaller than the second shard id,
- * or a value larger than 0 the first shard is larger then the second shard id,
+ * or a value larger than 0 the first shard is larger than the second shard id,
* or 0 if they are equal
*/
private static int compareShardIds(String firstShardId, String secondShardId) {
diff --git a/flink-core/src/main/java/org/apache/flink/core/memory/MemorySegment.java b/flink-core/src/main/java/org/apache/flink/core/memory/MemorySegment.java
index d4b92bc7..b95ceb9 100644
--- a/flink-core/src/main/java/org/apache/flink/core/memory/MemorySegment.java
+++ b/flink-core/src/main/java/org/apache/flink/core/memory/MemorySegment.java
@@ -392,7 +392,7 @@ public abstract class MemorySegment {
* @param index The position from which the memory will be read.
* @return The boolean value at the given position.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment
* size minus 1.
*/
public abstract boolean getBoolean(int index);
@@ -404,7 +404,7 @@ public abstract class MemorySegment {
* @param index The position at which the memory will be written.
* @param value The char value to be written.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment
* size minus 1.
*/
public abstract void putBoolean(int index, boolean value);
@@ -415,7 +415,7 @@ public abstract class MemorySegment {
* @param index The position from which the memory will be read.
* @return The char value at the given position.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment
* size minus 2.
*/
@SuppressWarnings("restriction")
@@ -444,7 +444,7 @@ public abstract class MemorySegment {
* @param index The position from which the value will be read.
* @return The character value at the given position.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment size minus 2.
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment size minus 2.
*/
public final char getCharLittleEndian(int index) {
if (LITTLE_ENDIAN) {
@@ -465,7 +465,7 @@ public abstract class MemorySegment {
* @param index The position from which the value will be read.
* @return The character value at the given position.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment size minus 2.
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment size minus 2.
*/
public final char getCharBigEndian(int index) {
if (LITTLE_ENDIAN) {
@@ -481,7 +481,7 @@ public abstract class MemorySegment {
* @param index The position at which the memory will be written.
* @param value The char value to be written.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment
* size minus 2.
*/
@SuppressWarnings("restriction")
@@ -510,7 +510,7 @@ public abstract class MemorySegment {
* @param index The position at which the value will be written.
* @param value The char value to be written.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment size minus 2.
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment size minus 2.
*/
public final void putCharLittleEndian(int index, char value) {
if (LITTLE_ENDIAN) {
@@ -531,7 +531,7 @@ public abstract class MemorySegment {
* @param index The position at which the value will be written.
* @param value The char value to be written.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment size minus 2.
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment size minus 2.
*/
public final void putCharBigEndian(int index, char value) {
if (LITTLE_ENDIAN) {
@@ -548,7 +548,7 @@ public abstract class MemorySegment {
* @param index The position from which the memory will be read.
* @return The short value at the given position.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment
* size minus 2.
*/
public final short getShort(int index) {
@@ -576,7 +576,7 @@ public abstract class MemorySegment {
* @param index The position from which the value will be read.
* @return The short value at the given position.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment size minus 2.
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment size minus 2.
*/
public final short getShortLittleEndian(int index) {
if (LITTLE_ENDIAN) {
@@ -597,7 +597,7 @@ public abstract class MemorySegment {
* @param index The position from which the value will be read.
* @return The short value at the given position.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment size minus 2.
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment size minus 2.
*/
public final short getShortBigEndian(int index) {
if (LITTLE_ENDIAN) {
@@ -614,7 +614,7 @@ public abstract class MemorySegment {
* @param index The position at which the value will be written.
* @param value The short value to be written.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment
* size minus 2.
*/
public final void putShort(int index, short value) {
@@ -642,7 +642,7 @@ public abstract class MemorySegment {
* @param index The position at which the value will be written.
* @param value The short value to be written.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment size minus 2.
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment size minus 2.
*/
public final void putShortLittleEndian(int index, short value) {
if (LITTLE_ENDIAN) {
@@ -663,7 +663,7 @@ public abstract class MemorySegment {
* @param index The position at which the value will be written.
* @param value The short value to be written.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment size minus 2.
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment size minus 2.
*/
public final void putShortBigEndian(int index, short value) {
if (LITTLE_ENDIAN) {
@@ -684,7 +684,7 @@ public abstract class MemorySegment {
* @param index The position from which the value will be read.
* @return The int value at the given position.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment
* size minus 4.
*/
public final int getInt(int index) {
@@ -712,7 +712,7 @@ public abstract class MemorySegment {
* @param index The position from which the value will be read.
* @return The int value at the given position.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment
* size minus 4.
*/
public final int getIntLittleEndian(int index) {
@@ -734,7 +734,7 @@ public abstract class MemorySegment {
* @param index The position from which the value will be read.
* @return The int value at the given position.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment
* size minus 4.
*/
public final int getIntBigEndian(int index) {
@@ -756,7 +756,7 @@ public abstract class MemorySegment {
* @param index The position at which the value will be written.
* @param value The int value to be written.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment
* size minus 4.
*/
public final void putInt(int index, int value) {
@@ -784,7 +784,7 @@ public abstract class MemorySegment {
* @param index The position at which the value will be written.
* @param value The int value to be written.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment
* size minus 4.
*/
public final void putIntLittleEndian(int index, int value) {
@@ -806,7 +806,7 @@ public abstract class MemorySegment {
* @param index The position at which the value will be written.
* @param value The int value to be written.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment
* size minus 4.
*/
public final void putIntBigEndian(int index, int value) {
@@ -828,7 +828,7 @@ public abstract class MemorySegment {
* @param index The position from which the value will be read.
* @return The long value at the given position.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment
* size minus 8.
*/
public final long getLong(int index) {
@@ -856,7 +856,7 @@ public abstract class MemorySegment {
* @param index The position from which the value will be read.
* @return The long value at the given position.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment
* size minus 8.
*/
public final long getLongLittleEndian(int index) {
@@ -878,7 +878,7 @@ public abstract class MemorySegment {
* @param index The position from which the value will be read.
* @return The long value at the given position.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment
* size minus 8.
*/
public final long getLongBigEndian(int index) {
@@ -900,7 +900,7 @@ public abstract class MemorySegment {
* @param index The position at which the value will be written.
* @param value The long value to be written.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment
* size minus 8.
*/
public final void putLong(int index, long value) {
@@ -928,7 +928,7 @@ public abstract class MemorySegment {
* @param index The position at which the value will be written.
* @param value The long value to be written.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment
* size minus 8.
*/
public final void putLongLittleEndian(int index, long value) {
@@ -950,7 +950,7 @@ public abstract class MemorySegment {
* @param index The position at which the value will be written.
* @param value The long value to be written.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment
* size minus 8.
*/
public final void putLongBigEndian(int index, long value) {
@@ -972,7 +972,7 @@ public abstract class MemorySegment {
* @param index The position from which the value will be read.
* @return The float value at the given position.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment
* size minus 4.
*/
public final float getFloat(int index) {
@@ -990,7 +990,7 @@ public abstract class MemorySegment {
* @param index The position from which the value will be read.
* @return The long value at the given position.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment
* size minus 8.
*/
public final float getFloatLittleEndian(int index) {
@@ -1008,7 +1008,7 @@ public abstract class MemorySegment {
* @param index The position from which the value will be read.
* @return The long value at the given position.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment
* size minus 8.
*/
public final float getFloatBigEndian(int index) {
@@ -1026,7 +1026,7 @@ public abstract class MemorySegment {
* @param index The position at which the value will be written.
* @param value The float value to be written.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment
* size minus 4.
*/
public final void putFloat(int index, float value) {
@@ -1044,7 +1044,7 @@ public abstract class MemorySegment {
* @param index The position at which the value will be written.
* @param value The long value to be written.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment
* size minus 8.
*/
public final void putFloatLittleEndian(int index, float value) {
@@ -1062,7 +1062,7 @@ public abstract class MemorySegment {
* @param index The position at which the value will be written.
* @param value The long value to be written.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment
* size minus 8.
*/
public final void putFloatBigEndian(int index, float value) {
@@ -1080,7 +1080,7 @@ public abstract class MemorySegment {
* @param index The position from which the value will be read.
* @return The double value at the given position.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment
* size minus 8.
*/
public final double getDouble(int index) {
@@ -1098,7 +1098,7 @@ public abstract class MemorySegment {
* @param index The position from which the value will be read.
* @return The long value at the given position.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment
* size minus 8.
*/
public final double getDoubleLittleEndian(int index) {
@@ -1116,7 +1116,7 @@ public abstract class MemorySegment {
* @param index The position from which the value will be read.
* @return The long value at the given position.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment
* size minus 8.
*/
public final double getDoubleBigEndian(int index) {
@@ -1134,7 +1134,7 @@ public abstract class MemorySegment {
* @param index The position at which the memory will be written.
* @param value The double value to be written.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment
* size minus 8.
*/
public final void putDouble(int index, double value) {
@@ -1152,7 +1152,7 @@ public abstract class MemorySegment {
* @param index The position at which the value will be written.
* @param value The long value to be written.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment
* size minus 8.
*/
public final void putDoubleLittleEndian(int index, double value) {
@@ -1170,7 +1170,7 @@ public abstract class MemorySegment {
* @param index The position at which the value will be written.
* @param value The long value to be written.
*
- * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger then the segment
+ * @throws IndexOutOfBoundsException Thrown, if the index is negative, or larger than the segment
* size minus 8.
*/
public final void putDoubleBigEndian(int index, double value) {
diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/InPlaceMutableHashTable.java b/flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/InPlaceMutableHashTable.java
index 22a5d2a..f9622b4 100644
--- a/flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/InPlaceMutableHashTable.java
+++ b/flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/InPlaceMutableHashTable.java
@@ -52,7 +52,7 @@ import java.util.List;
* - Staging area: This is a small, temporary storage area for writing updated records. This is needed,
* because before serializing a record, there is no way to know in advance how large will it be.
* Therefore, we can't serialize directly into the record area when we are doing an update, because
- * if it turns out to be larger then the old record, then it would override some other record
+ * if it turns out to be larger than the old record, then it would override some other record
* that happens to be after the old one in memory. The solution is to serialize to the staging area first,
* and then copy it to the place of the original if it has the same size, otherwise allocate a new linked
* list element at the end of the record area, and mark the old one as abandoned. This creates "holes" in