You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/07 09:27:04 UTC
[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request
#4201: Fix bad rewrite Result for or query sql when using encryptRule
tristaZero opened a new pull request #4201: Fix bad rewrite Result for or query sql when using encryptRule
URL: https://github.com/apache/incubator-shardingsphere/pull/4201
Fixes #4188.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4201: Fix
bad rewrite Result for or query sql when using encryptRule
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4201: Fix bad rewrite Result for or query sql when using encryptRule
URL: https://github.com/apache/incubator-shardingsphere/pull/4201
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4201: Fix
bad rewrite Result for or query sql when using encryptRule
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4201: Fix bad rewrite Result for or query sql when using encryptRule
URL: https://github.com/apache/incubator-shardingsphere/pull/4201#issuecomment-583377961
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4201?src=pr&el=h1) Report
> Merging [#4201](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4201?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/81f161a328ca8b4cea696ee6bd36bc348c307e06?src=pr&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4201?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4201 +/- ##
===========================================
- Coverage 60.84% 60.8% -0.04%
Complexity 352 352
===========================================
Files 1012 1012
Lines 16926 16937 +11
Branches 2981 2983 +2
===========================================
Hits 10298 10298
- Misses 5976 5987 +11
Partials 652 652
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4201?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ken/pojo/EncryptPredicateEqualRightValueToken.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4201/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1yZXdyaXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvdG9rZW4vcG9qby9FbmNyeXB0UHJlZGljYXRlRXF1YWxSaWdodFZhbHVlVG9rZW4uamF2YQ==) | `100% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [.../token/pojo/EncryptPredicateInRightValueToken.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4201/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1yZXdyaXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvdG9rZW4vcG9qby9FbmNyeXB0UHJlZGljYXRlSW5SaWdodFZhbHVlVG9rZW4uamF2YQ==) | `87.5% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [...ken/pojo/generic/SubstitutableColumnNameToken.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4201/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1yZXdyaXRlL3NoYXJkaW5nc3BoZXJlLXJld3JpdGUtZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS91bmRlcmx5aW5nL3Jld3JpdGUvc3FsL3Rva2VuL3Bvam8vZ2VuZXJpYy9TdWJzdGl0dXRhYmxlQ29sdW1uTmFtZVRva2VuLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...impl/EncryptPredicateRightValueTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4201/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1yZXdyaXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwvRW5jcnlwdFByZWRpY2F0ZVJpZ2h0VmFsdWVUb2tlbkdlbmVyYXRvci5qYXZh) | `83.33% <100%> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [...tor/impl/EncryptPredicateColumnTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4201/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1yZXdyaXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwvRW5jcnlwdFByZWRpY2F0ZUNvbHVtblRva2VuR2VuZXJhdG9yLmphdmE=) | `85.71% <100%> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [...dingsphere/sql/parser/visitor/MySQLDCLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4201/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvTXlTUUxEQ0xWaXNpdG9yLmphdmE=) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4201?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4201?src=pr&el=footer). Last update [81f161a...91740da](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4201?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4201: Fix
bad rewrite Result for or query sql when using encryptRule
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4201: Fix bad rewrite Result for or query sql when using encryptRule
URL: https://github.com/apache/incubator-shardingsphere/pull/4201#issuecomment-583367642
## Pull Request Test Coverage Report for [Build 1638](https://coveralls.io/builds/28588320)
* **2** of **2** **(100.0%)** changed or added relevant lines in **2** files are covered.
* **22** unchanged lines in **2** files lost coverage.
* Overall coverage decreased (**-0.04%**) to **64.716%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28588320/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L74) | 2 | 80.0% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDCLVisitor.java](https://coveralls.io/builds/28588320/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDCLVisitor.java#L51) | 20 | 0% |
<!-- | **Total:** | **22** | | -->
| Totals | [](https://coveralls.io/builds/28588320) |
| :-- | --: |
| Change from base [Build 9367](https://coveralls.io/builds/28586629): | -0.04% |
| Covered Lines: | 10961 |
| Relevant Lines: | 16937 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4201: Fix bad rewrite Result for or query sql when using encryptRule
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4201: Fix bad rewrite Result for or query sql when using encryptRule
URL: https://github.com/apache/incubator-shardingsphere/pull/4201#issuecomment-583367642
## Pull Request Test Coverage Report for [Build 9370](https://coveralls.io/builds/28588952)
* **2** of **2** **(100.0%)** changed or added relevant lines in **2** files are covered.
* **20** unchanged lines in **1** file lost coverage.
* Overall coverage decreased (**-0.04%**) to **64.71%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDCLVisitor.java](https://coveralls.io/builds/28588952/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDCLVisitor.java#L51) | 20 | 0% |
<!-- | **Total:** | **20** | | -->
| Totals | [](https://coveralls.io/builds/28588952) |
| :-- | --: |
| Change from base [Build 9367](https://coveralls.io/builds/28586629): | -0.04% |
| Covered Lines: | 10960 |
| Relevant Lines: | 16937 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services