You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "XLPE (via GitHub)" <gi...@apache.org> on 2025/05/12 02:48:56 UTC
[PR] Fix(nereids): align locate function behavior with BE side [doris]
XLPE opened a new pull request, #50797:
URL: https://github.com/apache/doris/pull/50797
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
In Doris versions above 2.1.8 and above 3.0.3, , the newly added locate function does not behave consistently with the BE.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [x] Regression test
- [ ] Unit Test
- [x] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](nerids) align locate function behavior with BE side [doris]
Posted by "XLPE (via GitHub)" <gi...@apache.org>.
XLPE commented on PR #50797:
URL: https://github.com/apache/doris/pull/50797#issuecomment-2871488360
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](nerids) align locate function behavior with BE side [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50797:
URL: https://github.com/apache/doris/pull/50797#issuecomment-2871808165
<details>
<summary>TPC-DS: <b>Total hot run time: 194174 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 21ba0cf14a68ecfd1aa9ce43ad1a15404443a507, data reload: false
query1 1406 1099 1064 1064
query2 6203 1793 1804 1793
query3 11151 4568 4648 4568
query4 53970 24388 23244 23244
query5 4995 543 462 462
query6 338 210 207 207
query7 4877 529 294 294
query8 321 273 251 251
query9 5652 2669 2673 2669
query10 443 329 273 273
query11 15019 14986 14921 14921
query12 159 114 106 106
query13 1042 530 426 426
query14 10137 6472 6429 6429
query15 216 210 180 180
query16 7179 678 493 493
query17 1121 727 612 612
query18 1664 415 329 329
query19 208 205 178 178
query20 130 137 121 121
query21 208 126 108 108
query22 4398 4409 4302 4302
query23 34405 33515 33498 33498
query24 6673 2444 2458 2444
query25 462 466 420 420
query26 720 271 161 161
query27 2249 523 343 343
query28 2968 2167 2172 2167
query29 595 578 434 434
query30 279 226 190 190
query31 875 867 788 788
query32 74 64 62 62
query33 444 359 330 330
query34 828 898 555 555
query35 788 836 753 753
query36 958 1024 878 878
query37 118 107 80 80
query38 4210 4207 4260 4207
query39 1503 1451 1451 1451
query40 211 124 116 116
query41 55 56 50 50
query42 124 119 115 115
query43 530 540 481 481
query44 1398 827 845 827
query45 182 176 169 169
query46 862 1030 657 657
query47 1856 1909 1801 1801
query48 422 435 322 322
query49 700 502 453 453
query50 698 717 420 420
query51 4246 4214 4280 4214
query52 116 114 103 103
query53 231 256 190 190
query54 601 600 537 537
query55 93 87 91 87
query56 354 317 305 305
query57 1150 1205 1155 1155
query58 269 263 262 262
query59 2721 2792 2594 2594
query60 339 332 304 304
query61 135 138 123 123
query62 744 765 681 681
query63 238 199 200 199
query64 2173 1078 718 718
query65 4401 4273 4236 4236
query66 729 406 313 313
query67 15971 15770 15651 15651
query68 7354 889 515 515
query69 535 316 278 278
query70 1206 1093 1116 1093
query71 529 323 301 301
query72 5788 4847 4862 4847
query73 1472 647 363 363
query74 8988 9016 8949 8949
query75 3963 3279 2727 2727
query76 4196 1181 757 757
query77 651 374 285 285
query78 10139 10253 9428 9428
query79 2543 800 582 582
query80 577 508 455 455
query81 501 247 215 215
query82 438 123 102 102
query83 344 253 235 235
query84 292 107 83 83
query85 785 387 314 314
query86 374 291 291 291
query87 4429 4459 4434 4434
query88 3477 2302 2306 2302
query89 414 311 281 281
query90 1830 210 215 210
query91 146 152 111 111
query92 79 63 58 58
query93 1962 934 578 578
query94 666 419 283 283
query95 375 298 290 290
query96 490 577 283 283
query97 3232 3405 3158 3158
query98 244 204 203 203
query99 1410 1396 1289 1289
Total cold run time: 299964 ms
Total hot run time: 194174 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](nerids) align locate function behavior with BE side [doris]
Posted by "XLPE (via GitHub)" <gi...@apache.org>.
XLPE commented on PR #50797:
URL: https://github.com/apache/doris/pull/50797#issuecomment-2871584435
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](nerids) align locate function behavior with BE side [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50797:
URL: https://github.com/apache/doris/pull/50797#issuecomment-2871836806
<details>
<summary>ClickBench: <b>Total hot run time: 28.97 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 21ba0cf14a68ecfd1aa9ce43ad1a15404443a507, data reload: false
query1 0.04 0.04 0.03
query2 0.13 0.10 0.12
query3 0.25 0.19 0.19
query4 1.59 0.20 0.10
query5 0.57 0.55 0.55
query6 1.20 0.72 0.73
query7 0.03 0.02 0.01
query8 0.04 0.03 0.03
query9 0.57 0.51 0.50
query10 0.56 0.58 0.57
query11 0.16 0.11 0.11
query12 0.15 0.12 0.12
query13 0.61 0.60 0.59
query14 0.79 0.80 0.81
query15 0.87 0.85 0.85
query16 0.39 0.37 0.39
query17 1.01 1.03 1.07
query18 0.23 0.22 0.23
query19 1.94 1.77 1.83
query20 0.01 0.01 0.01
query21 15.40 0.93 0.55
query22 0.76 1.20 0.72
query23 14.83 1.39 0.60
query24 6.87 2.19 0.71
query25 0.53 0.10 0.08
query26 0.55 0.17 0.13
query27 0.05 0.05 0.04
query28 9.72 0.86 0.45
query29 12.57 3.88 3.26
query30 0.26 0.10 0.07
query31 2.82 0.61 0.38
query32 3.23 0.54 0.48
query33 3.04 3.04 3.17
query34 15.76 5.11 4.53
query35 4.58 4.54 4.50
query36 0.68 0.49 0.47
query37 0.08 0.06 0.06
query38 0.05 0.04 0.03
query39 0.03 0.02 0.03
query40 0.18 0.13 0.12
query41 0.08 0.03 0.02
query42 0.03 0.02 0.03
query43 0.03 0.03 0.02
Total cold run time: 103.27 s
Total hot run time: 28.97 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Fix(nereids) align locate function behavior with BE side [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50797:
URL: https://github.com/apache/doris/pull/50797#issuecomment-2870674818
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Fix(nereids) align locate function behavior with BE side [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50797:
URL: https://github.com/apache/doris/pull/50797#issuecomment-2870674884
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Fix(nereids) align locate function behavior with BE side [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #50797:
URL: https://github.com/apache/doris/pull/50797#issuecomment-2871474475
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Fix(nereids): align locate function behavior with BE side [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #50797:
URL: https://github.com/apache/doris/pull/50797#issuecomment-2870570525
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](nerids) align locate function behavior with BE side [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50797:
URL: https://github.com/apache/doris/pull/50797#issuecomment-2871767496
<details>
<summary>TPC-H: <b>Total hot run time: 34766 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 21ba0cf14a68ecfd1aa9ce43ad1a15404443a507, data reload: false
------ Round 1 ----------------------------------
q1 25809 4981 5012 4981
q2 2062 282 182 182
q3 10388 1214 685 685
q4 10228 990 539 539
q5 7558 2351 2339 2339
q6 186 162 133 133
q7 919 755 622 622
q8 9324 1239 1173 1173
q9 6835 5065 5135 5065
q10 7043 2367 1905 1905
q11 490 291 273 273
q12 344 351 212 212
q13 17798 3666 3069 3069
q14 225 227 224 224
q15 528 497 491 491
q16 420 435 369 369
q17 615 854 375 375
q18 7594 7266 7226 7226
q19 1452 939 530 530
q20 342 336 234 234
q21 4100 3297 3131 3131
q22 1082 1071 1008 1008
Total cold run time: 115342 ms
Total hot run time: 34766 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5089 5118 5038 5038
q2 244 330 241 241
q3 2133 2645 2273 2273
q4 1345 1782 1340 1340
q5 4464 4401 4348 4348
q6 217 173 126 126
q7 1972 1946 1737 1737
q8 2556 2623 2561 2561
q9 7239 7193 7034 7034
q10 3009 3182 2769 2769
q11 575 507 495 495
q12 697 753 637 637
q13 3474 3897 3247 3247
q14 300 319 295 295
q15 525 482 477 477
q16 434 479 434 434
q17 1147 1499 1421 1421
q18 7786 7561 7378 7378
q19 787 824 973 824
q20 2050 1966 1835 1835
q21 5101 4867 4866 4866
q22 1116 1088 1061 1061
Total cold run time: 52260 ms
Total hot run time: 50437 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](nerids) align locate function behavior with BE side [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #50797:
URL: https://github.com/apache/doris/pull/50797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org