You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2016/04/08 23:50:02 UTC
Review Request 45952: Implemented support for passing agent default
docker config.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45952/
-----------------------------------------------------------
Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Bugs: MESOS-4938
https://issues.apache.org/jira/browse/MESOS-4938
Repository: mesos
Description
-------
Implemented support for passing agent default docker config.
Diffs
-----
src/slave/containerizer/mesos/provisioner/docker/store.cpp eeec94326a4fd67675df10e0b6a32267e555fa96
src/uri/fetchers/docker.hpp c855a2b55a07bb398f7547b44a85b8ba2d2b2ec3
src/uri/fetchers/docker.cpp ab8f5e05758b7de2573605c81ac80e656bb1db24
Diff: https://reviews.apache.org/r/45952/diff/
Testing
-------
make check
Tested with mesos-execute, using a private repo from docker hub. Both cases are tested:
1. --docker_registry=private_registry
2. private_registry/repo
Thanks,
Gilbert Song
Re: Review Request 45952: Implemented support for passing agent
default docker config.
Posted by Guangya Liu <gy...@gmail.com>.
> On 四月 11, 2016, 7:37 a.m., Guangya Liu wrote:
> > src/uri/fetchers/docker.cpp, line 636
> > <https://reviews.apache.org/r/45952/diff/1/?file=1337596#file1337596line636>
> >
> > Add a log here to identify that the fetcher is now using auth to fetch the image?
Adding the log in `getCredential` may be better, post some comments in https://reviews.apache.org/r/45949/ , please check. Thanks.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45952/#review128078
-----------------------------------------------------------
On 四月 8, 2016, 9:50 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45952/
> -----------------------------------------------------------
>
> (Updated 四月 8, 2016, 9:50 p.m.)
>
>
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-4938
> https://issues.apache.org/jira/browse/MESOS-4938
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented support for passing agent default docker config.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/store.cpp eeec94326a4fd67675df10e0b6a32267e555fa96
> src/uri/fetchers/docker.hpp c855a2b55a07bb398f7547b44a85b8ba2d2b2ec3
> src/uri/fetchers/docker.cpp ab8f5e05758b7de2573605c81ac80e656bb1db24
>
> Diff: https://reviews.apache.org/r/45952/diff/
>
>
> Testing
> -------
>
> make check
>
> Tested with mesos-execute, using a private repo from docker hub. Both cases are tested:
> 1. --docker_registry=private_registry
> 2. private_registry/repo
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 45952: Implemented support for passing agent
default docker config.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45952/#review128078
-----------------------------------------------------------
src/uri/fetchers/docker.cpp (lines 323 - 325)
<https://reviews.apache.org/r/45952/#comment191470>
Does there are any document change for this?
src/uri/fetchers/docker.cpp (line 634)
<https://reviews.apache.org/r/45952/#comment191471>
Add a log here to identify that the fetcher is now using auth to fetch the image?
- Guangya Liu
On 四月 8, 2016, 9:50 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45952/
> -----------------------------------------------------------
>
> (Updated 四月 8, 2016, 9:50 p.m.)
>
>
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-4938
> https://issues.apache.org/jira/browse/MESOS-4938
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented support for passing agent default docker config.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/store.cpp eeec94326a4fd67675df10e0b6a32267e555fa96
> src/uri/fetchers/docker.hpp c855a2b55a07bb398f7547b44a85b8ba2d2b2ec3
> src/uri/fetchers/docker.cpp ab8f5e05758b7de2573605c81ac80e656bb1db24
>
> Diff: https://reviews.apache.org/r/45952/diff/
>
>
> Testing
> -------
>
> make check
>
> Tested with mesos-execute, using a private repo from docker hub. Both cases are tested:
> 1. --docker_registry=private_registry
> 2. private_registry/repo
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 45952: Implemented support for passing agent
default docker config.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45952/#review128116
-----------------------------------------------------------
Patch looks great!
Reviews applied: [45949, 45950, 45951, 45952]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 8, 2016, 9:50 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45952/
> -----------------------------------------------------------
>
> (Updated April 8, 2016, 9:50 p.m.)
>
>
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-4938
> https://issues.apache.org/jira/browse/MESOS-4938
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented support for passing agent default docker config.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/store.cpp eeec94326a4fd67675df10e0b6a32267e555fa96
> src/uri/fetchers/docker.hpp c855a2b55a07bb398f7547b44a85b8ba2d2b2ec3
> src/uri/fetchers/docker.cpp ab8f5e05758b7de2573605c81ac80e656bb1db24
>
> Diff: https://reviews.apache.org/r/45952/diff/
>
>
> Testing
> -------
>
> make check
>
> Tested with mesos-execute, using a private repo from docker hub. Both cases are tested:
> 1. --docker_registry=private_registry
> 2. private_registry/repo
>
>
> Thanks,
>
> Gilbert Song
>
>