You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2016/05/17 12:08:04 UTC
[GitHub] storm pull request: STORM-1842 Forward references in storm.thrift ...
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1423
STORM-1842 Forward references in storm.thrift cause tooling issues
Please refer [STORM-1842](https://issues.apache.org/jira/browse/STORM-1842) for more details.
* python doesn't support forward reference so ttypes.py has a problem regarding this issue
* reorder HBPulse, HBRecords, HBNodes to resolve forward reference issue
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-1842
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1423.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1423
----
commit ad46a470c173c8daf2bd76bc10ecbfc6fd08865b
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-05-17T11:23:38Z
STORM-1842 Forward references in storm.thrift cause tooling issues
* python doesn't support forward reference so ttypes.py has a problem regarding this issue
* reorder HBPulse, HBRecords, HBNodes to resolve forward reference issue
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1842 Forward references in storm.thrift ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR closed the pull request at:
https://github.com/apache/storm/pull/1423
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1842 Forward references in storm.thrift ...
Posted by barrywhart <gi...@git.apache.org>.
Github user barrywhart commented on the pull request:
https://github.com/apache/storm/pull/1423#issuecomment-219707172
The change looks good to me.
Are the build failures related to this change?
https://travis-ci.org/apache/storm/jobs/130816708#L1162
It looks like something unrelated:
```[ERROR] Failed to execute goal org.apache.maven.plugins:maven-remote-resources-plugin:1.2.1:process (default) on project storm-hive: Error resolving project artifact: Could not transfer artifact org.pentaho:pentaho-aggdesigner-algorithm:pom:5.1.3-jhyde from/to sonatype-apache (https://repository.apache.org/releases/): Connect to repository.apache.org:443 [repository.apache.org/140.211.11.112] failed: Connection timed out for project org.pentaho:pentaho-aggdesigner-algorithm:jar:5.1.3-jhyde -> [Help 1]```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1842 Forward references in storm.thrift ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/1423#issuecomment-219698986
I'm not sure it breaks backward compatibility, so if anyone checks it doesn't break compatibility that would be great.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1842 Forward references in storm.thrift ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/1423#issuecomment-220884435
I merged into master but github seems to not recognize merge commits as pull request.
Closed via 45e62a75ce667012fa0cf74e1543784b1620d36b
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1842 Forward references in storm.thrift ...
Posted by barrywhart <gi...@git.apache.org>.
Github user barrywhart commented on the pull request:
https://github.com/apache/storm/pull/1423#issuecomment-219865469
I tested with the updated storm.thrift from this pull request. It addresses the Python Thrift issues I was encountering.
From my perspective, this change is ready for merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1842 Forward references in storm.thrift ...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/1423#issuecomment-220677726
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1842 Forward references in storm.thrift ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/1423#issuecomment-219709570
@barrywhart
https://repository.apache.org/releases/ returns 503 now, which makes Travis CI failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---