You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2016/02/15 02:40:27 UTC
Review Request 43569: Updated log message if container not found.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43569/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Timothy Chen.
Repository: mesos
Description
-------
Updated log message if container not found.
Diffs
-----
src/slave/containerizer/docker.cpp ed1c9a551f03a37d572470e4c495f5df834198cc
src/slave/containerizer/mesos/containerizer.cpp 3de214d6c71773f5deb5db9fe3f527dd5064737f
Diff: https://reviews.apache.org/r/43569/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 43569: Updated log message if container not found.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43569/#review119209
-----------------------------------------------------------
Just some flyby comments.
src/slave/containerizer/docker.cpp (line 1119)
<https://reviews.apache.org/r/43569/#comment180481>
You don't need to use `stringify` here. `ContainerId` has the ostream operator.
src/slave/containerizer/mesos/containerizer.cpp (line 1185)
<https://reviews.apache.org/r/43569/#comment180483>
If we are adding `ContainerId` to other messages, we should add it here as well?
src/slave/containerizer/mesos/containerizer.cpp (line 1588)
<https://reviews.apache.org/r/43569/#comment180484>
Maybe
s/Ignore destroy of/Cannot reap/ ?
- Avinash sridharan
On Feb. 15, 2016, 1:56 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43569/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2016, 1:56 a.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated log message if container not found.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp ed1c9a551f03a37d572470e4c495f5df834198cc
> src/slave/containerizer/mesos/containerizer.cpp 3de214d6c71773f5deb5db9fe3f527dd5064737f
>
> Diff: https://reviews.apache.org/r/43569/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 43569: Updated log message if container not found.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43569/#review119206
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43569]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 15, 2016, 1:56 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43569/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2016, 1:56 a.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated log message if container not found.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp ed1c9a551f03a37d572470e4c495f5df834198cc
> src/slave/containerizer/mesos/containerizer.cpp 3de214d6c71773f5deb5db9fe3f527dd5064737f
>
> Diff: https://reviews.apache.org/r/43569/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 43569: Updated log message if container not found.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43569/#review119210
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43569]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 15, 2016, 4:17 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43569/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2016, 4:17 a.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated log message if container not found.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp ed1c9a551f03a37d572470e4c495f5df834198cc
> src/slave/containerizer/mesos/containerizer.cpp 3de214d6c71773f5deb5db9fe3f527dd5064737f
>
> Diff: https://reviews.apache.org/r/43569/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 43569: Updated log message if container not found.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43569/#review119224
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43015, 43569]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 15, 2016, 4:08 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43569/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2016, 4:08 p.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated log message if container not found.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp ed1c9a551f03a37d572470e4c495f5df834198cc
> src/slave/containerizer/mesos/containerizer.cpp 3de214d6c71773f5deb5db9fe3f527dd5064737f
>
> Diff: https://reviews.apache.org/r/43569/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 43569: Updated log message if container not found.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43569/#review119828
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43015, 43569]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 19, 2016, 1:52 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43569/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2016, 1:52 a.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated log message if container not found.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 0303208083f1ebd9f9df51178fd91ee4c763f61c
> src/slave/containerizer/mesos/containerizer.cpp 129406abdff715e321f683911e404c46676b6daf
>
> Diff: https://reviews.apache.org/r/43569/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 43569: Updated log message if container not found.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43569/#review125098
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43015, 43569]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On March 23, 2016, 1:50 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43569/
> -----------------------------------------------------------
>
> (Updated March 23, 2016, 1:50 p.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated log message if container not found.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109
> src/slave/containerizer/mesos/containerizer.cpp ee7a265975323ca891114a286357c8e42901560c
>
> Diff: https://reviews.apache.org/r/43569/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 43569: Updated log message if container not found.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43569/
-----------------------------------------------------------
(Updated 三月 23, 2016, 1:50 p.m.)
Review request for mesos, Jie Yu and Timothy Chen.
Repository: mesos
Description
-------
Updated log message if container not found.
Diffs (updated)
-----
src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109
src/slave/containerizer/mesos/containerizer.cpp ee7a265975323ca891114a286357c8e42901560c
Diff: https://reviews.apache.org/r/43569/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 43569: Updated log message if container not found.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43569/
-----------------------------------------------------------
(Updated 二月 19, 2016, 1:52 a.m.)
Review request for mesos, Jie Yu and Timothy Chen.
Changes
-------
Rebase.
Repository: mesos
Description
-------
Updated log message if container not found.
Diffs (updated)
-----
src/slave/containerizer/docker.cpp 0303208083f1ebd9f9df51178fd91ee4c763f61c
src/slave/containerizer/mesos/containerizer.cpp 129406abdff715e321f683911e404c46676b6daf
Diff: https://reviews.apache.org/r/43569/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 43569: Updated log message if container not found.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43569/
-----------------------------------------------------------
(Updated 二月 15, 2016, 4:08 p.m.)
Review request for mesos, Jie Yu and Timothy Chen.
Repository: mesos
Description
-------
Updated log message if container not found.
Diffs (updated)
-----
src/slave/containerizer/docker.cpp ed1c9a551f03a37d572470e4c495f5df834198cc
src/slave/containerizer/mesos/containerizer.cpp 3de214d6c71773f5deb5db9fe3f527dd5064737f
Diff: https://reviews.apache.org/r/43569/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 43569: Updated log message if container not found.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43569/#review119218
-----------------------------------------------------------
src/slave/containerizer/docker.cpp (line 1656)
<https://reviews.apache.org/r/43569/#comment180489>
Let's stick with the same formatting with single quotes for container id
src/slave/containerizer/mesos/containerizer.cpp (line 1611)
<https://reviews.apache.org/r/43569/#comment180490>
This won't happen since the previous if statement already checks for this.
src/slave/containerizer/mesos/containerizer.cpp (line 1616)
<https://reviews.apache.org/r/43569/#comment180491>
This as well
- Timothy Chen
On Feb. 15, 2016, 4:17 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43569/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2016, 4:17 a.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated log message if container not found.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp ed1c9a551f03a37d572470e4c495f5df834198cc
> src/slave/containerizer/mesos/containerizer.cpp 3de214d6c71773f5deb5db9fe3f527dd5064737f
>
> Diff: https://reviews.apache.org/r/43569/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 43569: Updated log message if container not found.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43569/
-----------------------------------------------------------
(Updated 二月 15, 2016, 4:17 a.m.)
Review request for mesos, Jie Yu and Timothy Chen.
Repository: mesos
Description
-------
Updated log message if container not found.
Diffs (updated)
-----
src/slave/containerizer/docker.cpp ed1c9a551f03a37d572470e4c495f5df834198cc
src/slave/containerizer/mesos/containerizer.cpp 3de214d6c71773f5deb5db9fe3f527dd5064737f
Diff: https://reviews.apache.org/r/43569/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 43569: Updated log message if container not found.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43569/
-----------------------------------------------------------
(Updated 二月 15, 2016, 1:56 a.m.)
Review request for mesos, Jie Yu and Timothy Chen.
Repository: mesos
Description
-------
Updated log message if container not found.
Diffs (updated)
-----
src/slave/containerizer/docker.cpp ed1c9a551f03a37d572470e4c495f5df834198cc
src/slave/containerizer/mesos/containerizer.cpp 3de214d6c71773f5deb5db9fe3f527dd5064737f
Diff: https://reviews.apache.org/r/43569/diff/
Testing (updated)
-------
make
make check
Thanks,
Guangya Liu