[GitHub] [spark] Yikun commented on a diff in pull request #37671: [SPARK-40229][PS][TEST] Re-enable excel I/O test for pandas API on Spark

[GitBox <gi...@apache.org>]

Yikun commented on code in PR #37671:
URL: https://github.com/apache/spark/pull/37671#discussion_r966592734


##########
python/pyspark/pandas/tests/test_dataframe_conversion.py:
##########
@@ -90,7 +90,6 @@ def get_excel_dfs(pandas_on_spark_location, pandas_location):
             "expected": pd.read_excel(pandas_location, index_col=0),
         }
 
-    @unittest.skip("openpyxl")
     def test_to_excel(self):

Review Comment:
   What about this case for pypy3? Will it affect developers run tests?
   
   (I remember we run pypy3 and python3.9 in CI....[but not](https://github.com/itholic/spark/runs/8240425530?check_suite_focus=true#step:11:1174) running, pls let me know if I missed something history changes...)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org