You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zhangminglei <gi...@git.apache.org> on 2017/04/22 04:17:09 UTC
[GitHub] flink pull request #3755: [FLINK-6351] [YARN] Refactoring YarnFlinkApplicati...
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/3755
[FLINK-6351] [YARN] Refactoring YarnFlinkApplicationMasterRunner by c\u2026
\u2026ombining AbstractYarnFlinkApplicationMasterRunner in one class.
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink-6351
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3755.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3755
----
commit 239993cddc0ddc7ccdc29f4666c946bfdd23ba02
Author: zhangminglei <zm...@163.com>
Date: 2017-04-22T02:35:46Z
[FLINK-6351] [YARN] Refactoring YarnFlinkApplicationMasterRunner by combining AbstractYarnFlinkApplicationMasterRunner in one class.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3755: [FLINK-6351] [YARN] Refactoring YarnFlinkApplicationMaste...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3755
cc @tillrohrmann
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3755: [FLINK-6351] [YARN] Refactoring YarnFlinkApplicationMaste...
Posted by shuai-xu <gi...@git.apache.org>.
Github user shuai-xu commented on the issue:
https://github.com/apache/flink/pull/3755
There will soon be a YarnFlinkAppMaster extends AbstractYarnFlinkApplicationMasterRunner for flink yarn cluster mode, so need not combine them to one class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3755: [FLINK-6351] [YARN] Refactoring YarnFlinkApplicationMaste...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3755
Hey, @shuai-xu. Is there a corresponding JIRA for what you said ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---