You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/12/15 10:13:36 UTC

[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #1129: host/gap: improve legacy advertising for BLE_EXT_ADV=1

sjanc commented on a change in pull request #1129:
URL: https://github.com/apache/mynewt-nimble/pull/1129#discussion_r769474462



##########
File path: nimble/host/src/ble_gap.c
##########
@@ -2694,6 +2694,19 @@ ble_gap_ext_adv_params_tx(uint8_t instance,
     }
     if (params->legacy_pdu) {

Review comment:
       should we move this after include_tx_power to also cover anon an tx power?  (those are also invalid for legacy PDUs)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org