You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "GeorgeLeePatterson (via GitHub)" <gi...@apache.org> on 2025/11/01 18:59:34 UTC

[PR] feat: Add ListViewBuilder and LargeListViewBuilder for write support [arrow-js]

GeorgeLeePatterson opened a new pull request, #324:
URL: https://github.com/apache/arrow-js/pull/324

   ## What's Changed
   
   This PR adds write support for ListView and LargeListView types through builder classes, completing the view types implementation.
   
   ## Implementation Details
   
   ### Builders
   - ListViewBuilder and LargeListViewBuilder in `src/builder/listview.ts`
   - Uses Int32Array (ListView) and BigInt64Array (LargeListView) for offsets/sizes
   - Custom flush() to pass both valueOffsets and sizes to makeData
   - BigInt(0) syntax for ES5 compatibility (not 0n literals)
   
   ### Integration
   - Added to builderctor visitor for factory support
   - Exported from Arrow.ts and Arrow.dom.ts for public API
   
   ## What Works
   - [X] Building ListView/LargeListView columns from JavaScript arrays
   - [X] Separate offset and size tracking
   - [X] Proper null handling
   - [X] Round-trip: build → flush → read
   
   ## Testing
   - [X] Comprehensive unit tests in test/unit/builders/listview-tests.ts
   - [X] Tests verify offset/size semantics, null handling
   - [X] All existing tests pass
   - [X] CI validated on fork
   
   Builds on #320 and the ListView read support PR
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Add ListViewBuilder and LargeListViewBuilder for write support [arrow-js]

Posted by "GeorgeLeePatterson (via GitHub)" <gi...@apache.org>.
GeorgeLeePatterson commented on PR #324:
URL: https://github.com/apache/arrow-js/pull/324#issuecomment-3497503798

   Just as I did with the Utf8View and BinaryView PR, I will absorb this into the base PR since read and write support is required to support data types. I will decline this shortly. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org