[GitHub] [trafficcontrol] rob05c commented on a change in pull request #6357: Add t3c retrying app lock

[GitBox <gi...@apache.org>]

rob05c commented on a change in pull request #6357:
URL: https://github.com/apache/trafficcontrol/pull/6357#discussion_r752446487



##########
File path: cache-config/testing/ort-tests/t3c-lockfile_test.go
##########
@@ -0,0 +1,113 @@
+package orttest
+
+/*
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+   http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
+*/
+
+import (
+	"strings"
+	"sync"
+	"testing"
+	"time"
+
+	"github.com/apache/trafficcontrol/cache-config/testing/ort-tests/tcdata"
+)
+
+func TestLockfile(t *testing.T) {
+	testName := "TestLockfile"
+	t.Logf("------------- Starting " + testName + " ---------------")

Review comment:
       This is following the existing convention, e.g. https://github.com/apache/trafficcontrol/blob/master/cache-config/testing/ort-tests/to_requester_test.go#L36
   I didn't create the convention, and I agree, but it seemed better to follow the convention as long as it exists.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org