You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by Igor Galić <i....@brainsware.org> on 2013/08/13 00:12:07 UTC
Re: git commit: TS-2130: pthread_setname_np() detection fails on
various platforms
----- Original Message -----
> Updated Branches:
> refs/heads/master ca7b063d0 -> f390a8e41
>
>
> TS-2130: pthread_setname_np() detection fails on various platforms
>
>
> Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
> Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/f390a8e4
> Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/f390a8e4
> Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/f390a8e4
>
> Branch: refs/heads/master
> Commit: f390a8e41946e5d53c857b727c5d907468dd60ea
> Parents: ca7b063
> Author: James Peach <jp...@apache.org>
> Authored: Sun Aug 11 13:42:48 2013 -0700
> Committer: James Peach <jp...@apache.org>
> Committed: Sun Aug 11 13:42:48 2013 -0700
>
> ----------------------------------------------------------------------
> CHANGES | 2 ++
> configure.ac | 6 +++---
> 2 files changed, 5 insertions(+), 3 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/f390a8e4/CHANGES
> ----------------------------------------------------------------------
> diff --git a/CHANGES b/CHANGES
> index 8448ec5..9a15449 100644
> --- a/CHANGES
> +++ b/CHANGES
> @@ -2,6 +2,8 @@
> Changes with Apache Traffic Server 3.5.0
>
>
> + *) [TS-2130] pthread_setname_np() detection fails on various platforms.
> +
> *)[ TS-2096] improve SSL certificate loading error messages
>
> *) [TS-2129] Check for existence of ExtUtils::MakeMaker.
>
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/f390a8e4/configure.ac
> ----------------------------------------------------------------------
> diff --git a/configure.ac b/configure.ac
> index bfd92d0..c95ab43 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1549,7 +1549,7 @@ AC_SUBST(netinet_ip_icmph)
>
> # Darwin pthread_setname_np:
> AC_MSG_CHECKING([for 1-parameter version of pthread_setname_np()])
> -AC_COMPILE_IFELSE([
> +AC_LINK_IFELSE([
given the nature of autoconf.. and C/C++ shouldn't we always prefer
AC_LINK_* for our tests? I know this will drag out the configure
phase immensely, but once it completes, we should be reasonably
sure that our project will actually compile.
It might even make porting easier.
> AC_LANG_PROGRAM([
> #if HAVE_PTHREAD_H
> #include <pthread.h>
> @@ -1569,7 +1569,7 @@ AC_COMPILE_IFELSE([
>
> # Linux pthread_setname_np:
> AC_MSG_CHECKING([for 2-parameter version of pthread_setname_np()])
> -AC_COMPILE_IFELSE([
> +AC_LINK_IFELSE([
> AC_LANG_PROGRAM([
> #if HAVE_PTHREAD_H
> #include <pthread.h>
> @@ -1589,7 +1589,7 @@ AC_COMPILE_IFELSE([
>
> # BSD pthread_set_name_np:
> AC_MSG_CHECKING([for 2-parameter version of pthread_set_name_np()])
> -AC_COMPILE_IFELSE([
> +AC_LINK_IFELSE([
> AC_LANG_PROGRAM([
> #if HAVE_PTHREAD_H
> #include <pthread.h>
>
>
--
Igor Galić
Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515 2EA5 4B1D 9E08 A097 C9AE
Re: git commit: TS-2130: pthread_setname_np() detection fails on
various platforms
Posted by Igor Galić <i....@brainsware.org>.
----- Original Message -----
> On Aug 12, 2013, at 3:12 PM, Igor Galić <i....@brainsware.org> wrote:
>
> >
> >
> > ----- Original Message -----
> >> Updated Branches:
> >> refs/heads/master ca7b063d0 -> f390a8e41
> >>
> [snip]
> >> # Darwin pthread_setname_np:
> >> AC_MSG_CHECKING([for 1-parameter version of pthread_setname_np()])
> >> -AC_COMPILE_IFELSE([
> >> +AC_LINK_IFELSE([
> >
> > given the nature of autoconf.. and C/C++ shouldn't we always prefer
> > AC_LINK_* for our tests? I know this will drag out the configure
> > phase immensely, but once it completes, we should be reasonably
> > sure that our project will actually compile.
> >
> > It might even make porting easier.
>
> I'm not sure. It's hard to make a general statement about that :)
maybe I leaned a bit too far out the window with the porting bit, but
what about the first part?
> J
-- i
Igor Galić
Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515 2EA5 4B1D 9E08 A097 C9AE
Re: git commit: TS-2130: pthread_setname_np() detection fails on
various platforms
Posted by James Peach <jp...@apache.org>.
On Aug 12, 2013, at 3:12 PM, Igor Galić <i....@brainsware.org> wrote:
>
>
> ----- Original Message -----
>> Updated Branches:
>> refs/heads/master ca7b063d0 -> f390a8e41
>>
[snip]
>> # Darwin pthread_setname_np:
>> AC_MSG_CHECKING([for 1-parameter version of pthread_setname_np()])
>> -AC_COMPILE_IFELSE([
>> +AC_LINK_IFELSE([
>
> given the nature of autoconf.. and C/C++ shouldn't we always prefer
> AC_LINK_* for our tests? I know this will drag out the configure
> phase immensely, but once it completes, we should be reasonably
> sure that our project will actually compile.
>
> It might even make porting easier.
I'm not sure. It's hard to make a general statement about that :)
J