You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by xuchuanyin <gi...@git.apache.org> on 2018/01/16 12:28:26 UTC
[GitHub] carbondata pull request #1814: [CARBONDATA-2035][DataLoad][Tests] Fix bugs i...
GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/1814
[CARBONDATA-2035][DataLoad][Tests] Fix bugs in raising exception through assertion
By default, the "VM parameters" is empty and `-ea` is disabled, so the assert sentence in code will not come into effect, thus causing this problem.
In conclusion, carbondata should not detect&throw exception in this way, we need to correct it.
CAUTION
===
**I also noticed that there are many tests that use "assert condition", this may also cause some underlying problems.**
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [x] Any interfaces changed?
`No`
- [x] Any backward compatibility impacted?
`No`
- [x] Document update required?
`No`
- [x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
`No`
- How it is tested? Please attach test report.
`Tested in local node`
- Is it a performance related change? Please attach the performance test report.
`No`
- Any additional information to help reviewers in testing this change.
`We should not use assertion to detect/throw exception since assertion is disabled if we don't specify ‘-ea’ VM parameter.`
- [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
`Not related`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xuchuanyin/carbondata 0116_bug_test_assertion
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1814.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1814
----
commit 789661cb2129534132eded1831cd8db8285be223
Author: xuchuanyin <xu...@...>
Date: 2018-01-16T12:20:24Z
fix bugs in raising exception through assertion
----
---
[GitHub] carbondata issue #1814: [CARBONDATA-2035][DataLoad][Tests] Fix bugs in raisi...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1814
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2929/
---
[GitHub] carbondata issue #1814: [CARBONDATA-2035][DataLoad][Tests] Fix bugs in raisi...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1814
This issue has been fixed by another PR, so close it here
---
[GitHub] carbondata issue #1814: [CARBONDATA-2035][DataLoad][Tests] Fix bugs in raisi...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1814
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2927/
---
[GitHub] carbondata issue #1814: [CARBONDATA-2035][DataLoad][Tests] Fix bugs in raisi...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1814
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1608/
---
[GitHub] carbondata issue #1814: [CARBONDATA-2035][DataLoad][Tests] Fix bugs in raisi...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1814
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1613/
---
[GitHub] carbondata issue #1814: [CARBONDATA-2035][DataLoad][Tests] Fix bugs in raisi...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1814
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2848/
---
[GitHub] carbondata pull request #1814: [CARBONDATA-2035][DataLoad][Tests] Fix bugs i...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin closed the pull request at:
https://github.com/apache/carbondata/pull/1814
---
[GitHub] carbondata issue #1814: [CARBONDATA-2035][DataLoad][Tests] Fix bugs in raisi...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1814
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2838/
---
[GitHub] carbondata issue #1814: [CARBONDATA-2035][DataLoad][Tests] Fix bugs in raisi...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1814
retest this please
---
[GitHub] carbondata issue #1814: [CARBONDATA-2035][DataLoad][Tests] Fix bugs in raisi...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1814
retest this please
---
[GitHub] carbondata issue #1814: [CARBONDATA-2035][DataLoad][Tests] Fix bugs in raisi...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1814
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2843/
---
[GitHub] carbondata issue #1814: [CARBONDATA-2035][DataLoad][Tests] Fix bugs in raisi...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1814
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1632/
---
[GitHub] carbondata issue #1814: [CARBONDATA-2035][DataLoad][Tests] Fix bugs in raisi...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1814
retest this please
---
[GitHub] carbondata issue #1814: [CARBONDATA-2035][DataLoad][Tests] Fix bugs in raisi...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1814
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2928/
---
[GitHub] carbondata issue #1814: [CARBONDATA-2035][DataLoad][Tests] Fix bugs in raisi...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1814
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1603/
---
[GitHub] carbondata issue #1814: [CARBONDATA-2035][DataLoad][Tests] Fix bugs in raisi...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1814
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2865/
---