You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Johnnyssc (via GitHub)" <gi...@apache.org> on 2024/09/12 13:14:12 UTC
[PR] [enhancement]support query when only restoring a few partitions of this table [doris]
Johnnyssc opened a new pull request, #40768:
URL: https://github.com/apache/doris/pull/40768
If query execute in one table that is restoring data, query may failed with Exception occasionally.
Exception info :" Table state is not NORMAL: 'RESTORING'".
But mostly restoreJob only effects some partitions in this table, not all of them, so that the other partitions need support query successfully.
The reason why this problem happen occasionally is that `Analyzer.resolveTableRef` check olapTable.state and partition.state without readLock, so fix it by check partition.state only.
ps: set restore status for partitions in this pr:https://github.com/apache/doris/pull/8245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement]support query when only restoring a few partitions of this table [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #40768:
URL: https://github.com/apache/doris/pull/40768#discussion_r1796712381
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/Analyzer.java:
##########
@@ -830,17 +830,14 @@ public TableRef resolveTableRef(TableRef tableRef) throws AnalysisException {
.getDbOrAnalysisException(tableName.getDb());
TableIf table = database.getTableOrAnalysisException(tableName.getTbl());
- if (table.isManagedTable() && (((OlapTable) table).getState() == OlapTableState.RESTORE
- || ((OlapTable) table).getState() == OlapTableState.RESTORE_WITH_LOAD)) {
- Boolean isAnyPartitionRestoring = ((OlapTable) table).getPartitions().stream()
- .anyMatch(partition -> partition.getState() == PartitionState.RESTORE);
- if (isAnyPartitionRestoring) {
- // if doing restore with partitions, the status check push down to OlapScanNode::computePartitionInfo to
- // support query that partitions is not restoring.
- } else {
- // if doing restore with table, throw exception here
- ErrorReport.reportAnalysisException(ErrorCode.ERR_BAD_TABLE_STATE, "RESTORING");
- }
+ Boolean isAllPartitionRestoring = ((OlapTable) table).getPartitions().stream()
Review Comment:
legacy planner will be remove very soon, so u should impl it in Nereids
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement]support query when only restoring a few partitions of this table [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #40768: [enhancement]support query when only restoring a few partitions of this table
URL: https://github.com/apache/doris/pull/40768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement]support query when only restoring a few partitions of this table [doris]
Posted by "Johnnyssc (via GitHub)" <gi...@apache.org>.
Johnnyssc commented on PR #40768:
URL: https://github.com/apache/doris/pull/40768#issuecomment-2348064867
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement]support query when only restoring a few partitions of this table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40768:
URL: https://github.com/apache/doris/pull/40768#issuecomment-2346253089
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement]support query when only restoring a few partitions of this table [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40768:
URL: https://github.com/apache/doris/pull/40768#issuecomment-2791238119
We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement]support query when only restoring a few partitions of this table [doris]
Posted by "Johnnyssc (via GitHub)" <gi...@apache.org>.
Johnnyssc commented on PR #40768:
URL: https://github.com/apache/doris/pull/40768#issuecomment-2346253471
run build all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org