You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Mike May <th...@gmail.com> on 2012/07/26 19:26:39 UTC
Re: Review Request: Adding IDs to form elements in login.jsp and
authorize.jsp
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6155/
-----------------------------------------------------------
(Updated July 26, 2012, 5:26 p.m.)
Review request for shindig and Ryan Baxter.
Changes
-------
Adding shindig and JIRA
Description
-------
The forms and the form elements in login.jsp and authorize.jsp do not have IDs.
This addresses bug SHINDIG-1828.
https://issues.apache.org/jira/browse/SHINDIG-1828
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/WEB-INF/authorize.jsp 1366029
http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/login.jsp 1366029
Diff: https://reviews.apache.org/r/6155/diff/
Testing
-------
All tests pass.
Thanks,
Mike May
Re: Review Request: Adding IDs to form elements in login.jsp and
authorize.jsp
Posted by Mike May <th...@gmail.com>.
> On July 26, 2012, 11:15 p.m., Ryan Baxter wrote:
> > Ship It!
>
> Ryan Baxter wrote:
> Committed revision 1366425
>
> Ryan Baxter wrote:
> Mike can you attach the patch to the JIRA? I should have checked this first before checking it in.
Attached! My bad, thought I had already attached it.
- Mike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6155/#review9522
-----------------------------------------------------------
On July 26, 2012, 5:26 p.m., Mike May wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6155/
> -----------------------------------------------------------
>
> (Updated July 26, 2012, 5:26 p.m.)
>
>
> Review request for shindig and Ryan Baxter.
>
>
> Description
> -------
>
> The forms and the form elements in login.jsp and authorize.jsp do not have IDs.
>
>
> This addresses bug SHINDIG-1828.
> https://issues.apache.org/jira/browse/SHINDIG-1828
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/WEB-INF/authorize.jsp 1366029
> http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/login.jsp 1366029
>
> Diff: https://reviews.apache.org/r/6155/diff/
>
>
> Testing
> -------
>
> All tests pass.
>
>
> Thanks,
>
> Mike May
>
>
Re: Review Request: Adding IDs to form elements in login.jsp and
authorize.jsp
Posted by Ryan Baxter <rb...@gmail.com>.
> On July 26, 2012, 11:15 p.m., Ryan Baxter wrote:
> > Ship It!
Committed revision 1366425
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6155/#review9522
-----------------------------------------------------------
On July 26, 2012, 5:26 p.m., Mike May wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6155/
> -----------------------------------------------------------
>
> (Updated July 26, 2012, 5:26 p.m.)
>
>
> Review request for shindig and Ryan Baxter.
>
>
> Description
> -------
>
> The forms and the form elements in login.jsp and authorize.jsp do not have IDs.
>
>
> This addresses bug SHINDIG-1828.
> https://issues.apache.org/jira/browse/SHINDIG-1828
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/WEB-INF/authorize.jsp 1366029
> http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/login.jsp 1366029
>
> Diff: https://reviews.apache.org/r/6155/diff/
>
>
> Testing
> -------
>
> All tests pass.
>
>
> Thanks,
>
> Mike May
>
>
Re: Review Request: Adding IDs to form elements in login.jsp and
authorize.jsp
Posted by Ryan Baxter <rb...@gmail.com>.
> On July 26, 2012, 11:15 p.m., Ryan Baxter wrote:
> > Ship It!
>
> Ryan Baxter wrote:
> Committed revision 1366425
Mike can you attach the patch to the JIRA? I should have checked this first before checking it in.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6155/#review9522
-----------------------------------------------------------
On July 26, 2012, 5:26 p.m., Mike May wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6155/
> -----------------------------------------------------------
>
> (Updated July 26, 2012, 5:26 p.m.)
>
>
> Review request for shindig and Ryan Baxter.
>
>
> Description
> -------
>
> The forms and the form elements in login.jsp and authorize.jsp do not have IDs.
>
>
> This addresses bug SHINDIG-1828.
> https://issues.apache.org/jira/browse/SHINDIG-1828
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/WEB-INF/authorize.jsp 1366029
> http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/login.jsp 1366029
>
> Diff: https://reviews.apache.org/r/6155/diff/
>
>
> Testing
> -------
>
> All tests pass.
>
>
> Thanks,
>
> Mike May
>
>
Re: Review Request: Adding IDs to form elements in login.jsp and
authorize.jsp
Posted by Ryan Baxter <rb...@gmail.com>.
> On July 26, 2012, 11:15 p.m., Ryan Baxter wrote:
> > Ship It!
>
> Ryan Baxter wrote:
> Committed revision 1366425
>
> Ryan Baxter wrote:
> Mike can you attach the patch to the JIRA? I should have checked this first before checking it in.
>
> Mike May wrote:
> Attached! My bad, thought I had already attached it.
Thanks please close the review
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6155/#review9522
-----------------------------------------------------------
On July 26, 2012, 5:26 p.m., Mike May wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6155/
> -----------------------------------------------------------
>
> (Updated July 26, 2012, 5:26 p.m.)
>
>
> Review request for shindig and Ryan Baxter.
>
>
> Description
> -------
>
> The forms and the form elements in login.jsp and authorize.jsp do not have IDs.
>
>
> This addresses bug SHINDIG-1828.
> https://issues.apache.org/jira/browse/SHINDIG-1828
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/WEB-INF/authorize.jsp 1366029
> http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/login.jsp 1366029
>
> Diff: https://reviews.apache.org/r/6155/diff/
>
>
> Testing
> -------
>
> All tests pass.
>
>
> Thanks,
>
> Mike May
>
>
Re: Review Request: Adding IDs to form elements in login.jsp and
authorize.jsp
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6155/#review9522
-----------------------------------------------------------
Ship it!
Ship It!
- Ryan Baxter
On July 26, 2012, 5:26 p.m., Mike May wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6155/
> -----------------------------------------------------------
>
> (Updated July 26, 2012, 5:26 p.m.)
>
>
> Review request for shindig and Ryan Baxter.
>
>
> Description
> -------
>
> The forms and the form elements in login.jsp and authorize.jsp do not have IDs.
>
>
> This addresses bug SHINDIG-1828.
> https://issues.apache.org/jira/browse/SHINDIG-1828
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/WEB-INF/authorize.jsp 1366029
> http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/login.jsp 1366029
>
> Diff: https://reviews.apache.org/r/6155/diff/
>
>
> Testing
> -------
>
> All tests pass.
>
>
> Thanks,
>
> Mike May
>
>
Re: Review Request: Adding IDs to form elements in login.jsp and
authorize.jsp
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6155/#review9530
-----------------------------------------------------------
Ship it!
Ship It!
- Stanton Sievers
On July 26, 2012, 5:26 p.m., Mike May wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6155/
> -----------------------------------------------------------
>
> (Updated July 26, 2012, 5:26 p.m.)
>
>
> Review request for shindig and Ryan Baxter.
>
>
> Description
> -------
>
> The forms and the form elements in login.jsp and authorize.jsp do not have IDs.
>
>
> This addresses bug SHINDIG-1828.
> https://issues.apache.org/jira/browse/SHINDIG-1828
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/WEB-INF/authorize.jsp 1366029
> http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/login.jsp 1366029
>
> Diff: https://reviews.apache.org/r/6155/diff/
>
>
> Testing
> -------
>
> All tests pass.
>
>
> Thanks,
>
> Mike May
>
>
Re: Review Request: Adding IDs to form elements in login.jsp and
authorize.jsp
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6155/#review9532
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Dumont
On July 26, 2012, 5:26 p.m., Mike May wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6155/
> -----------------------------------------------------------
>
> (Updated July 26, 2012, 5:26 p.m.)
>
>
> Review request for shindig and Ryan Baxter.
>
>
> Description
> -------
>
> The forms and the form elements in login.jsp and authorize.jsp do not have IDs.
>
>
> This addresses bug SHINDIG-1828.
> https://issues.apache.org/jira/browse/SHINDIG-1828
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/WEB-INF/authorize.jsp 1366029
> http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/login.jsp 1366029
>
> Diff: https://reviews.apache.org/r/6155/diff/
>
>
> Testing
> -------
>
> All tests pass.
>
>
> Thanks,
>
> Mike May
>
>