You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/10/01 17:17:22 UTC
[GitHub] [thrift] chrstphrchvz opened a new pull request #2249: Fix c_glib implicit function declarations
chrstphrchvz opened a new pull request #2249:
URL: https://github.com/apache/thrift/pull/2249
<!-- Explain the changes in the pull request below: -->
Using Xcode 12 on macOS 10.15, any implicit function declarations are now errors rather than warnings. Some of the implicit function declarations present in thrift 0.13.0 were already addressed in 0d6a2d3. This PR fixes the ones remaining:
* usage of `thrift_protocol_decorator_write_message_begin()` from thrift_multiplexed_protocol.c: https://github.com/apache/thrift/blob/b1a5cd6542f4591563d39ed2021be9fc4690528f/lib/c_glib/src/thrift/c_glib/protocol/thrift_multiplexed_protocol.c#L60
* usage of `thrift_ssl_socket_authorize()` before its definition in thrift_ssl_socket.c: https://github.com/apache/thrift/blob/c5b9d9e69e80f8243c34d763d7b8af1c3dacbc00/lib/c_glib/src/thrift/c_glib/transport/thrift_ssl_socket.c#L432
This PR declares each of those functions in already-included header files to avoid the implicit function declarations.
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [ ] ~~Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)~~
- [ ] ~~If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?~~
No existing ticket found for this issue.
- [x] Did you squash your changes to a single commit? (not required, but preferred)
- [x] Did you do your best to avoid breaking changes? ~~If one was needed, did you label the Jira ticket with "Breaking-Change"?~~
- [ ] ~~If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.~~
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G closed pull request #2249: Fix c_glib implicit function declarations
Posted by GitBox <gi...@apache.org>.
Jens-G closed pull request #2249:
URL: https://github.com/apache/thrift/pull/2249
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org