You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2022/02/08 23:59:28 UTC
[GitHub] [incubator-mxnet] guanxingithub opened a new pull request #20887: Resolve the conflict with PR#20499
guanxingithub opened a new pull request #20887:
URL: https://github.com/apache/incubator-mxnet/pull/20887
## Description ##
(Brief description on what this PR is about)
## Checklist ##
### Essentials ###
- [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage
- [ ] Code is well-documented
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] guanxingithub commented on pull request #20887: Resolve the conflict with PR#20499
Posted by GitBox <gi...@apache.org>.
guanxingithub commented on pull request #20887:
URL: https://github.com/apache/incubator-mxnet/pull/20887#issuecomment-1033991384
Add reviewers: @szha and @ptrendx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] guanxingithub removed a comment on pull request #20887: [BUGFIX] Make compile/use of nvmlDeviceGetComputeRunningProcesses()#20866
Posted by GitBox <gi...@apache.org>.
guanxingithub removed a comment on pull request #20887:
URL: https://github.com/apache/incubator-mxnet/pull/20887#issuecomment-1033991384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20887: Resolve the conflict with PR#20499
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20887:
URL: https://github.com/apache/incubator-mxnet/pull/20887#issuecomment-1033181491
Hey @guanxingithub , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [clang, miscellaneous, unix-cpu, windows-gpu, unix-gpu, windows-cpu, edge, website, sanity, centos-gpu, centos-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] guanxingithub edited a comment on pull request #20887: Resolve the conflict with PR#20499
Posted by GitBox <gi...@apache.org>.
guanxingithub edited a comment on pull request #20887:
URL: https://github.com/apache/incubator-mxnet/pull/20887#issuecomment-1033194030
Really appreciate your reviews, from @szha, @DickJC123 and @ptrendx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] guanxingithub commented on pull request #20887: Resolve the conflict with PR#20499
Posted by GitBox <gi...@apache.org>.
guanxingithub commented on pull request #20887:
URL: https://github.com/apache/incubator-mxnet/pull/20887#issuecomment-1033194030
This PR is filed to solve the issue reported in #20467 as well as #20863. For fixing this issue, the solutions are provided in #20499 and #20866 by @szha and @DickJC123 .
In this PR, we would like to merge these two solutions and find a general solution that avoids compilation errors no matter which signature of the nvmlDeviceGetComputeRunningProcesses() function is enabled in the code.
Really appreciate your reviews, from @szha, @DickJC123!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #20887: [BUGFIX] Improve compile/use of nvmlDeviceGetComputeRunningProcesses()
Posted by GitBox <gi...@apache.org>.
szha merged pull request #20887:
URL: https://github.com/apache/incubator-mxnet/pull/20887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org