You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/22 00:47:23 UTC

[GitHub] [arrow] kou commented on pull request #13407: ARROW-16869: [C++] Fix bundled abseil and homebrew formula

kou commented on PR #13407:
URL: https://github.com/apache/arrow/pull/13407#issuecomment-1162500923

   Sorry, I missed this in ARROW-14892.
   
   Could you try the following?
   
   ```diff
   diff --git a/dev/tasks/homebrew-formulae/apache-arrow.rb b/dev/tasks/homebrew-formulae/apache-arrow.rb
   index 94a1a67a1a..4908c22ed6 100644
   --- a/dev/tasks/homebrew-formulae/apache-arrow.rb
   +++ b/dev/tasks/homebrew-formulae/apache-arrow.rb
   @@ -89,6 +89,7 @@ class ApacheArrow < Formula
          -DARROW_WITH_UTF8PROC=ON
          -DARROW_WITH_ZLIB=ON
          -DARROW_WITH_ZSTD=ON
   +      -DCMAKE_CXX_STANDARD=17
          -DCMAKE_FIND_PACKAGE_PREFER_CONFIG=TRUE
          -DPython3_EXECUTABLE=#{Formula["python@3.9"].bin/"python3"}
        ]
   ```
   
   We need to align C++ version with Abseil because we use `absl::FormatTime()` in `gcsfs_internal.cc`: https://github.com/apache/arrow/blob/master/cpp/src/arrow/filesystem/gcsfs_internal.cc#L237


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org