You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by "Bill (GitHub)" <gi...@apache.org> on 2020/03/15 17:18:49 UTC

[GitHub] [geode] Bill opened pull request #4813: GEODE-7837: Java client support SNI proxying; config via system property

[GEODE-7837](https://issues.apache.org/jira/browse/GEODE-7837)

Second try at this PR—now with more automated testing! `ClientSNIAcceptanceTest.java` runs a Geode cluster in a Docker container w/ an SNI proxy (haproxy) in a container out front.

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [x] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?


[ Full content available at: https://github.com/apache/geode/pull/4813 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] Bill commented on issue #4813: GEODE-7837: Java client support SNI proxying; config via system property

Posted by "Bill (GitHub)" <gi...@apache.org>.

This branch has been merged into @upthewaterspout 's https://github.com/apache/geode/pull/4830

[ Full content available at: https://github.com/apache/geode/pull/4813 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] Bill commented on issue #4813: GEODE-7837: Java client support SNI proxying; config via system property

Posted by "Bill (GitHub)" <gi...@apache.org>.

that LGTM failure appears to be a false negative (or perhaps more accurately: a false positive.) I manually initiated a re-run just now.

[ Full content available at: https://github.com/apache/geode/pull/4813 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] Bill commented on issue #4813: GEODE-7837: Java client support SNI proxying; config via system property

Posted by "Bill (GitHub)" <gi...@apache.org>.

that LGTM failure appears to be a false negative. I manually initiated a re-run just now.

[ Full content available at: https://github.com/apache/geode/pull/4813 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] Bill closed pull request #4813: GEODE-7837: Java client support SNI proxying; config via system property

Posted by "Bill (GitHub)" <gi...@apache.org>.

[ pull request closed by Bill ]

[ Full content available at: https://github.com/apache/geode/pull/4813 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org