[GitHub] [arrow] drin commented on a diff in pull request #13932: MINOR: [C++] Fix StringFormatter type error in localfs_benchmark

[GitBox <gi...@apache.org>]

drin commented on code in PR #13932:
URL: https://github.com/apache/arrow/pull/13932#discussion_r951494625


##########
cpp/src/arrow/filesystem/localfs_benchmark.cc:
##########
@@ -66,7 +66,7 @@ class LocalFSFixture : public benchmark::Fixture {
                                   arrow::internal::PlatformFilename cur_root_dir) {
     ASSERT_OK(arrow::internal::CreateDir(cur_root_dir));
 
-    arrow::internal::StringFormatter<Int32Type> format;
+    arrow::internal::StringFormatter<DoubleType> format;

Review Comment:
   oh, yeah I did mean `Int64Type`.
   
   I can also try running with either StringFormatter or stringstream and if the difference isn't significant I can switch to stringstream?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org