You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/07/21 08:14:14 UTC
[GitHub] [incubator-uniffle] kaijchen opened a new pull request, #63: [TEST] Add more unit tests in rss-common
kaijchen opened a new pull request, #63:
URL: https://github.com/apache/incubator-uniffle/pull/63
### What changes were proposed in this pull request?
Add more unit tests in rss-common.
### Why are the changes needed?
Improve coverage.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
By CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #63: [TEST] Add more unit tests in rss-common
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #63:
URL: https://github.com/apache/incubator-uniffle/pull/63#issuecomment-1191223295
# [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/63?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#63](https://codecov.io/gh/apache/incubator-uniffle/pull/63?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (10d051d) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/bdffcaa58b514f22f2f2da72c8e791cef4ac00f3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bdffcaa) will **increase** coverage by `1.26%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #63 +/- ##
============================================
+ Coverage 55.15% 56.41% +1.26%
- Complexity 1112 1173 +61
============================================
Files 149 149
Lines 7969 7968 -1
Branches 761 761
============================================
+ Hits 4395 4495 +100
+ Misses 3332 3231 -101
Partials 242 242
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-uniffle/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...he/uniffle/client/impl/ShuffleWriteClientImpl.java](https://codecov.io/gh/apache/incubator-uniffle/pull/63/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NsaWVudC9pbXBsL1NodWZmbGVXcml0ZUNsaWVudEltcGwuamF2YQ==) | `26.05% <0.00%> (+0.09%)` | :arrow_up: |
| [.../java/org/apache/uniffle/common/BufferSegment.java](https://codecov.io/gh/apache/incubator-uniffle/pull/63/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9CdWZmZXJTZWdtZW50LmphdmE=) | `100.00% <0.00%> (+3.84%)` | :arrow_up: |
| [.../org/apache/uniffle/common/ShuffleIndexResult.java](https://codecov.io/gh/apache/incubator-uniffle/pull/63/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9TaHVmZmxlSW5kZXhSZXN1bHQuamF2YQ==) | `100.00% <0.00%> (+14.28%)` | :arrow_up: |
| [...apache/uniffle/common/ShufflePartitionedBlock.java](https://codecov.io/gh/apache/incubator-uniffle/pull/63/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9TaHVmZmxlUGFydGl0aW9uZWRCbG9jay5qYXZh) | `70.58% <0.00%> (+35.29%)` | :arrow_up: |
| [...ava/org/apache/uniffle/common/RssShuffleUtils.java](https://codecov.io/gh/apache/incubator-uniffle/pull/63/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9Sc3NTaHVmZmxlVXRpbHMuamF2YQ==) | `93.33% <0.00%> (+46.66%)` | :arrow_up: |
| [...a/org/apache/uniffle/common/ShuffleDataResult.java](https://codecov.io/gh/apache/incubator-uniffle/pull/63/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9TaHVmZmxlRGF0YVJlc3VsdC5qYXZh) | `81.81% <0.00%> (+81.81%)` | :arrow_up: |
| [.../apache/uniffle/common/ShufflePartitionedData.java](https://codecov.io/gh/apache/incubator-uniffle/pull/63/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9TaHVmZmxlUGFydGl0aW9uZWREYXRhLmphdmE=) | `81.81% <0.00%> (+81.81%)` | :arrow_up: |
| [...va/org/apache/uniffle/common/ShuffleBlockInfo.java](https://codecov.io/gh/apache/incubator-uniffle/pull/63/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9TaHVmZmxlQmxvY2tJbmZvLmphdmE=) | `87.17% <0.00%> (+87.17%)` | :arrow_up: |
| [...a/org/apache/uniffle/common/ShuffleServerInfo.java](https://codecov.io/gh/apache/incubator-uniffle/pull/63/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9TaHVmZmxlU2VydmVySW5mby5qYXZh) | `100.00% <0.00%> (+100.00%)` | :arrow_up: |
| [...org/apache/uniffle/common/ShuffleRegisterInfo.java](https://codecov.io/gh/apache/incubator-uniffle/pull/63/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9TaHVmZmxlUmVnaXN0ZXJJbmZvLmphdmE=) | `100.00% <0.00%> (+100.00%)` | :arrow_up: |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on pull request #63: [TEST] Add more unit tests in rss-common
Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #63:
URL: https://github.com/apache/incubator-uniffle/pull/63#issuecomment-1191226912
Thanks @jerqi for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi merged pull request #63: [TEST] Add more unit tests in rss-common
Posted by GitBox <gi...@apache.org>.
jerqi merged PR #63:
URL: https://github.com/apache/incubator-uniffle/pull/63
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org