You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "gong (via GitHub)" <gi...@apache.org> on 2023/03/14 08:32:33 UTC
[GitHub] [inlong] gong opened a new pull request, #7606: [INLONG-7595][Sort] Mongo read phase metrics need to update when no incremental data
gong opened a new pull request, #7606:
URL: https://github.com/apache/inlong/pull/7606
### Prepare a Pull Request
- [INLONG-7595][Sort] Mongo read phase metrics need to update when no incremental data
- Fixes #7595
### Motivation
* Mongo read phase metrics need to update when no incremental data
### Modifications
* `DebeziumDeserializationSchema` add overload `deserialize` for jugde read phase
* `DebeziumSourceFunction` fix error logic for get read phase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #7606: [INLONG-7595][Sort] Mongo read phase metrics need to update when no incremental data
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #7606:
URL: https://github.com/apache/inlong/pull/7606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] EMsnap commented on a diff in pull request #7606: [INLONG-7595][Sort] Mongo read phase metrics need to update when no incremental data
Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap commented on code in PR #7606:
URL: https://github.com/apache/inlong/pull/7606#discussion_r1135252739
##########
inlong-sort/sort-connectors/mongodb-cdc/src/main/java/org/apache/inlong/sort/cdc/mongodb/debezium/table/MongoDBConnectorDeserializationSchema.java:
##########
@@ -222,6 +222,18 @@ public void deserialize(SourceRecord record, Collector<RowData> out) throws Exce
}
}
+ /**
+ * Deserialize the Debezium record, it is represented in Kafka {@link SourceRecord}.
+ *
+ * @param record
Review Comment:
pls add parameter description or just remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] e-mhui commented on pull request #7606: [INLONG-7595][Sort] Mongo read phase metrics need to update when no incremental data
Posted by "e-mhui (via GitHub)" <gi...@apache.org>.
e-mhui commented on PR #7606:
URL: https://github.com/apache/inlong/pull/7606#issuecomment-1467653263
> @emhui Please help review it.
Ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gong commented on pull request #7606: [INLONG-7595][Sort] Mongo read phase metrics need to update when no incremental data
Posted by "gong (via GitHub)" <gi...@apache.org>.
gong commented on PR #7606:
URL: https://github.com/apache/inlong/pull/7606#issuecomment-1467637743
@emhui Please help review it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gong commented on a diff in pull request #7606: [INLONG-7595][Sort] Mongo read phase metrics need to update when no incremental data
Posted by "gong (via GitHub)" <gi...@apache.org>.
gong commented on code in PR #7606:
URL: https://github.com/apache/inlong/pull/7606#discussion_r1135283579
##########
inlong-sort/sort-connectors/mongodb-cdc/src/main/java/org/apache/inlong/sort/cdc/mongodb/debezium/table/MongoDBConnectorDeserializationSchema.java:
##########
@@ -222,6 +222,18 @@ public void deserialize(SourceRecord record, Collector<RowData> out) throws Exce
}
}
+ /**
+ * Deserialize the Debezium record, it is represented in Kafka {@link SourceRecord}.
+ *
+ * @param record
Review Comment:
I remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #7606: [INLONG-7595][Sort] Mongo read phase metrics need to update when no incremental data
Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #7606:
URL: https://github.com/apache/inlong/pull/7606#discussion_r1135364558
##########
inlong-sort/sort-connectors/mongodb-cdc/src/main/java/org/apache/inlong/sort/cdc/mongodb/DebeziumSourceFunction.java:
##########
@@ -499,19 +502,38 @@ public void run(SourceContext<T> sourceContext) throws Exception {
sourceContext,
new DebeziumDeserializationSchema<T>() {
+ /**
+ * Deserialize the Debezium record, it is represented in Kafka {@link SourceRecord}.
+ *
+ * @param record
Review Comment:
Please remove those blank tags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org