You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2014/12/03 20:57:41 UTC

Review Request 28673: Introduce libevent socket.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28673/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Niklas Nielsen.


Bugs: MESOS-1911
    https://issues.apache.org/jira/browse/MESOS-1911


Repository: mesos-git


Description
-------

Introduce libevent socket.


Diffs
-----

  3rdparty/libprocess/configure.ac 314c8b842d07e1344659449866f7e85c48854204 
  3rdparty/libprocess/src/libevent_socket.cpp PRE-CREATION 
  3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3 
  3rdparty/libprocess/src/socket.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/28673/diff/


Testing
-------


Thanks,

Joris Van Remoortere

Re: Review Request 28673: Introduce libevent socket.

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28673/
-----------------------------------------------------------

(Updated Dec. 19, 2014, 12:30 a.m.)


Review request for mesos, Benjamin Hindman and Niklas Nielsen.


Changes
-------

Rebase.
Change CHECKs in socket interface implementation to return failure / error instead.


Bugs: MESOS-1911
    https://issues.apache.org/jira/browse/MESOS-1911


Repository: mesos-git


Description
-------

Introduce libevent socket.


Diffs (updated)
-----

  3rdparty/libprocess/configure.ac 024f892106cf921d1559ecf59c81fde6a4baaa41 
  3rdparty/libprocess/src/libevent_socket.cpp PRE-CREATION 
  3rdparty/libprocess/src/socket.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/28673/diff/


Testing
-------


Thanks,

Joris Van Remoortere

Re: Review Request 28673: Introduce libevent socket.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28673/#review63746
-----------------------------------------------------------


Bad patch!

Reviews applied: [28314, 28315]

Failed command: ./support/apply-review.sh -n -r 28315

Error:
 2014-12-03 21:35:46 URL:https://reviews.apache.org/r/28315/diff/raw/ [14037/14037] -> "28315.patch" [1]
error: patch failed: 3rdparty/libprocess/src/process.cpp:574
error: 3rdparty/libprocess/src/process.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Dec. 3, 2014, 8:19 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28673/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2014, 8:19 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
> 
> 
> Bugs: MESOS-1911
>     https://issues.apache.org/jira/browse/MESOS-1911
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Introduce libevent socket.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/configure.ac 314c8b842d07e1344659449866f7e85c48854204 
>   3rdparty/libprocess/src/libevent_socket.cpp PRE-CREATION 
>   3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3 
>   3rdparty/libprocess/src/socket.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28673/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 28673: Introduce libevent socket.

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28673/
-----------------------------------------------------------

(Updated Dec. 3, 2014, 8:19 p.m.)


Review request for mesos, Benjamin Hindman and Niklas Nielsen.


Changes
-------

Rebase.


Bugs: MESOS-1911
    https://issues.apache.org/jira/browse/MESOS-1911


Repository: mesos-git


Description
-------

Introduce libevent socket.


Diffs (updated)
-----

  3rdparty/libprocess/configure.ac 314c8b842d07e1344659449866f7e85c48854204 
  3rdparty/libprocess/src/libevent_socket.cpp PRE-CREATION 
  3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3 
  3rdparty/libprocess/src/socket.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/28673/diff/


Testing
-------


Thanks,

Joris Van Remoortere