You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Kristian Waagan (JIRA)" <ji...@apache.org> on 2007/10/25 11:03:50 UTC
[jira] Created: (DERBY-3149) Add ant targets for building and
running the package private tests against the classes directories
Add ant targets for building and running the package private tests against the classes directories
--------------------------------------------------------------------------------------------------
Key: DERBY-3149
URL: https://issues.apache.org/jira/browse/DERBY-3149
Project: Derby
Issue Type: Sub-task
Components: Build tools, Test
Affects Versions: 10.4.0.0
Reporter: Kristian Waagan
Assignee: Kristian Waagan
Priority: Minor
Fix For: 10.4.0.0
Create ant targets in build.xml to compile and run the package private tests.
The first step will be to run the tests against the classes directories. Implementing a solution that runs against jars is not technically difficult, it just brings a host of decisions to be taken... Maybe even more important, does running against the jars add any value?
The compile will be included in the 'all' target to test the implementation. Feel free to post your concerns if you think building the package private tests should be a manual action only.
The tests will also be run as part of junit-all / junitreport.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3149) Add ant targets for building and
running the package private tests against the classes directories
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557046#action_12557046 ]
Kristian Waagan commented on DERBY-3149:
----------------------------------------
Kathey,
As far as I have understood, based on assumptions and bits of info here and there, the automagic property setter will not change j14lib and j15lib if they are specified in ant.properties.
However, it will still set java15compile.classpath based on j15lib.
I guess we should go back and check if the case with dontAutosetProps=true is documented properly, and if it is really needed at all? If it ignores already set variables, isn't that good enough?
Why would you need to explicitly disable it if it ignores already set variables?
> Add ant targets for building and running the package private tests against the classes directories
> --------------------------------------------------------------------------------------------------
>
> Key: DERBY-3149
> URL: https://issues.apache.org/jira/browse/DERBY-3149
> Project: Derby
> Issue Type: Sub-task
> Components: Build tools, Test
> Affects Versions: 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3149-1a.diff, derby-3149-1a.stat, derby-3149-1b.diff, derby-3149-2a-conditional_compilation_fix.diff, derby-3149-2b-conditional_compilation_fix.diff, derby-3149-4a-compile_against_15_libraries.diff, pptesting_use_jdk16_executable_diff.txt
>
>
> Create ant targets in build.xml to compile and run the package private tests.
> The first step will be to run the tests against the classes directories. Implementing a solution that runs against jars is not technically difficult, it just brings a host of decisions to be taken... Maybe even more important, does running against the jars add any value?
> The compile will be included in the 'all' target to test the implementation. Feel free to post your concerns if you think building the package private tests should be a manual action only.
> The tests will also be run as part of junit-all / junitreport.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (DERBY-3149) Add ant targets for building and
running the package private tests against the classes directories
Posted by "Dag H. Wanvik" <Da...@Sun.COM>.
"Kristian Waagan (JIRA)" <ji...@apache.org> writes:
> [ https://issues.apache.org/jira/browse/DERBY-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Kristian Waagan updated DERBY-3149:
> -----------------------------------
>
> Derby Info: (was: [Patch Available])
>
> Committed 'derby-3149-1b.diff' to trunk with revision 593571.
The patch seems to compile some files every time, even if already
compiled. Is that intentional?
:
compile:
[javac] Compiling 7 source files to /export/home/tmp/derby/sb/sb1/classes.pptesting
pptesting-build:
[echo] Package private tests build completed.
Dag
[jira] Updated: (DERBY-3149) Add ant targets for building and
running the package private tests against the classes directories
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-3149:
-----------------------------------
Derby Info: (was: [Patch Available])
Committed 'derby-3149-1b.diff' to trunk with revision 593571.
I'm not marked the issue as resolved yet, because there are a few things that must be cleaned-up, and it would also be nice if someone tested the targets ('pptesting', 'junit-pptesting').
Targets are now dependent on Java SE 6, which they don't have to be. This is because I couldn't find a compile classpath for Java SE 5.0. Maybe this has already been introduced?
> Add ant targets for building and running the package private tests against the classes directories
> --------------------------------------------------------------------------------------------------
>
> Key: DERBY-3149
> URL: https://issues.apache.org/jira/browse/DERBY-3149
> Project: Derby
> Issue Type: Sub-task
> Components: Build tools, Test
> Affects Versions: 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3149-1a.diff, derby-3149-1a.stat, derby-3149-1b.diff
>
>
> Create ant targets in build.xml to compile and run the package private tests.
> The first step will be to run the tests against the classes directories. Implementing a solution that runs against jars is not technically difficult, it just brings a host of decisions to be taken... Maybe even more important, does running against the jars add any value?
> The compile will be included in the 'all' target to test the implementation. Feel free to post your concerns if you think building the package private tests should be a manual action only.
> The tests will also be run as part of junit-all / junitreport.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3149) Add ant targets for building and
running the package private tests against the classes directories
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542205 ]
Dag H. Wanvik commented on DERBY-3149:
--------------------------------------
I looked at the patch, it works for me! Thanks, Kristian.
One small note; I would omit the echo in the task :
java/testing/org/apache/derby/build.xml#pptesting-build
since silence is the default elsewhere.
Making "debug" always true makes sense here,
but is there a compelling reason to not use the prevailing pattern
of expanding ${debug}? If sounds equally reasonable for all testing code?
+1
> Add ant targets for building and running the package private tests against the classes directories
> --------------------------------------------------------------------------------------------------
>
> Key: DERBY-3149
> URL: https://issues.apache.org/jira/browse/DERBY-3149
> Project: Derby
> Issue Type: Sub-task
> Components: Build tools, Test
> Affects Versions: 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3149-1a.diff, derby-3149-1a.stat, derby-3149-1b.diff, derby-3149-2a-conditional_compilation_fix.diff
>
>
> Create ant targets in build.xml to compile and run the package private tests.
> The first step will be to run the tests against the classes directories. Implementing a solution that runs against jars is not technically difficult, it just brings a host of decisions to be taken... Maybe even more important, does running against the jars add any value?
> The compile will be included in the 'all' target to test the implementation. Feel free to post your concerns if you think building the package private tests should be a manual action only.
> The tests will also be run as part of junit-all / junitreport.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3149) Add ant targets for building and
running the package private tests against the classes directories
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-3149:
-----------------------------------
Attachment: derby-3149-1a.stat
derby-3149-1a.diff
'derby-3149-1a.diff' implements the targets 'pptesting' and 'junit-pptesting'. The former compiles the package private test, the latter runs them against the classes directories.
A new directory has been added; classes.pptesting.
The is to avoid that package private test classes are included in any of the jars, and it might be beneficial for later extensions (i.e. package the tests in multiple separate testing jars, merge with the other jars etc).
Note that because I couldn't find any compile classpath for Java SE 5.0, I used the one for Java SE 6. This means that you must have specified the property jdk16 in your ant.properties file to compile the tests.
Patch ready for review.
> Add ant targets for building and running the package private tests against the classes directories
> --------------------------------------------------------------------------------------------------
>
> Key: DERBY-3149
> URL: https://issues.apache.org/jira/browse/DERBY-3149
> Project: Derby
> Issue Type: Sub-task
> Components: Build tools, Test
> Affects Versions: 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3149-1a.diff, derby-3149-1a.stat
>
>
> Create ant targets in build.xml to compile and run the package private tests.
> The first step will be to run the tests against the classes directories. Implementing a solution that runs against jars is not technically difficult, it just brings a host of decisions to be taken... Maybe even more important, does running against the jars add any value?
> The compile will be included in the 'all' target to test the implementation. Feel free to post your concerns if you think building the package private tests should be a manual action only.
> The tests will also be run as part of junit-all / junitreport.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3149) Add ant targets for building and
running the package private tests against the classes directories
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-3149:
-----------------------------------
Attachment: derby-3149-2b-conditional_compilation_fix.diff
'derby-3149-2b-conditional_compilation_fix.diff' is equal to version 2a except that the echo-message is removed.
Committed to trunk with revision 594809.
I'm still awaiting the commit of another patch to replace the Java SE 6 compile classpath with that of Java SE 5.0.
> Add ant targets for building and running the package private tests against the classes directories
> --------------------------------------------------------------------------------------------------
>
> Key: DERBY-3149
> URL: https://issues.apache.org/jira/browse/DERBY-3149
> Project: Derby
> Issue Type: Sub-task
> Components: Build tools, Test
> Affects Versions: 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3149-1a.diff, derby-3149-1a.stat, derby-3149-1b.diff, derby-3149-2a-conditional_compilation_fix.diff, derby-3149-2b-conditional_compilation_fix.diff
>
>
> Create ant targets in build.xml to compile and run the package private tests.
> The first step will be to run the tests against the classes directories. Implementing a solution that runs against jars is not technically difficult, it just brings a host of decisions to be taken... Maybe even more important, does running against the jars add any value?
> The compile will be included in the 'all' target to test the implementation. Feel free to post your concerns if you think building the package private tests should be a manual action only.
> The tests will also be run as part of junit-all / junitreport.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3149) Add ant targets for building and
running the package private tests against the classes directories
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543844 ]
Kristian Waagan commented on DERBY-3149:
----------------------------------------
Fixed invalid @link tag in the PackagePrivateTestSuite JavaDoc with revision 596598.
> Add ant targets for building and running the package private tests against the classes directories
> --------------------------------------------------------------------------------------------------
>
> Key: DERBY-3149
> URL: https://issues.apache.org/jira/browse/DERBY-3149
> Project: Derby
> Issue Type: Sub-task
> Components: Build tools, Test
> Affects Versions: 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3149-1a.diff, derby-3149-1a.stat, derby-3149-1b.diff, derby-3149-2a-conditional_compilation_fix.diff, derby-3149-2b-conditional_compilation_fix.diff
>
>
> Create ant targets in build.xml to compile and run the package private tests.
> The first step will be to run the tests against the classes directories. Implementing a solution that runs against jars is not technically difficult, it just brings a host of decisions to be taken... Maybe even more important, does running against the jars add any value?
> The compile will be included in the 'all' target to test the implementation. Feel free to post your concerns if you think building the package private tests should be a manual action only.
> The tests will also be run as part of junit-all / junitreport.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3149) Add ant targets for building and
running the package private tests against the classes directories
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542213 ]
Kristian Waagan commented on DERBY-3149:
----------------------------------------
Thank for looking at the second patch Dag.
I'll remove the message stating that the build is complete.
Not quite convinced about the debug-comment though. I don't see any reason not to compile with debug=true when it comes to test code, if something fails (expected or unexpected) in a test I would like to get as much information as possible. When I do a find-grep for debug="true", I get 44 matches. All except one are in the java/testing directory.
I heartily agree with you on expanding ${debug} in non-testing code, but I need more convincing to change it in the targets compiling the testing code :)
> Add ant targets for building and running the package private tests against the classes directories
> --------------------------------------------------------------------------------------------------
>
> Key: DERBY-3149
> URL: https://issues.apache.org/jira/browse/DERBY-3149
> Project: Derby
> Issue Type: Sub-task
> Components: Build tools, Test
> Affects Versions: 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3149-1a.diff, derby-3149-1a.stat, derby-3149-1b.diff, derby-3149-2a-conditional_compilation_fix.diff
>
>
> Create ant targets in build.xml to compile and run the package private tests.
> The first step will be to run the tests against the classes directories. Implementing a solution that runs against jars is not technically difficult, it just brings a host of decisions to be taken... Maybe even more important, does running against the jars add any value?
> The compile will be included in the 'all' target to test the implementation. Feel free to post your concerns if you think building the package private tests should be a manual action only.
> The tests will also be run as part of junit-all / junitreport.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3149) Add ant targets for building and
running the package private tests against the classes directories
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-3149:
-----------------------------------
Attachment: derby-3149-2a-conditional_compilation_fix.diff
Dag H. Wanvik commented on derby-dev:
"The patch seems to compile some files every time, even if already
compiled. Is that intentional?"
No this was not intentional.
I had a look at it, and it turned out I had specified the wrong path for the srcdir attribute in the javac ant target. Ant expects the srcdir and destdir hierarchies to be the same. These properties are used to determine which files have to be compiled based on their timestamps.
Second, I decided to tell javac to compile all *java files in the tree, even though it could have been enough with just compiling the top-level file (PackagePrivateTestSuite). However, when this is done only the timestamp of that single file is checked, and the target would not recompile other changed files as long as PackagePrivateTestSuite remained unchanged.
I have uploaded 'derby-3149-2a-conditional_compilation_fix.diff' to fix these issues, and also chose to always compile with debug=true, added some comments and removed all references to 'derby.pptesting.src.dir'.
Note that the compilation classpath still have to be fixed/replaced before the issue is closed.
Dag, thanks for testing the patch :)
> Add ant targets for building and running the package private tests against the classes directories
> --------------------------------------------------------------------------------------------------
>
> Key: DERBY-3149
> URL: https://issues.apache.org/jira/browse/DERBY-3149
> Project: Derby
> Issue Type: Sub-task
> Components: Build tools, Test
> Affects Versions: 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3149-1a.diff, derby-3149-1a.stat, derby-3149-1b.diff, derby-3149-2a-conditional_compilation_fix.diff
>
>
> Create ant targets in build.xml to compile and run the package private tests.
> The first step will be to run the tests against the classes directories. Implementing a solution that runs against jars is not technically difficult, it just brings a host of decisions to be taken... Maybe even more important, does running against the jars add any value?
> The compile will be included in the 'all' target to test the implementation. Feel free to post your concerns if you think building the package private tests should be a manual action only.
> The tests will also be run as part of junit-all / junitreport.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3149) Add ant targets for building and
running the package private tests against the classes directories
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12555876#action_12555876 ]
Kristian Waagan commented on DERBY-3149:
----------------------------------------
Is there already a variable for Java SE 5.0 compile classpath in the build script(s)?
If not, are there any plans to introduce one?
I see there is a java15compile.classpath in the root build.xml, but as far as I can tell, it is only set when using the new "autoprop" feature and I haven't found any targets using it yet.
I see that many targets are using compile.classpath. This is currently set to java14compile.classpath, and changing it would probably be a bad idea.
Last, I see that we require J2SE 5.0 or higher in BUILDING.txt. Don't we need a variable for this "default" compile classpath?
In my case I'm using J2SE 5.0 features in some tests, and I would like these tests to be built when JDK 1.5 is available. Currently they are only built if JDK 1.6 is available.
> Add ant targets for building and running the package private tests against the classes directories
> --------------------------------------------------------------------------------------------------
>
> Key: DERBY-3149
> URL: https://issues.apache.org/jira/browse/DERBY-3149
> Project: Derby
> Issue Type: Sub-task
> Components: Build tools, Test
> Affects Versions: 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3149-1a.diff, derby-3149-1a.stat, derby-3149-1b.diff, derby-3149-2a-conditional_compilation_fix.diff, derby-3149-2b-conditional_compilation_fix.diff
>
>
> Create ant targets in build.xml to compile and run the package private tests.
> The first step will be to run the tests against the classes directories. Implementing a solution that runs against jars is not technically difficult, it just brings a host of decisions to be taken... Maybe even more important, does running against the jars add any value?
> The compile will be included in the 'all' target to test the implementation. Feel free to post your concerns if you think building the package private tests should be a manual action only.
> The tests will also be run as part of junit-all / junitreport.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-3149) Add ant targets for building and
running the package private tests against the classes directories
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan closed DERBY-3149.
----------------------------------
Closing the issue.
More work needs to be done to support running the package-private tests with jars, but that belongs under a separate issue.
> Add ant targets for building and running the package private tests against the classes directories
> --------------------------------------------------------------------------------------------------
>
> Key: DERBY-3149
> URL: https://issues.apache.org/jira/browse/DERBY-3149
> Project: Derby
> Issue Type: Sub-task
> Components: Build tools, Test
> Affects Versions: 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3149-1a.diff, derby-3149-1a.stat, derby-3149-1b.diff, derby-3149-2a-conditional_compilation_fix.diff, derby-3149-2b-conditional_compilation_fix.diff, derby-3149-4a-compile_against_15_libraries.diff, pptesting_use_jdk16_executable_diff.txt
>
>
> Create ant targets in build.xml to compile and run the package private tests.
> The first step will be to run the tests against the classes directories. Implementing a solution that runs against jars is not technically difficult, it just brings a host of decisions to be taken... Maybe even more important, does running against the jars add any value?
> The compile will be included in the 'all' target to test the implementation. Feel free to post your concerns if you think building the package private tests should be a manual action only.
> The tests will also be run as part of junit-all / junitreport.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3149) Add ant targets for building and
running the package private tests against the classes directories
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544480 ]
Kristian Waagan commented on DERBY-3149:
----------------------------------------
Thank you for reminding me about updating the wiki, Olav!
I have updated http://wiki.apache.org/db-derby/DerbyTopLevelJunitTests.
I chose not to update http://wiki.apache.org/db-derby/DerbyJUnitTesting, as I expect there will be several changes regarding running the package private tests in the future. They are also pretty new, so things might change quite a bit.
> Add ant targets for building and running the package private tests against the classes directories
> --------------------------------------------------------------------------------------------------
>
> Key: DERBY-3149
> URL: https://issues.apache.org/jira/browse/DERBY-3149
> Project: Derby
> Issue Type: Sub-task
> Components: Build tools, Test
> Affects Versions: 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3149-1a.diff, derby-3149-1a.stat, derby-3149-1b.diff, derby-3149-2a-conditional_compilation_fix.diff, derby-3149-2b-conditional_compilation_fix.diff
>
>
> Create ant targets in build.xml to compile and run the package private tests.
> The first step will be to run the tests against the classes directories. Implementing a solution that runs against jars is not technically difficult, it just brings a host of decisions to be taken... Maybe even more important, does running against the jars add any value?
> The compile will be included in the 'all' target to test the implementation. Feel free to post your concerns if you think building the package private tests should be a manual action only.
> The tests will also be run as part of junit-all / junitreport.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3149) Add ant targets for building and
running the package private tests against the classes directories
Posted by "Olav Sandstaa (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543890 ]
Olav Sandstaa commented on DERBY-3149:
--------------------------------------
One question about the ant junit-pptesting target: why do we have to include junit.jar explicitly in the CLASSPATH in order for this target to find junit.jar while the ant pptesting target is able to locate the junit.jar in the tools/java directory? Couldn't also the junit-pptesting target use the tools/java/junit.jar file?
> Add ant targets for building and running the package private tests against the classes directories
> --------------------------------------------------------------------------------------------------
>
> Key: DERBY-3149
> URL: https://issues.apache.org/jira/browse/DERBY-3149
> Project: Derby
> Issue Type: Sub-task
> Components: Build tools, Test
> Affects Versions: 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3149-1a.diff, derby-3149-1a.stat, derby-3149-1b.diff, derby-3149-2a-conditional_compilation_fix.diff, derby-3149-2b-conditional_compilation_fix.diff
>
>
> Create ant targets in build.xml to compile and run the package private tests.
> The first step will be to run the tests against the classes directories. Implementing a solution that runs against jars is not technically difficult, it just brings a host of decisions to be taken... Maybe even more important, does running against the jars add any value?
> The compile will be included in the 'all' target to test the implementation. Feel free to post your concerns if you think building the package private tests should be a manual action only.
> The tests will also be run as part of junit-all / junitreport.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3149) Add ant targets for building and
running the package private tests against the classes directories
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12556982#action_12556982 ]
Kathey Marsden commented on DERBY-3149:
---------------------------------------
Building with IBM 1.5 and dontAutosetProps=true in my ant.properties I get:
compile:
[mkdir] Created dir: C:\svn2\trunk\classes.pptesting
[javac] Compiling 8 source files to C:\svn2\trunk\classes.pptesting
[javac] Fatal Error: Unable to find package java.lang in classpath or bootclasspath
BUILD FAILED
I assume since I am not using the autoprops I need to set ${java15compile.classpath} manually in my ant.properties. This should be spelled out in BUILDING.txt I think when the change goes in.
> Add ant targets for building and running the package private tests against the classes directories
> --------------------------------------------------------------------------------------------------
>
> Key: DERBY-3149
> URL: https://issues.apache.org/jira/browse/DERBY-3149
> Project: Derby
> Issue Type: Sub-task
> Components: Build tools, Test
> Affects Versions: 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3149-1a.diff, derby-3149-1a.stat, derby-3149-1b.diff, derby-3149-2a-conditional_compilation_fix.diff, derby-3149-2b-conditional_compilation_fix.diff, derby-3149-4a-compile_against_15_libraries.diff, pptesting_use_jdk16_executable_diff.txt
>
>
> Create ant targets in build.xml to compile and run the package private tests.
> The first step will be to run the tests against the classes directories. Implementing a solution that runs against jars is not technically difficult, it just brings a host of decisions to be taken... Maybe even more important, does running against the jars add any value?
> The compile will be included in the 'all' target to test the implementation. Feel free to post your concerns if you think building the package private tests should be a manual action only.
> The tests will also be run as part of junit-all / junitreport.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3149) Add ant targets for building and
running the package private tests against the classes directories
Posted by "Olav Sandstaa (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543860 ]
Olav Sandstaa commented on DERBY-3149:
--------------------------------------
I have tested the two new ant targets and they worked fine for me. The only suggestion I have is that it could be a good idea to update the following wiki pages with information about the new ant targets and the new test suite:
http://wiki.apache.org/db-derby/DerbyTopLevelJunitTests
http://wiki.apache.org/db-derby/DerbyJUnitTesting
> Add ant targets for building and running the package private tests against the classes directories
> --------------------------------------------------------------------------------------------------
>
> Key: DERBY-3149
> URL: https://issues.apache.org/jira/browse/DERBY-3149
> Project: Derby
> Issue Type: Sub-task
> Components: Build tools, Test
> Affects Versions: 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3149-1a.diff, derby-3149-1a.stat, derby-3149-1b.diff, derby-3149-2a-conditional_compilation_fix.diff, derby-3149-2b-conditional_compilation_fix.diff
>
>
> Create ant targets in build.xml to compile and run the package private tests.
> The first step will be to run the tests against the classes directories. Implementing a solution that runs against jars is not technically difficult, it just brings a host of decisions to be taken... Maybe even more important, does running against the jars add any value?
> The compile will be included in the 'all' target to test the implementation. Feel free to post your concerns if you think building the package private tests should be a manual action only.
> The tests will also be run as part of junit-all / junitreport.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3149) Add ant targets for building and
running the package private tests against the classes directories
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12556746#action_12556746 ]
Kristian Waagan commented on DERBY-3149:
----------------------------------------
Kathey,
I do not mind the change you have proposed, I just want to make clear that what the target really needs is to compile against the Java SE 5.0 libraries. There is no need for JDK 1.6, but as far as I know there is no java15compile.classpath, and compile.classpath is set to J2SE 1.4.2.
+1 to commit, unless someone knows how to get Java SE 5.0 libraries. If committed, I assume the target will revert back to Java SE 5.0 when the "infrastructure" is in place.
> Add ant targets for building and running the package private tests against the classes directories
> --------------------------------------------------------------------------------------------------
>
> Key: DERBY-3149
> URL: https://issues.apache.org/jira/browse/DERBY-3149
> Project: Derby
> Issue Type: Sub-task
> Components: Build tools, Test
> Affects Versions: 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3149-1a.diff, derby-3149-1a.stat, derby-3149-1b.diff, derby-3149-2a-conditional_compilation_fix.diff, derby-3149-2b-conditional_compilation_fix.diff, pptesting_use_jdk16_executable_diff.txt
>
>
> Create ant targets in build.xml to compile and run the package private tests.
> The first step will be to run the tests against the classes directories. Implementing a solution that runs against jars is not technically difficult, it just brings a host of decisions to be taken... Maybe even more important, does running against the jars add any value?
> The compile will be included in the 'all' target to test the implementation. Feel free to post your concerns if you think building the package private tests should be a manual action only.
> The tests will also be run as part of junit-all / junitreport.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3149) Add ant targets for building and
running the package private tests against the classes directories
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557050#action_12557050 ]
Kathey Marsden commented on DERBY-3149:
---------------------------------------
As long as I set j15lib I don't need to set dontSetAutoProps and pptesting builds ok.
> Add ant targets for building and running the package private tests against the classes directories
> --------------------------------------------------------------------------------------------------
>
> Key: DERBY-3149
> URL: https://issues.apache.org/jira/browse/DERBY-3149
> Project: Derby
> Issue Type: Sub-task
> Components: Build tools, Test
> Affects Versions: 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3149-1a.diff, derby-3149-1a.stat, derby-3149-1b.diff, derby-3149-2a-conditional_compilation_fix.diff, derby-3149-2b-conditional_compilation_fix.diff, derby-3149-4a-compile_against_15_libraries.diff, pptesting_use_jdk16_executable_diff.txt
>
>
> Create ant targets in build.xml to compile and run the package private tests.
> The first step will be to run the tests against the classes directories. Implementing a solution that runs against jars is not technically difficult, it just brings a host of decisions to be taken... Maybe even more important, does running against the jars add any value?
> The compile will be included in the 'all' target to test the implementation. Feel free to post your concerns if you think building the package private tests should be a manual action only.
> The tests will also be run as part of junit-all / junitreport.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3149) Add ant targets for building and
running the package private tests against the classes directories
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-3149:
-----------------------------------
Derby Info: [Patch Available]
> Add ant targets for building and running the package private tests against the classes directories
> --------------------------------------------------------------------------------------------------
>
> Key: DERBY-3149
> URL: https://issues.apache.org/jira/browse/DERBY-3149
> Project: Derby
> Issue Type: Sub-task
> Components: Build tools, Test
> Affects Versions: 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3149-1a.diff, derby-3149-1a.stat
>
>
> Create ant targets in build.xml to compile and run the package private tests.
> The first step will be to run the tests against the classes directories. Implementing a solution that runs against jars is not technically difficult, it just brings a host of decisions to be taken... Maybe even more important, does running against the jars add any value?
> The compile will be included in the 'all' target to test the implementation. Feel free to post your concerns if you think building the package private tests should be a manual action only.
> The tests will also be run as part of junit-all / junitreport.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3149) Add ant targets for building and
running the package private tests against the classes directories
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12555851#action_12555851 ]
Kristian Waagan commented on DERBY-3149:
----------------------------------------
Regarding why junit-pptesting isn't adding junit.jar automatically, I'm not quite sure.
I experimented a little bit, but it seems that with my ant version (1.6.5) adding the jar in the target isn't enough. Even if I add tools/java/junit.jar to the classpath for target junit-pptesting I'm not able to run it without already having told ant where to find it (I currently have a junit.jar in ~/.ant/lib). I think ant needs junit.jar to "initialize" the junit task.
I know this area is a bit tricky with ant, and they also have a FAQ-entry for it: http://ant.apache.org/faq.html#delegating-classloader-1.6
Maybe ant 1.7 solves the problem for us, but we only require 1.6.3 (or higher) to build Derby.
It would be nice if someone knowing ant well could help find the best way to do this.
> Add ant targets for building and running the package private tests against the classes directories
> --------------------------------------------------------------------------------------------------
>
> Key: DERBY-3149
> URL: https://issues.apache.org/jira/browse/DERBY-3149
> Project: Derby
> Issue Type: Sub-task
> Components: Build tools, Test
> Affects Versions: 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3149-1a.diff, derby-3149-1a.stat, derby-3149-1b.diff, derby-3149-2a-conditional_compilation_fix.diff, derby-3149-2b-conditional_compilation_fix.diff
>
>
> Create ant targets in build.xml to compile and run the package private tests.
> The first step will be to run the tests against the classes directories. Implementing a solution that runs against jars is not technically difficult, it just brings a host of decisions to be taken... Maybe even more important, does running against the jars add any value?
> The compile will be included in the 'all' target to test the implementation. Feel free to post your concerns if you think building the package private tests should be a manual action only.
> The tests will also be run as part of junit-all / junitreport.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3149) Add ant targets for building and
running the package private tests against the classes directories
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-3149:
-----------------------------------
Derby Info: [Patch Available]
> Add ant targets for building and running the package private tests against the classes directories
> --------------------------------------------------------------------------------------------------
>
> Key: DERBY-3149
> URL: https://issues.apache.org/jira/browse/DERBY-3149
> Project: Derby
> Issue Type: Sub-task
> Components: Build tools, Test
> Affects Versions: 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3149-1a.diff, derby-3149-1a.stat, derby-3149-1b.diff, derby-3149-2a-conditional_compilation_fix.diff, derby-3149-2b-conditional_compilation_fix.diff, derby-3149-4a-compile_against_15_libraries.diff, pptesting_use_jdk16_executable_diff.txt
>
>
> Create ant targets in build.xml to compile and run the package private tests.
> The first step will be to run the tests against the classes directories. Implementing a solution that runs against jars is not technically difficult, it just brings a host of decisions to be taken... Maybe even more important, does running against the jars add any value?
> The compile will be included in the 'all' target to test the implementation. Feel free to post your concerns if you think building the package private tests should be a manual action only.
> The tests will also be run as part of junit-all / junitreport.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3149) Add ant targets for building and
running the package private tests against the classes directories
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542404 ]
Dag H. Wanvik commented on DERBY-3149:
--------------------------------------
Ok, I was not aware that setting debug always true is a common pattern in the testing code.
If that's the case, I agree its good. I just seemed to remember once having to go through hoops
to get the debug variable set for some testing code which had not inherited the debug flag correctly
on the basis of sanity=sane, so I assumed it used the pattern common elsewhere in the code
(outside testing). Lesson: don't assume, check first ;)
> Add ant targets for building and running the package private tests against the classes directories
> --------------------------------------------------------------------------------------------------
>
> Key: DERBY-3149
> URL: https://issues.apache.org/jira/browse/DERBY-3149
> Project: Derby
> Issue Type: Sub-task
> Components: Build tools, Test
> Affects Versions: 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3149-1a.diff, derby-3149-1a.stat, derby-3149-1b.diff, derby-3149-2a-conditional_compilation_fix.diff, derby-3149-2b-conditional_compilation_fix.diff
>
>
> Create ant targets in build.xml to compile and run the package private tests.
> The first step will be to run the tests against the classes directories. Implementing a solution that runs against jars is not technically difficult, it just brings a host of decisions to be taken... Maybe even more important, does running against the jars add any value?
> The compile will be included in the 'all' target to test the implementation. Feel free to post your concerns if you think building the package private tests should be a manual action only.
> The tests will also be run as part of junit-all / junitreport.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-3149) Add ant targets for building and
running the package private tests against the classes directories
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan resolved DERBY-3149.
------------------------------------
Resolution: Fixed
Derby Info: (was: [Patch Available])
I take that as a go. You might want to try building with JAVA_HOME set to JDK 1.6, unless you have already done that.
Committed 'derby-3149-4a-compile_against_15_libraries.diff' to trunk with revision 610358.
Unless there are problems, I don't plan to do more work under this issue.
> Add ant targets for building and running the package private tests against the classes directories
> --------------------------------------------------------------------------------------------------
>
> Key: DERBY-3149
> URL: https://issues.apache.org/jira/browse/DERBY-3149
> Project: Derby
> Issue Type: Sub-task
> Components: Build tools, Test
> Affects Versions: 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3149-1a.diff, derby-3149-1a.stat, derby-3149-1b.diff, derby-3149-2a-conditional_compilation_fix.diff, derby-3149-2b-conditional_compilation_fix.diff, derby-3149-4a-compile_against_15_libraries.diff, pptesting_use_jdk16_executable_diff.txt
>
>
> Create ant targets in build.xml to compile and run the package private tests.
> The first step will be to run the tests against the classes directories. Implementing a solution that runs against jars is not technically difficult, it just brings a host of decisions to be taken... Maybe even more important, does running against the jars add any value?
> The compile will be included in the 'all' target to test the implementation. Feel free to post your concerns if you think building the package private tests should be a manual action only.
> The tests will also be run as part of junit-all / junitreport.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3149) Add ant targets for building and
running the package private tests against the classes directories
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden updated DERBY-3149:
----------------------------------
Attachment: pptesting_use_jdk16_executable_diff.txt
I would like to make a small change to the build.xml file to use the jdk16 executable to build the pptesting target. It currently uses the default javac to compile against ${java16compile.classpath}. This can cause problems when jdk 1.5 is the default javac and ${java16compile.classpath} is set to IBM 1.6
See attached patch pptesting_use_jdk16_executable_diff.txt
> Add ant targets for building and running the package private tests against the classes directories
> --------------------------------------------------------------------------------------------------
>
> Key: DERBY-3149
> URL: https://issues.apache.org/jira/browse/DERBY-3149
> Project: Derby
> Issue Type: Sub-task
> Components: Build tools, Test
> Affects Versions: 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3149-1a.diff, derby-3149-1a.stat, derby-3149-1b.diff, derby-3149-2a-conditional_compilation_fix.diff, derby-3149-2b-conditional_compilation_fix.diff, pptesting_use_jdk16_executable_diff.txt
>
>
> Create ant targets in build.xml to compile and run the package private tests.
> The first step will be to run the tests against the classes directories. Implementing a solution that runs against jars is not technically difficult, it just brings a host of decisions to be taken... Maybe even more important, does running against the jars add any value?
> The compile will be included in the 'all' target to test the implementation. Feel free to post your concerns if you think building the package private tests should be a manual action only.
> The tests will also be run as part of junit-all / junitreport.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3149) Add ant targets for building and
running the package private tests against the classes directories
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12556859#action_12556859 ]
Knut Anders Hatlen commented on DERBY-3149:
-------------------------------------------
I think java15compile.classpath is initialized by the property setter added in DERBY-3117. It was enabled by default in revision 605224, so it should be safe to use it now.
> Add ant targets for building and running the package private tests against the classes directories
> --------------------------------------------------------------------------------------------------
>
> Key: DERBY-3149
> URL: https://issues.apache.org/jira/browse/DERBY-3149
> Project: Derby
> Issue Type: Sub-task
> Components: Build tools, Test
> Affects Versions: 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3149-1a.diff, derby-3149-1a.stat, derby-3149-1b.diff, derby-3149-2a-conditional_compilation_fix.diff, derby-3149-2b-conditional_compilation_fix.diff, pptesting_use_jdk16_executable_diff.txt
>
>
> Create ant targets in build.xml to compile and run the package private tests.
> The first step will be to run the tests against the classes directories. Implementing a solution that runs against jars is not technically difficult, it just brings a host of decisions to be taken... Maybe even more important, does running against the jars add any value?
> The compile will be included in the 'all' target to test the implementation. Feel free to post your concerns if you think building the package private tests should be a manual action only.
> The tests will also be run as part of junit-all / junitreport.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3149) Add ant targets for building and
running the package private tests against the classes directories
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-3149:
-----------------------------------
Attachment: derby-3149-4a-compile_against_15_libraries.diff
'derby-3149-4a-compile_against_15_libraries.diff' changes the build files to build the package-private test classes against Java SE 5.0 libraries.
I tried pointing j15lib to Sun JDK 1.6 and it worked fine.
People using the IBM VMs might want to try the same before the patch is committed (build target is 'pptesting', run clobber/clean or delete classes.pptesting).
Ready for review.
> Add ant targets for building and running the package private tests against the classes directories
> --------------------------------------------------------------------------------------------------
>
> Key: DERBY-3149
> URL: https://issues.apache.org/jira/browse/DERBY-3149
> Project: Derby
> Issue Type: Sub-task
> Components: Build tools, Test
> Affects Versions: 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3149-1a.diff, derby-3149-1a.stat, derby-3149-1b.diff, derby-3149-2a-conditional_compilation_fix.diff, derby-3149-2b-conditional_compilation_fix.diff, derby-3149-4a-compile_against_15_libraries.diff, pptesting_use_jdk16_executable_diff.txt
>
>
> Create ant targets in build.xml to compile and run the package private tests.
> The first step will be to run the tests against the classes directories. Implementing a solution that runs against jars is not technically difficult, it just brings a host of decisions to be taken... Maybe even more important, does running against the jars add any value?
> The compile will be included in the 'all' target to test the implementation. Feel free to post your concerns if you think building the package private tests should be a manual action only.
> The tests will also be run as part of junit-all / junitreport.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3149) Add ant targets for building and
running the package private tests against the classes directories
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-3149:
-----------------------------------
Attachment: derby-3149-1b.diff
'derby-3149-1b.diff' refreshes the patch (there was a merge conflict in build.xml) and I decided not to run the junit-pptesting as part of junit-all/junitreport. The reason is that those targets are capable of running against jars or classes, whereas the package-private tests must be run against classes.
A few comments:
* Two new targets; 'pptesting' (compile) and 'junit-pptesting' (run).
* Compile target 'pptesting' is included in target 'all'.
* Compile target 'pptesting' is not included in target 'testing'.
* Class files are put into 'classes.pptesting'.
Currently there are 94 tests, and they take around 6 seconds to run on my machine.
> Add ant targets for building and running the package private tests against the classes directories
> --------------------------------------------------------------------------------------------------
>
> Key: DERBY-3149
> URL: https://issues.apache.org/jira/browse/DERBY-3149
> Project: Derby
> Issue Type: Sub-task
> Components: Build tools, Test
> Affects Versions: 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3149-1a.diff, derby-3149-1a.stat, derby-3149-1b.diff
>
>
> Create ant targets in build.xml to compile and run the package private tests.
> The first step will be to run the tests against the classes directories. Implementing a solution that runs against jars is not technically difficult, it just brings a host of decisions to be taken... Maybe even more important, does running against the jars add any value?
> The compile will be included in the 'all' target to test the implementation. Feel free to post your concerns if you think building the package private tests should be a manual action only.
> The tests will also be run as part of junit-all / junitreport.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.