[jira] [Created] (SPARK-20038) FileFormatWriter.ExecuteWriteTask.releaseResources() implementations to be re-entrant

["Steve Loughran (JIRA)" <ji...@apache.org>]

Steve Loughran created SPARK-20038:
--------------------------------------

             Summary: FileFormatWriter.ExecuteWriteTask.releaseResources() implementations to be re-entrant
                 Key: SPARK-20038
                 URL: https://issues.apache.org/jira/browse/SPARK-20038
             Project: Spark
          Issue Type: Improvement
          Components: Spark Core
    Affects Versions: 2.2.0
            Reporter: Steve Loughran
            Priority: Minor


Both {{FileFormatWriter.ExecuteWriteTask.releaseResources()}} implementations {{close()}} any non-null {{currentWriter}}, then set the field to null

However, if the close() call throws an exception in the execution of {{{FileFormatWriter.executeTask}}, the exception handler will attempt to cleanup, by calling {{releaseResources()}} again. Looking at the codepath, this may cause {{committer.abortTask()}} to get skipped on failure.


This surfaces in SPARK-10109 and I've just seen it in HADOOP-14204); Parquet seems to be in the trace as it NPEs the second time it's {{close()}} method is called.

Fix: always set {{currentWriter}} to null,



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org