You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sedona.apache.org by "jbampton (via GitHub)" <gi...@apache.org> on 2026/06/24 06:58:20 UTC

[PR] [GH-3011] Pin all pre-commit hooks to SHA for supply chain security [sedona]

jbampton opened a new pull request, #3082:
URL: https://github.com/apache/sedona/pull/3082

   ## Did you read the Contributor Guide?
   
   - Yes, I have read the [Contributor Rules](https://sedona.apache.org/latest/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest/community/develop/)
   
   ## Is this PR related to a ticket?
   
   - Yes, and the PR name follows the format `[GH-XXX] my subject`. Closes #3011
   
   ## What changes were proposed in this PR?
   
   Pinned all hooks to latest SHA for supply chain security.
   
   Using prek now so set `minimum_prek_version` similar to Apache Airflow:
   
   https://github.com/apache/airflow/blob/b788d83d215ec9fe6b289c3021a726997ca3d8a3/.pre-commit-config.yaml#L19
   
   Updated additional dependency version for Prettier
   
   ## How was this patch tested?
   
   With prek
   
   ## Did this PR include necessary documentation updates?
   
   - No, this PR does not affect any public API so no need to change the documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [GH-3011] Pin all pre-commit hooks to SHA for supply chain security [sedona]

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu merged PR #3082:
URL: https://github.com/apache/sedona/pull/3082


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [GH-3011] Pin all pre-commit hooks to SHA for supply chain security [sedona]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #3082:
URL: https://github.com/apache/sedona/pull/3082#discussion_r3475906309


##########
.pre-commit-config.yaml:
##########
@@ -21,7 +21,7 @@ default_stages: [pre-commit, pre-push]
 default_language_version:
   python: python3
   node: 24.16.0
-minimum_pre_commit_version: '3.2.0'
+minimum_prek_version: '0.3.4'

Review Comment:
   `minimum_prek_version` is set to 0.3.4, but the repo’s dev dependency requires `prek>=0.4.0` (see `pyproject.toml`). Setting the minimum lower than what the project actually supports can allow contributors to run an older `prek` and hit unexpected config/behavior differences.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [GH-3011] Pin all pre-commit hooks to SHA for supply chain security [sedona]

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on PR #3082:
URL: https://github.com/apache/sedona/pull/3082#issuecomment-4889636129

   @jbampton please address conflict


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org