You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Kenneth Giusti <kg...@apache.org> on 2013/12/03 18:36:44 UTC
Re: Review Request 15458: Proton-J/Messenger: port the credit scheduling
algorithm from the C implementation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15458/
-----------------------------------------------------------
(Updated Dec. 3, 2013, 5:36 p.m.)
Review request for qpid and Rafael Schloming.
Bugs: PROTON-200
https://issues.apache.org/jira/browse/PROTON-200
Repository: qpid
Description
-------
Ports the credit scheduler that is implemented in the C implementation of Messenger to the Java implementation.
Enables the credit scheduler unit tests for Java.
Fixes some API behavior that was inconsistent between the two implementations.
Diffs
-----
/proton/trunk/proton-c/bindings/java/src/main/java/org/apache/qpid/proton/engine/jni/JNIDelivery.java 1541098
/proton/trunk/proton-c/bindings/java/src/main/java/org/apache/qpid/proton/engine/jni/JNILink.java 1541098
/proton/trunk/proton-c/bindings/java/src/main/java/org/apache/qpid/proton/engine/jni/JNIReceiver.java 1541098
/proton/trunk/proton-c/bindings/java/src/main/java/org/apache/qpid/proton/messenger/jni/JNIMessenger.java 1541098
/proton/trunk/proton-c/include/proton/messenger.h 1541098
/proton/trunk/proton-c/src/messenger/messenger.c 1541098
/proton/trunk/proton-j/proton-api/src/main/java/org/apache/qpid/proton/driver/Driver.java 1541098
/proton/trunk/proton-j/proton-api/src/main/java/org/apache/qpid/proton/engine/Delivery.java 1541098
/proton/trunk/proton-j/proton-api/src/main/java/org/apache/qpid/proton/engine/Link.java 1541098
/proton/trunk/proton-j/proton-api/src/main/java/org/apache/qpid/proton/engine/Receiver.java 1541098
/proton/trunk/proton-j/proton-api/src/main/java/org/apache/qpid/proton/messenger/Messenger.java 1541098
/proton/trunk/proton-j/proton-api/src/main/java/org/apache/qpid/proton/messenger/Status.java 1541098
/proton/trunk/proton-j/proton-api/src/main/resources/proton.py 1541098
/proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/driver/impl/DriverImpl.java 1541098
/proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/engine/impl/DeliveryImpl.java 1541098
/proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/engine/impl/LinkImpl.java 1541098
/proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/engine/impl/ReceiverImpl.java 1541098
/proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/messenger/impl/MessengerImpl.java 1541098
/proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/messenger/impl/StoreEntry.java 1541098
/proton/trunk/tests/python/proton_tests/messenger.py 1541098
Diff: https://reviews.apache.org/r/15458/diff/
Testing
-------
unit tests.
Thanks,
Kenneth Giusti
Re: Review Request 15458: Proton-J/Messenger: port the credit scheduling
algorithm from the C implementation.
Posted by Rafael Schloming <rh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15458/#review29665
-----------------------------------------------------------
Ship it!
Ship It!
- Rafael Schloming
On Dec. 3, 2013, 5:36 p.m., Kenneth Giusti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15458/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2013, 5:36 p.m.)
>
>
> Review request for qpid and Rafael Schloming.
>
>
> Bugs: PROTON-200
> https://issues.apache.org/jira/browse/PROTON-200
>
>
> Repository: qpid
>
>
> Description
> -------
>
> Ports the credit scheduler that is implemented in the C implementation of Messenger to the Java implementation.
>
> Enables the credit scheduler unit tests for Java.
>
> Fixes some API behavior that was inconsistent between the two implementations.
>
>
> Diffs
> -----
>
> /proton/trunk/proton-c/bindings/java/src/main/java/org/apache/qpid/proton/engine/jni/JNIDelivery.java 1541098
> /proton/trunk/proton-c/bindings/java/src/main/java/org/apache/qpid/proton/engine/jni/JNILink.java 1541098
> /proton/trunk/proton-c/bindings/java/src/main/java/org/apache/qpid/proton/engine/jni/JNIReceiver.java 1541098
> /proton/trunk/proton-c/bindings/java/src/main/java/org/apache/qpid/proton/messenger/jni/JNIMessenger.java 1541098
> /proton/trunk/proton-c/include/proton/messenger.h 1541098
> /proton/trunk/proton-c/src/messenger/messenger.c 1541098
> /proton/trunk/proton-j/proton-api/src/main/java/org/apache/qpid/proton/driver/Driver.java 1541098
> /proton/trunk/proton-j/proton-api/src/main/java/org/apache/qpid/proton/engine/Delivery.java 1541098
> /proton/trunk/proton-j/proton-api/src/main/java/org/apache/qpid/proton/engine/Link.java 1541098
> /proton/trunk/proton-j/proton-api/src/main/java/org/apache/qpid/proton/engine/Receiver.java 1541098
> /proton/trunk/proton-j/proton-api/src/main/java/org/apache/qpid/proton/messenger/Messenger.java 1541098
> /proton/trunk/proton-j/proton-api/src/main/java/org/apache/qpid/proton/messenger/Status.java 1541098
> /proton/trunk/proton-j/proton-api/src/main/resources/proton.py 1541098
> /proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/driver/impl/DriverImpl.java 1541098
> /proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/engine/impl/DeliveryImpl.java 1541098
> /proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/engine/impl/LinkImpl.java 1541098
> /proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/engine/impl/ReceiverImpl.java 1541098
> /proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/messenger/impl/MessengerImpl.java 1541098
> /proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/messenger/impl/StoreEntry.java 1541098
> /proton/trunk/tests/python/proton_tests/messenger.py 1541098
>
> Diff: https://reviews.apache.org/r/15458/diff/
>
>
> Testing
> -------
>
> unit tests.
>
>
> Thanks,
>
> Kenneth Giusti
>
>