You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2014/08/12 09:57:12 UTC

[jira] [Commented] (WICKET-5539) Allow preserving of the parsed PageParameters when re-creating an expired page

    [ https://issues.apache.org/jira/browse/WICKET-5539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14093862#comment-14093862 ] 

ASF subversion and git services commented on WICKET-5539:
---------------------------------------------------------

Commit f6eaa937d4cdda9fd04c3c5312eaca66d5fb52a2 in wicket's branch refs/heads/5539-hook-for-listener-parameters from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=f6eaa93 ]

WICKET-5539 Allow preserving of the parsed PageParameters when re-creating an expired page

Remove 'final' modifier for all mount related methods in WebApplication


> Allow preserving of the parsed PageParameters when re-creating an expired page
> ------------------------------------------------------------------------------
>
>                 Key: WICKET-5539
>                 URL: https://issues.apache.org/jira/browse/WICKET-5539
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 6.14.0
>            Reporter: Ilia Naryzhny
>            Assignee: Martin Grigorov
>              Labels: expiration, mountBookmarkablePage
>             Fix For: 6.17.0
>
>         Attachments: wicket5539.zip
>
>
> There is a bookmarkable page mounted, for example, to:
> /page/${entityId}
> This page contains StatelessForm.
> Submitting of form after session expire lead to following:
> org.apache.wicket.core.request.mapper.MountedMapper invokes AbstractBookmarkableMapper.processListener to obtain IRequestHandler to handle submitting of form. 
> But there is cleaning of PageParameters within processListener on line 256 (Wicket 6.14) which cleaning "entityId" parameter as well and created page finally has no "enityId" and (in our case) redirects to 404.
> I see that this cleaning of page parameters was implemented due to Wicket-4594. But I think, just checking for pageId is unsufficient, because pageId might be not null, but actual page may be already expired and new instance should be created.



--
This message was sent by Atlassian JIRA
(v6.2#6252)