You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/05/05 14:03:07 UTC

[GitHub] [airflow] jmcarp commented on a change in pull request #5030: [AIRFLOW-4227] Use python3-style type annotations.

jmcarp commented on a change in pull request #5030: [AIRFLOW-4227] Use python3-style type annotations.
URL: https://github.com/apache/airflow/pull/5030#discussion_r281023316
 
 

 ##########
 File path: tests/plugins/test_plugin.py
 ##########
 @@ -99,7 +99,7 @@ class AirflowTestPlugin(AirflowPlugin):
     flask_blueprints = [bp]
     appbuilder_views = [v_appbuilder_package]
     appbuilder_menu_items = [appbuilder_mitem]
-    stat_name_handler = staticmethod(stat_name_dummy_handler)
+    stat_name_handler = stat_name_dummy_handler
 
 Review comment:
   That's right @ashb, and mypy might be right to complain about `staticmethod` here, since `stat_name_dummy_handler` is a function and not a method, and already has the expected signature.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services