You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2017/12/15 08:28:24 UTC

[GitHub] kwin commented on a change in pull request #1: SLING-7299 do not always attach built artifact

kwin commented on a change in pull request #1: SLING-7299 do not always attach built artifact
URL: https://github.com/apache/sling-slingstart-maven-plugin/pull/1#discussion_r157144904
 
 

 ##########
 File path: src/main/java/org/apache/sling/maven/slingstart/PackageMojo.java
 ##########
 @@ -51,6 +52,13 @@
      */
     @Parameter(defaultValue="false")
     protected boolean createWebapp;
+    
+    /**
+     * If set to {@code true} does not attach the generated artifact to Maven.
 
 Review comment:
   Good catch, fixed with https://github.com/apache/sling-slingstart-maven-plugin/commit/d6203e5aaadc1ad10bc11625bf7f8f1d92299da3.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services