You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "Rick Kellogg (JIRA)" <ji...@apache.org> on 2015/10/05 03:04:27 UTC

[jira] [Updated] (STORM-683) Configs set to false do not always evaluate to false.

     [ https://issues.apache.org/jira/browse/STORM-683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rick Kellogg updated STORM-683:
-------------------------------
    Component/s: storm-core

> Configs set to false do not always evaluate to false.
> -----------------------------------------------------
>
>                 Key: STORM-683
>                 URL: https://issues.apache.org/jira/browse/STORM-683
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>            Priority: Blocker
>             Fix For: 0.10.0
>
>
> We just ran into a situation where for a specific boolean config a user was setting it to false, and it was evaluating as true.
> Turns out this is expected behavior
> http://dev.clojure.org/jira/browse/CLJ-1640
> The issue comes up that (Boolean. false) is not the same as Boolean/FALSE and can evaluate to true, but the way we deserialize the config (using JSON) all the booleans are the bad form.
> Ideally we cleanup the deserialization code to look for booleans and translate them to the appropriate values.  This feels cleaner than trying to have every place we access a config try to convert it first.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)