You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/11 06:54:07 UTC

[GitHub] [incubator-superset] graceguo-supercat opened a new pull request #8806: [dashboard] fix time granularity display values

graceguo-supercat opened a new pull request #8806: [dashboard] fix time granularity display values
URL: https://github.com/apache/incubator-superset/pull/8806
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [x] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Time related filter has following fields: time range, time granularity for sql datasource, time granularity for Druid datasource, time column, and Druid time origin. Each of the fields have pre-defined label. Granularity fields' options and display label are associated with datasource. 
   Before we only display these predefined labels and values in filter box. Recently we show filter values in more components, like filter indicator, filter scope selector, and these filter fields label shows inconsistently.
   
   This PR is to refactor the time related filter fields's label and display value, so that they should display consistently in all components.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   **before:**
   <img width="814" alt="Screen Shot 2019-12-05 at 11 39 58 AM" src="https://user-images.githubusercontent.com/27990562/70596191-15084b00-1b9a-11ea-95bf-4591b2c5dbe6.png">
   
   **after:**
   <img width="822" alt="Screen Shot 2019-12-10 at 10 14 27 PM" src="https://user-images.githubusercontent.com/27990562/70596328-7cbe9600-1b9a-11ea-87f1-f67a986daf90.png">
   
   
   ### TEST PLAN
   CI and manual test
   
   
   ### REVIEWERS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org