You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@royale.apache.org by Serkan Taş <se...@likyateknoloji.com> on 2018/10/04 11:08:15 UTC
Using (mxmlc) compiler after modification
Hi,
After searching the codebase, i found that
/org.apache.royale.compiler.internal.codegen.js.jx.BinaryOperatorEmitter
/is using enum /DatePropertiesGetters /and in this class toUpper is used
3 times. May be it can be changed to toUpperCase(Locale.ENGLISH)
I changed this class in my local path :
apache-royale-0.9.4-bin-js-swf\royale-compiler\compiler-jx and compiled
with maven and finished iwth ssuccess. But i am not sure how to test new
compiler :)
I need to test the compiler after rebuilding with maven
(\apache-royale-0.9.4-bin-js-swf\royale-compiler). How can i do ?
Thanks in advance.
Serkan.
Re: Using (mxmlc) compiler after modification
Posted by Serkan Taş <se...@likyateknoloji.com>.
I checked some maven plugins to set the locale through pom but could not
find any option available for flex code generator plugins.
I am going to contuniue setting maven options through env within batch
sripts.
thanks.
Serkan
5.10.2018 02:05 tarihinde Alex Harui yazdı:
>
> Hi Serkan,
>
> Looking at the error again, it appears to be a Java issue and not that
> the compiler calling toUpper. Or maybe the source file for
> BinaryOperatorEmiitter doesn’t have a file-encoding. So you may need
> to set those options in MAVEN_OPTS and/or ANT_OPTS in order to get it
> to work.
>
> HTH,
>
> -Alex
>
> *From: *Serkan Taş <se...@likyateknoloji.com>
> *Reply-To: *"users@royale.apache.org" <us...@royale.apache.org>
> *Date: *Thursday, October 4, 2018 at 3:34 PM
> *To: *"users@royale.apache.org" <us...@royale.apache.org>
> *Subject: *Re: Using (mxmlc) compiler after modification
>
> You are right, I am using mxlmc for compiling application.
>
> I mean compiling compiler project (compiler-jx) with maven, not my
> compiling my application with maven.
>
> if compiler-jx folder under royale-compiler depends on 3rd party than ok.
>
> 4.10.2018 22:49 tarihinde Alex Harui yazdı:
>
> When you use Maven to compile the application it will load up the
> jars from the local repository. No lib or js/lib folder is needed
> for Maven. I thought I saw that you are using js/bin/mxmlc to
> compile from the command line which won’t pick up the Maven jars.
>
> The code that is calling toUpper may be in third party code, like
> JBurg which may be why your change isn’t making a difference.
> BinaryOperatorEmitter only handles certain binary operator
> expressions.
>
> HTH,
>
> -Alex
>
> *From: *Serkan Taş <se...@likyateknoloji.com>
> <ma...@likyateknoloji.com>
> *Reply-To: *"users@royale.apache.org"
> <ma...@royale.apache.org> <us...@royale.apache.org>
> <ma...@royale.apache.org>
> *Date: *Thursday, October 4, 2018 at 11:57 AM
> *To: *"users@royale.apache.org" <ma...@royale.apache.org>
> <us...@royale.apache.org> <ma...@royale.apache.org>
> *Subject: *Re: Using (mxmlc) compiler after modification
>
> Hi,
>
> I am using maven for both. The source code i modified is under
> project "compiler-jx". An the generated jar is :
> compiler-jx-0.9.4-SNAPSHOT.jar
>
> I colud not be able find the place to put this jar beacuse there
> is no jar in royale-asjs\lib or royale-asjs\js\lib containing
> "compiler-jx" in name :)
>
> Thanx
>
> Serkan
>
> 4.10.2018 20:37 tarihinde Alex Harui yazdı:
>
> If you build the compiler with Maven, it is expected that you
> will build the application with Maven as well.
>
> If you build the compiler with Ant, it is expected that you
> will build the application with Ant.
>
> That said, in the nightly builds, the compiler Jars are copied
> into royale-asjs/lib and royale-asjs/js/lib so you could grab
> the Maven artifacts and rename them and overwrite the Ant
> ones. I haven’t tried that, but in theory it should work.
>
> HTH,
>
> -Alex
>
> *From: *Serkan Taş <se...@likyateknoloji.com>
> <ma...@likyateknoloji.com>
> *Reply-To: *"users@royale.apache.org"
> <ma...@royale.apache.org> <us...@royale.apache.org>
> <ma...@royale.apache.org>
> *Date: *Thursday, October 4, 2018 at 4:08 AM
> *To: *"users@royale.apache.org"
> <ma...@royale.apache.org> <us...@royale.apache.org>
> <ma...@royale.apache.org>
> *Subject: *Using (mxmlc) compiler after modification
>
> Hi,
>
> After searching the codebase, i found that
> /org.apache.royale.compiler.internal.codegen.js.jx.BinaryOperatorEmitter
> /is using enum /DatePropertiesGetters /and in this class
> toUpper is used 3 times. May be it can be changed to
> toUpperCase(Locale.ENGLISH)
>
> I changed this class in my local path :
> apache-royale-0.9.4-bin-js-swf\royale-compiler\compiler-jx and
> compiled with maven and finished iwth ssuccess. But i am not
> sure how to test new compiler :)
>
> I need to test the compiler after rebuilding with maven
> (\apache-royale-0.9.4-bin-js-swf\royale-compiler). How can i do ?
>
> Thanks in advance.
>
> Serkan.
>
Re: Using (mxmlc) compiler after modification
Posted by Alex Harui <ah...@adobe.com>.
Hi Serkan,
Looking at the error again, it appears to be a Java issue and not that the compiler calling toUpper. Or maybe the source file for BinaryOperatorEmiitter doesn’t have a file-encoding. So you may need to set those options in MAVEN_OPTS and/or ANT_OPTS in order to get it to work.
HTH,
-Alex
From: Serkan Taş <se...@likyateknoloji.com>
Reply-To: "users@royale.apache.org" <us...@royale.apache.org>
Date: Thursday, October 4, 2018 at 3:34 PM
To: "users@royale.apache.org" <us...@royale.apache.org>
Subject: Re: Using (mxmlc) compiler after modification
You are right, I am using mxlmc for compiling application.
I mean compiling compiler project (compiler-jx) with maven, not my compiling my application with maven.
if compiler-jx folder under royale-compiler depends on 3rd party than ok.
4.10.2018 22:49 tarihinde Alex Harui yazdı:
When you use Maven to compile the application it will load up the jars from the local repository. No lib or js/lib folder is needed for Maven. I thought I saw that you are using js/bin/mxmlc to compile from the command line which won’t pick up the Maven jars.
The code that is calling toUpper may be in third party code, like JBurg which may be why your change isn’t making a difference. BinaryOperatorEmitter only handles certain binary operator expressions.
HTH,
-Alex
From: Serkan Taş <se...@likyateknoloji.com>
Reply-To: "users@royale.apache.org"<ma...@royale.apache.org> <us...@royale.apache.org>
Date: Thursday, October 4, 2018 at 11:57 AM
To: "users@royale.apache.org"<ma...@royale.apache.org> <us...@royale.apache.org>
Subject: Re: Using (mxmlc) compiler after modification
Hi,
I am using maven for both. The source code i modified is under project "compiler-jx". An the generated jar is : compiler-jx-0.9.4-SNAPSHOT.jar
I colud not be able find the place to put this jar beacuse there is no jar in royale-asjs\lib or royale-asjs\js\lib containing "compiler-jx" in name :)
Thanx
Serkan
4.10.2018 20:37 tarihinde Alex Harui yazdı:
If you build the compiler with Maven, it is expected that you will build the application with Maven as well.
If you build the compiler with Ant, it is expected that you will build the application with Ant.
That said, in the nightly builds, the compiler Jars are copied into royale-asjs/lib and royale-asjs/js/lib so you could grab the Maven artifacts and rename them and overwrite the Ant ones. I haven’t tried that, but in theory it should work.
HTH,
-Alex
From: Serkan Taş <se...@likyateknoloji.com>
Reply-To: "users@royale.apache.org"<ma...@royale.apache.org> <us...@royale.apache.org>
Date: Thursday, October 4, 2018 at 4:08 AM
To: "users@royale.apache.org"<ma...@royale.apache.org> <us...@royale.apache.org>
Subject: Using (mxmlc) compiler after modification
Hi,
After searching the codebase, i found that org.apache.royale.compiler.internal.codegen.js.jx.BinaryOperatorEmitter is using enum DatePropertiesGetters and in this class toUpper is used 3 times. May be it can be changed to toUpperCase(Locale.ENGLISH)
I changed this class in my local path : apache-royale-0.9.4-bin-js-swf\royale-compiler\compiler-jx and compiled with maven and finished iwth ssuccess. But i am not sure how to test new compiler :)
I need to test the compiler after rebuilding with maven (\apache-royale-0.9.4-bin-js-swf\royale-compiler). How can i do ?
Thanks in advance.
Serkan.
Re: Using (mxmlc) compiler after modification
Posted by Serkan Taş <se...@likyateknoloji.com>.
You are right, I am using mxlmc for compiling application.
I mean compiling compiler project (compiler-jx) with maven, not my
compiling my application with maven.
if compiler-jx folder under royale-compiler depends on 3rd party than ok.
4.10.2018 22:49 tarihinde Alex Harui yazdı:
>
> When you use Maven to compile the application it will load up the jars
> from the local repository. No lib or js/lib folder is needed for
> Maven. I thought I saw that you are using js/bin/mxmlc to compile
> from the command line which won’t pick up the Maven jars.
>
> The code that is calling toUpper may be in third party code, like
> JBurg which may be why your change isn’t making a difference.
> BinaryOperatorEmitter only handles certain binary operator expressions.
>
> HTH,
>
> -Alex
>
> *From: *Serkan Taş <se...@likyateknoloji.com>
> *Reply-To: *"users@royale.apache.org" <us...@royale.apache.org>
> *Date: *Thursday, October 4, 2018 at 11:57 AM
> *To: *"users@royale.apache.org" <us...@royale.apache.org>
> *Subject: *Re: Using (mxmlc) compiler after modification
>
> Hi,
>
> I am using maven for both. The source code i modified is under project
> "compiler-jx". An the generated jar is : compiler-jx-0.9.4-SNAPSHOT.jar
>
> I colud not be able find the place to put this jar beacuse there is no
> jar in royale-asjs\lib or royale-asjs\js\lib containing "compiler-jx"
> in name :)
>
> Thanx
>
> Serkan
>
> 4.10.2018 20:37 tarihinde Alex Harui yazdı:
>
> If you build the compiler with Maven, it is expected that you will
> build the application with Maven as well.
>
> If you build the compiler with Ant, it is expected that you will
> build the application with Ant.
>
> That said, in the nightly builds, the compiler Jars are copied
> into royale-asjs/lib and royale-asjs/js/lib so you could grab the
> Maven artifacts and rename them and overwrite the Ant ones. I
> haven’t tried that, but in theory it should work.
>
> HTH,
>
> -Alex
>
> *From: *Serkan Taş <se...@likyateknoloji.com>
> <ma...@likyateknoloji.com>
> *Reply-To: *"users@royale.apache.org"
> <ma...@royale.apache.org> <us...@royale.apache.org>
> <ma...@royale.apache.org>
> *Date: *Thursday, October 4, 2018 at 4:08 AM
> *To: *"users@royale.apache.org" <ma...@royale.apache.org>
> <us...@royale.apache.org> <ma...@royale.apache.org>
> *Subject: *Using (mxmlc) compiler after modification
>
> Hi,
>
> After searching the codebase, i found that
> /org.apache.royale.compiler.internal.codegen.js.jx.BinaryOperatorEmitter
> /is using enum /DatePropertiesGetters /and in this class toUpper
> is used 3 times. May be it can be changed to
> toUpperCase(Locale.ENGLISH)
>
> I changed this class in my local path :
> apache-royale-0.9.4-bin-js-swf\royale-compiler\compiler-jx and
> compiled with maven and finished iwth ssuccess. But i am not sure
> how to test new compiler :)
>
> I need to test the compiler after rebuilding with maven
> (\apache-royale-0.9.4-bin-js-swf\royale-compiler). How can i do ?
>
> Thanks in advance.
>
> Serkan.
>
Re: Using (mxmlc) compiler after modification
Posted by Alex Harui <ah...@adobe.com>.
When you use Maven to compile the application it will load up the jars from the local repository. No lib or js/lib folder is needed for Maven. I thought I saw that you are using js/bin/mxmlc to compile from the command line which won’t pick up the Maven jars.
The code that is calling toUpper may be in third party code, like JBurg which may be why your change isn’t making a difference. BinaryOperatorEmitter only handles certain binary operator expressions.
HTH,
-Alex
From: Serkan Taş <se...@likyateknoloji.com>
Reply-To: "users@royale.apache.org" <us...@royale.apache.org>
Date: Thursday, October 4, 2018 at 11:57 AM
To: "users@royale.apache.org" <us...@royale.apache.org>
Subject: Re: Using (mxmlc) compiler after modification
Hi,
I am using maven for both. The source code i modified is under project "compiler-jx". An the generated jar is : compiler-jx-0.9.4-SNAPSHOT.jar
I colud not be able find the place to put this jar beacuse there is no jar in royale-asjs\lib or royale-asjs\js\lib containing "compiler-jx" in name :)
Thanx
Serkan
4.10.2018 20:37 tarihinde Alex Harui yazdı:
If you build the compiler with Maven, it is expected that you will build the application with Maven as well.
If you build the compiler with Ant, it is expected that you will build the application with Ant.
That said, in the nightly builds, the compiler Jars are copied into royale-asjs/lib and royale-asjs/js/lib so you could grab the Maven artifacts and rename them and overwrite the Ant ones. I haven’t tried that, but in theory it should work.
HTH,
-Alex
From: Serkan Taş <se...@likyateknoloji.com>
Reply-To: "users@royale.apache.org"<ma...@royale.apache.org> <us...@royale.apache.org>
Date: Thursday, October 4, 2018 at 4:08 AM
To: "users@royale.apache.org"<ma...@royale.apache.org> <us...@royale.apache.org>
Subject: Using (mxmlc) compiler after modification
Hi,
After searching the codebase, i found that org.apache.royale.compiler.internal.codegen.js.jx.BinaryOperatorEmitter is using enum DatePropertiesGetters and in this class toUpper is used 3 times. May be it can be changed to toUpperCase(Locale.ENGLISH)
I changed this class in my local path : apache-royale-0.9.4-bin-js-swf\royale-compiler\compiler-jx and compiled with maven and finished iwth ssuccess. But i am not sure how to test new compiler :)
I need to test the compiler after rebuilding with maven (\apache-royale-0.9.4-bin-js-swf\royale-compiler). How can i do ?
Thanks in advance.
Serkan.
Re: Using (mxmlc) compiler after modification
Posted by Serkan Taş <se...@likyateknoloji.com>.
Hi,
I am using maven for both. The source code i modified is under project
"compiler-jx". An the generated jar is : compiler-jx-0.9.4-SNAPSHOT.jar
I colud not be able find the place to put this jar beacuse there is no
jar in royale-asjs\lib or royale-asjs\js\lib containing "compiler-jx" in
name :)
Thanx
Serkan
4.10.2018 20:37 tarihinde Alex Harui yazdı:
>
> If you build the compiler with Maven, it is expected that you will
> build the application with Maven as well.
>
> If you build the compiler with Ant, it is expected that you will build
> the application with Ant.
>
> That said, in the nightly builds, the compiler Jars are copied into
> royale-asjs/lib and royale-asjs/js/lib so you could grab the Maven
> artifacts and rename them and overwrite the Ant ones. I haven’t tried
> that, but in theory it should work.
>
> HTH,
>
> -Alex
>
> *From: *Serkan Taş <se...@likyateknoloji.com>
> *Reply-To: *"users@royale.apache.org" <us...@royale.apache.org>
> *Date: *Thursday, October 4, 2018 at 4:08 AM
> *To: *"users@royale.apache.org" <us...@royale.apache.org>
> *Subject: *Using (mxmlc) compiler after modification
>
> Hi,
>
> After searching the codebase, i found that
> /org.apache.royale.compiler.internal.codegen.js.jx.BinaryOperatorEmitter
> /is using enum /DatePropertiesGetters /and in this class toUpper is
> used 3 times. May be it can be changed to toUpperCase(Locale.ENGLISH)
>
> I changed this class in my local path :
> apache-royale-0.9.4-bin-js-swf\royale-compiler\compiler-jx and
> compiled with maven and finished iwth ssuccess. But i am not sure how
> to test new compiler :)
>
> I need to test the compiler after rebuilding with maven
> (\apache-royale-0.9.4-bin-js-swf\royale-compiler). How can i do ?
>
> Thanks in advance.
>
> Serkan.
>
Re: Using (mxmlc) compiler after modification
Posted by Alex Harui <ah...@adobe.com>.
If you build the compiler with Maven, it is expected that you will build the application with Maven as well.
If you build the compiler with Ant, it is expected that you will build the application with Ant.
That said, in the nightly builds, the compiler Jars are copied into royale-asjs/lib and royale-asjs/js/lib so you could grab the Maven artifacts and rename them and overwrite the Ant ones. I haven’t tried that, but in theory it should work.
HTH,
-Alex
From: Serkan Taş <se...@likyateknoloji.com>
Reply-To: "users@royale.apache.org" <us...@royale.apache.org>
Date: Thursday, October 4, 2018 at 4:08 AM
To: "users@royale.apache.org" <us...@royale.apache.org>
Subject: Using (mxmlc) compiler after modification
Hi,
After searching the codebase, i found that org.apache.royale.compiler.internal.codegen.js.jx.BinaryOperatorEmitter is using enum DatePropertiesGetters and in this class toUpper is used 3 times. May be it can be changed to toUpperCase(Locale.ENGLISH)
I changed this class in my local path : apache-royale-0.9.4-bin-js-swf\royale-compiler\compiler-jx and compiled with maven and finished iwth ssuccess. But i am not sure how to test new compiler :)
I need to test the compiler after rebuilding with maven (\apache-royale-0.9.4-bin-js-swf\royale-compiler). How can i do ?
Thanks in advance.
Serkan.